From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5E94C5AD4E for ; Mon, 10 Aug 2026 10:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hR2mpYa1hEEEJg8T0wJOEfhD4O5ENdkllff1OnoBpCc=; b=VF4D0ZeJHHupH2wMJ0pPRQs90k WyCzeRtviCW89pELFbHZ99jaUw+zcAVNLsMZ0Cq2wUtHSNhFIJUq6Ka6/L0XhfEU4VydGqAjE+s0M xKrFzudGi1LdOkuSwv4MTWjbku7U5QgMTwr4zY4RWTyeN2JYpMqbT3mucCDUjTAuQ3rNpYL1hzFH/ xrtS/eFXThhmp9k97KvuM6kYTMIWE272N4YS/N8Y7KDy+2Z7Bs9X8zD4C0uNJSB8VJC8GVDvywm5Z fAyjSolVILjVFwsV01453Ey8rNqv/FSPW+Kv0Nu7ovuNoQACmOODYOjyRLeUbDAffFzxPJmsz3uwr 23hBAX+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtMyV-0000000BSom-1pZi; Mon, 10 Aug 2026 10:11:19 +0000 Received: from mail-southcentralusazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c10d::3] helo=SN4PR0501CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtMyS-0000000BSmr-0NRE for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2026 10:11:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nWUTAdQ4DmDkhgJmPr9yeo0u/rxDDjkoHmWRJhusHw18iqC46QmC6JSKa7YSkfINkI2cACWp15wXfXpDfUdIuP7nbCnpFVqkO+ExoLe1K6SXSLCjxb6MaN3I3Lj4s/HMh9+1zjdCcxS6JoYZNdMegZNbI73r9vLfJWIM2yIueVvLRMV3bC0JZ4pVoBwpMNTfm8kUwvfqnbEJFYL0+1mRSLNFwCimNnwKvftS2MZfN12GtuJ63GDz9VFmpEWVN8Cq8PX4VmcW+DGg5t2fXmrgGsyxq6DUlgdX9gcu5OapLVQHRNKbCkGx+uKpxijKC4pdQDMvtfcikWaDUwr7vcWCxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hR2mpYa1hEEEJg8T0wJOEfhD4O5ENdkllff1OnoBpCc=; b=JdFgGgEcUvtKEIpew9rAu/yNU6NxWG/4yO5EF8rOvKv5IYjOj6rbg2yaqzAL2qVS5xNfaojqoWuHvJk1og6DY4suBTticP04hPMqHiFRiaSVX68olJ+sgFxTQ1ufEs3ZHntxa3FKm1QG3EcIpzf1KYfR+HVWQ0lbB9B1stmJupZ/rim7D8GAXXdXpm7sDC9pr7Mbqv8gBGyegKgENBL+HELN0zLZzlWLMWq0Z8MEL1aBEuvL5RPZANEBnuI7TEbIRzdqryK3VAL51x4xc0AIxTViKDQlW4PvcnQEKn8R+VROc0uWrCxd84+j8VXDp6XvDvcqQb9UKXEIibLuf59ihQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hR2mpYa1hEEEJg8T0wJOEfhD4O5ENdkllff1OnoBpCc=; b=zTcy/9nhDAN1aqJsyHJE8cjYWj+lEZMWPguB2lrDjxA+Et3qf3+gwhmwWV2+Di1kXmaAZBKtmLaK6u72vGUDvrTK9sUi+Q0LVauzD/4kN4gVoe3ybssdlOuVBA1cHidhLJr1tt0E8YIeDwM/zCqF3dIj+Uq2CUznF3XWblubtgc= Received: from SJ0PR03CA0144.namprd03.prod.outlook.com (2603:10b6:a03:33c::29) by LVXPR12MB999196.namprd12.prod.outlook.com (2603:10b6:408:3dc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 10:11:12 +0000 Received: from SJ1PEPF00001CEB.namprd03.prod.outlook.com (2603:10b6:a03:33c:cafe::61) by SJ0PR03CA0144.outlook.office365.com (2603:10b6:a03:33c::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 10:11:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF00001CEB.mail.protection.outlook.com (10.167.242.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 10:11:11 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 05:10:56 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 05:05:00 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Mon, 10 Aug 2026 05:04:57 -0500 From: Golla Nagendra To: , , , , , , CC: , , , , , , Subject: [PATCH V3 1/6] dmaengine: zynqmp_dma: Fix PM usage count handling in probe error path Date: Mon, 10 Aug 2026 15:34:47 +0530 Message-ID: <20260810100452.426320-2-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260810100452.426320-1-nagendra.golla@amd.com> References: <20260810100452.426320-1-nagendra.golla@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEB:EE_|LVXPR12MB999196:EE_ X-MS-Office365-Filtering-Correlation-Id: a03330cd-236f-4e6a-28f4-08def6c7b428 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|7416014|23010399003|36860700016|22082099003|18002099003|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: 5ySd0e15CLP2F0shQwAI0E+pbMitKqZ1pJysabMBUHmnfMONdaAmTILVcYGwX5F4+Xo1lZZDbnKTe4Ac6AbDbqc5Y9B2uzL2joZY/PWC7BmolywrTHA4jYlMkJ/V8Nmr/FYpvcMOUNrQofNoL1RfgjOTHz2WUl+GEluPYC9odrFR34zi4NmY7pg262iR7e4iMx9HlAvFn21t15mSarr8M2uDKGbGc2/EU6jgQJCEv8e1+DCFuQUykqA2diNJ4hHS2Vy/mRV/CN5lteySVmRqkruexNVbVuRxUe5px/bqGpx6PVyhwMemiQUXAHwX2oo9KQfcN1ICWaZnXcIeGTVfHFE2ALPjroD8OYg9mcpVl0tzvcAvsoYBPNgg8KiEm9aPSIj3e/KHdHRGlvlA32HYDbsjb7vqrk9/n+/P4guPH6g+b1WgT2qgPtVf3rTspDYqetwppqaWd0DcFGKZPESqVs6VR/0i/AR7VC6VTUcWwSVuYsfLFbycaqNQi54HxA8fT6bynvvcphhiNFae9AUHKUHi1srOMmRmWn2OjWPQnjvTmsmQFCb96+J7v62i8kl0hKlSKzPnWU38F+Y+lArYJDcPBjsZv8p2EJW+yn7TdzIreKci7QPyrxuZOgMaO2U37KtEKWwnXerHd5npxLUN2PmBOxl2JZaD72j0UBxlEvu/NebITjrzEMjjlZR0Yo1wXZ2UQ53dQVETVHbj9RxfDw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(7416014)(23010399003)(36860700016)(22082099003)(18002099003)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: B2e+6lhlh5lBtxUGexigJHD1BwyrBjQnxUT2BPNjGTyOHlP+vs3L4dKNGJJNFPhk2bkhizJk9G14s7sRiM3g4BreC+Fs32VN6wVG2wh+t2dFEHR4KBVn2cpH9z69UcwuC+T0uL6uOdrNddGrQoqHPf3RRnif9pDJ/NO9np48SbTiIWehVA6eKdSlrZxaA63cgUv+BCgGVDkDA5eKGC3vK4SlilxkSMfCXdxn/KwQRdOhQEjVYBvNtiQ1FafMA/Dv0HsYjhoQaYO38X4ktmXT+6hnpmrKmnLLYuBBUYdC1ox0/AU8wUr1G5UNloOulx8QSOZ7CnSHONZsfaOj0kHQvZIv0EfspJSfk5or7OZJfuCzipKmTxpfDtBrW+VVgm81fKujgmL6iLgpjSk0nRe9lpbEvjIqz0EI5pyCALF6CyA5v1NjbJZCPWOQZE0/BIWJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 10:11:11.3543 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a03330cd-236f-4e6a-28f4-08def6c7b428 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LVXPR12MB999196 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260810_031116_132798_64541339 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When pm_runtime_resume_and_get() succeeds during probe, it increments the usage count and enables clocks. If a later step (e.g., channel probe) fails, the error path only called pm_runtime_disable() without a matching pm_runtime_put_sync(), leaking the reference and the clock enable. Add an else branch to drop the usage count acquired by pm_runtime_resume_and_get() when runtime PM is still enabled, letting the PM core suspend/disable clocks on the success-then-later-failure path. Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support") Signed-off-by: Golla Nagendra --- Changes in V3: - New patch: split from V2 2/3 per Frank Li's review to keep the PM usage count fix separate from the per-channel reset changes --- drivers/dma/xilinx/zynqmp_dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index f6a812e49ddc..87986f65d24c 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -1152,6 +1152,8 @@ static int zynqmp_dma_probe(struct platform_device *pdev) err_disable_pm: if (!pm_runtime_enabled(zdev->dev)) zynqmp_dma_runtime_suspend(zdev->dev); + else + pm_runtime_put_sync(zdev->dev); pm_runtime_disable(zdev->dev); return ret; } -- 2.43.7