From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coresight: trbe: Hide enable_sink sysfs file
Date: Tue, 11 Aug 2026 10:04:24 +0100 [thread overview]
Message-ID: <20260811090424.GD15499@e132581.arm.com> (raw)
In-Reply-To: <20260807-james-cs-hide-trbe-enable-v2-1-0b2af223feed@linaro.org>
On Fri, Aug 07, 2026 at 11:13:22AM +0100, James Clark wrote:
> TRBE doesn't support sysfs mode, but the enable_sink file can still be
> successfully written to enable the device, and only attempting to enable
> the source would later fail.
>
> Avoid misleading users by adding a flag that devices can use to hide
> either the enable_sink or enable_source files, and set it for TRBE.
>
> Don't set it for ETE as it's possible that ETE could appear on the
> legacy bus and work with sysfs, and writing to enable_source already
> reports EINVAL if the device doesn't support sysfs mode.
It is a pity that we cannot determine from the ETE registers whether ETE
is connected to the legacy bus or TRBE.
> Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Leo Yan <leo.yan@arm.com>
next prev parent reply other threads:[~2026-08-11 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 10:13 [PATCH v2] coresight: trbe: Hide enable_sink sysfs file James Clark
2026-08-11 9:04 ` Leo Yan [this message]
2026-08-11 9:10 ` James Clark
2026-08-11 9:17 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811090424.GD15499@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox