From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CD05C5AD5A for ; Wed, 12 Aug 2026 10:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XmNobfuMx0pDiDam9efhZOx9BexMksK/K764FtZWuog=; b=BzGoWHIz40dIQSa4QW+170OgMp q0jUmON39b4SelNRLYe013F79ko/ZbA+7l8SasSf9pM5bWqWCYP94qpM0XAi6Wbkrbcz0qR+VOr4p Bwy8oB2aC0xoHuOl+Ho6FXVfgpPcdctgGCccpE/B566p5AA2fhwceJ1uhHZ6fsWN3T+oPJQUwQ0BM PygIcEyrRzZVjY15oC27UduXnd20MiguG73eSK7sLpzndwgIdZm/goUisj68OGzAemJIBARB6a+qq Z98fepVFUdSrr72l1zeDgvp4PszFiWq0ssoQI8Ok43ne/7v1LmY7cd8NeUcXXvLHTmIcyj5f6GAYW uiaGgsnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wu6aj-0000000FyDa-0AK6; Wed, 12 Aug 2026 10:53:49 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wu6ah-0000000FyCr-3mmB; Wed, 12 Aug 2026 10:53:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2EE2960A85; Wed, 12 Aug 2026 10:53:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C36961F00A3A; Wed, 12 Aug 2026 10:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786532026; bh=XmNobfuMx0pDiDam9efhZOx9BexMksK/K764FtZWuog=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=RBtRE+crRVJnULlydWzSt1Tbm1jQGdY0tHzRCOBkLyoEaej1J1pNMg0Y84gPz78+1 jvvglA2Em7xkTR7Z18tKkg17DVoi7POO2PYyQwpWPHaLWgxw+6ddjsjYOxcZzyaZcU JIGz0EJln2WesR/SiQ0f7jDQ0xUV/jdojbEfFxoAddHsSbeUOFNPuwL9v76vZmLi1S ZO5Y4sD6IRG2r7sf86NRSfe7N5eLnHGAl37E7mtqaN6/5c+ejsiB3f1Qkus8MAZ4Pr AJR63jwH2wVHZUI+mbhcufWP25HyaGa1xRvO4bihjj7vETUk45GBVnuS06+wiQKwzF UncEa35Ofw2kA== Date: Wed, 12 Aug 2026 12:53:37 +0200 From: Krzysztof Kozlowski To: Jason Yang Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel , Michael Riesch , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: allow DSI and CSI consumers Message-ID: <20260812-fast-famous-fulmar-3bde7e@quoll> References: <20260810-dcphy-rx-v1-v3-0-a2d25c29adfc@gmail.com> <20260810-dcphy-rx-v1-v3-2-a2d25c29adfc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260810-dcphy-rx-v1-v3-2-a2d25c29adfc@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 10, 2026 at 08:10:10PM +0800, Jason Yang wrote: > The Samsung MIPI D-/C-PHY block on RK3588 drives a MIPI DSI > transmitter and, on the same PHY, can receive from a MIPI CSI camera. > Describing both as independent consumers of one PHY requires the > devicetree to tell them apart. > > Let the existing single cell also take PHY_TYPE_DSI or PHY_TYPE_CSI, > selecting the PHY by the protocol the consumer speaks. PHY_TYPE_DPHY > stays accepted and equivalent to PHY_TYPE_DSI so shipped device trees > remain valid, and PHY_TYPE_CPHY keeps selecting a C-PHY transmitter. > The receiver support added by this series is D-PHY only. > > Signed-off-by: Jason Yang > Assisted-by: Claude:claude-fable-5 > --- > .../devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > index c8ff5ba22a86..1f7c2e2ddfc1 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > @@ -22,9 +22,14 @@ properties: > "#phy-cells": > const: 1 > description: | > - Argument is mode to operate in. Supported modes are: > - - PHY_TYPE_DPHY > - - PHY_TYPE_CPHY > + The block contains a MIPI transmitter and a MIPI receiver, which > + can be referenced independently. The argument selects one of > + them: > + - PHY_TYPE_DSI: the transmitter, for a MIPI DSI host > + - PHY_TYPE_CSI: the receiver, for a MIPI CSI-2 host > + - PHY_TYPE_DPHY: the transmitter in D-PHY mode; equivalent to > + PHY_TYPE_DSI and kept for existing device trees > + - PHY_TYPE_CPHY: the transmitter in C-PHY mode So PHY_TYPE_DSI is the same as PHY_TYPE_DPHY. Why doing this change? Commit msg did not tell me why we need equivalent code. Best regards, Krzysztof