Re: [PATCH v2 3/4] dt-bindings: arm: fsl: add the Colibri VF50 and VF61 on Iris

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Aug 10, 2026 at 04:20:46PM +0200, Mehmet Fide wrote:
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
> 
> The Vybrid Colibri modules are documented on the evaluation board only.
> Add the Iris carrier, as the i.MX Colibri modules already have it.
> 
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Thank you for your patch. There is something to discuss/improve.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 8687631..d58343f 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1711,6 +1711,12 @@ properties:
>            - const: toradex,vf500-colibri_vf50
>            - const: fsl,vf500
>  
> +      - description: Toradex Colibri VF50 Module on Iris Carrier Board
> +        items:
> +          - const: toradex,vf500-colibri_vf50-on-iris

This should be just part of the enum with
toradex,vf500-colibri_vf50-on-eval.

And use hyphens, not underscores for every newly introduced compatible
even if it is inconsistent with old code.


> +          - const: toradex,vf500-colibri_vf50
> +          - const: fsl,vf500
> +
>        - description: VF610 based Boards
>          items:
>            - enum:
> @@ -1725,6 +1731,12 @@ properties:
>            - const: toradex,vf610-colibri_vf61
>            - const: fsl,vf610
>  
> +      - description: Toradex Colibri VF61 Module on Iris Carrier Board
> +        items:
> +          - const: toradex,vf610-colibri_vf61-on-iris

Same here.

Also, Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

Best regards,
Krzysztof