From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF6DC5B572 for ; Thu, 13 Aug 2026 20:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iyH7NkK8+Z1RA8AUwfgEjQBu7itz0alASOpDenLJYUs=; b=TxI8InyYmL2/LLHei+RXQOVhuy 4mfv2JwpDpGAtduYWEGAz/w/VgxZVeTLb4KGm45wEXfXTWposWenl/+nQCfX7Nw6YNvcMMXkcTXe5 A7l8O2TkpzqB4Ii2H2F/j/OIKGUliDybhw/udz6kX5ZYGKKMHhrn5nUzPqM7w5487SzxN5uKo/+RO 0YfaOSFqtNn/1KdRyf1QAUbRvwNsVfGqwAkfbYiPVlkQAglq96ltVRn9ACOrDMP3m891Zjfogq/6m bZh61ddp662likRcxnd155DNyQwuY6myl//gLK/wQq6lCMrwbE84XKjExVHyZCdP9jDPE7Zq6RZ3z nUyBU2kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wucPx-00000001YGZ-1XFZ; Thu, 13 Aug 2026 20:52:49 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wucPB-00000001XFw-3l01; Thu, 13 Aug 2026 20:52:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1786654310; bh=hw0agan+IiLrDpOV8ggRNyXm+gjnSKp8t3sareWfBmE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JuCnjHTGN6A/PAMVKXwslf4ovX8FFmGFvPpg5wbZGeAc+GH6cuFxhQGu+Ktyvzssy aRGUXWVB1HcC3YrzxXnuwLaP/MZaQGIt3FBIhsDSctLD5eRljCgnQxiuehf/CeC03e Dk7LCDBlCjNh9VLqyijXwgGO39TYvyuFysN3iMl6+6Wr4eWq9uw7Um0kLwM8+O3u0w ZOj/bY8vkP5ECQiTTc6Q+3VgRXftWTLKUi7F11LXSbgMfHm0/4civMPdBTezJSI76c oYVp2jUV0VgfP+iXgcerT2pBU7BUYRCeoqA5q0NlVj7qfhi/3q5iLW2ug1fjmLaPgS +1gl1ZIz/mjgA== Received: from jupiter.universe (unknown [100.64.1.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3BB1217E10BC; Thu, 13 Aug 2026 22:51:50 +0200 (CEST) Received: by jupiter.universe (Postfix, from userid 1000) id 9E619480038; Thu, 13 Aug 2026 22:51:49 +0200 (CEST) From: Sebastian Reichel Date: Thu, 13 Aug 2026 22:51:50 +0200 Subject: [PATCH v14 07/38] phy: rockchip: usbdp: Keep clocks running on PHY re-init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260813-rockchip-usbdp-cleanup-v14-7-b5ad9c68fa11@collabora.com> References: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> In-Reply-To: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> To: Vinod Koul , Manivannan Sadhasivam , Neil Armstrong , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , Igor Paunovic , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Sebastian Reichel X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1230; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=hw0agan+IiLrDpOV8ggRNyXm+gjnSKp8t3sareWfBmE=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGp+LmTHcfv6fXnp0h3gay8iUSQ6Y3mf1LW4z WLmvu6eXxalfIkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJqfi5kAAoJENju1/PI O/qaorAP/2JffvyXa/6Zbqp6KDjzptf8OEUqYE4HCIU8qoze0iGQOUUMtj496Bp9Q3bS7dK76jb mulrumf3lorLZntmkWmiBywijvTPsqx1hiDQwvdC2g5RAbgAGTsaUGynLMKPK6S1NoIkf10nsZR X+NFHzeh3WnznRqlCdklkqbzgcWz6U4umefeHmfUyOocPmK8GWyJH0EMzkaQx5sTUkTc2wd7eOv xtzkrgjhfVpipi3VSg6Nqgkh09Qm9zh68ZWQNL8zSVJLDIeTmeUg0xsk1aPd7QBpttvZlDbhoNC hVee6ctha8JoUuftBgUiw8qta6Rxk6VbV8tNA2jINwPkUZffq6pj+qSTsxl3UR5n5mit4nAe29Z NBXwZSq8cDAZVsk2mSrwtDrPdnY+LgxFMFVsbVvu7KwX+aEY4QhLS+yWZ0//OyHTxflpWjLjoVI Hr/sCCYKKeMai0tp6tHuCJ7KRZyJ3/6qxH+9eT32sEgoY1LAkhPPpwnSCC+NwVcCNdur2IJ6hK6 o2jZFdpCVlJX8gk+IstjNLFyVITEujaoC1qvUDUT6QZLYo1WRaTIyqMT30YnKYa2lqyE4TUkABd 8s+bew6WA6ISVilkY/JKUYXS60mE6ryHlWqdrldUMZ1xz537preAJxNzVutx5xboD2zf7tg6gSJ iMyEAGriXGtO7nRIuapow/Q== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260813_135203_075150_0EFB55A6 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When a mode change is required rk_udphy_power_on() disables the clocks and then calls rk_udphy_setup(), which then enables all the clocks again before continuing with rk_udphy_init(). Considering that rk_udphy_init() does assert the reset lines, re-enabling the clocks is just delaying things. Avoid it by directly calling rk_udphy_init(). Reviewed-by: Neil Armstrong Tested-by: Igor Paunovic # Orange Pi 5 Plus Signed-off-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-usbdp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c index 6cb9f6b4dbf6..e3f5a26c876a 100644 --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c @@ -987,8 +987,7 @@ static int rk_udphy_power_on(struct rk_udphy *udphy, u8 mode) if (udphy->mode == UDPHY_MODE_DP) rk_udphy_u3_port_disable(udphy, true); - rk_udphy_disable(udphy); - ret = rk_udphy_setup(udphy); + ret = rk_udphy_init(udphy); if (ret) return ret; udphy->mode_change = false; -- 2.53.0