From: Bjorn Helgaas <helgaas@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] PCI: mediatek-gen3: Add 2-lanes mode support for Airoha AN7581
Date: Thu, 13 Aug 2026 12:08:20 -0500 [thread overview]
Message-ID: <20260813170820.GA1143871@bhelgaas> (raw)
In-Reply-To: <20260806165334.7328-3-ansuelsmth@gmail.com>
On Thu, Aug 06, 2026 at 06:53:32PM +0200, Christian Marangi wrote:
> The Airoha AN7581 SoC supports configuring the first PCIe0 lane to 2-lanes
> mode (x2 link) by bonding it with the second PCIe lane (PCIe1). This is
> done by configuring the PCIe MUX in the SCU register.
>
> To correctly configure PCIe0 in x2 link, define in DT the following
> additional properties:
>
> - additional reg, 'sec-pcie-mac' for the secondary PCIe.
> - PERSTOUT reset for both main and secondary PCIE0, called 'perstout' and
> 'sec-perstout'
> - 'airoha,scu' property to correctly configure the SCU register for the
> PCIe MUX
> - 'num-lanes' set to '2' to enable PCIe0 in x2 link
>
> In such configuration the EQ preset are configured to the same values.
>
> To permit correct configuration of the PCIe link, additional logic is added
> to assert and deassert the PERSTOUT resets. Support of these additional
> reset was introduced in Airoha clk driver with commit
> 6712f48eb3a1 ("clk: en7523: add support for dedicated PCIe PERSTOUT reset")
> and on backporting of this commit also the clk driver change will be
> needed.
I don't see 6712f48eb3a1 in upstream or linux-next. Is this SHA1
going to valid if we merge this for v7.3?
next prev parent reply other threads:[~2026-08-13 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 16:53 [PATCH v5 0/2] PCI: mediatek-gen3: Add 2-lanes mode support + clock Christian Marangi
2026-08-06 16:53 ` [PATCH v5 1/2] dt-bindings: PCI: mediatek-gen3: Split Airoha schema and document 2-lanes Christian Marangi
2026-08-06 16:53 ` [PATCH v5 2/2] PCI: mediatek-gen3: Add 2-lanes mode support for Airoha AN7581 Christian Marangi
2026-08-13 17:08 ` Bjorn Helgaas [this message]
2026-08-13 19:30 ` Christian Marangi
2026-08-07 3:24 ` [PATCH v5 0/2] PCI: mediatek-gen3: Add 2-lanes mode support + clock Chen-Yu Tsai
2026-08-07 15:20 ` Bjorn Helgaas
2026-08-09 12:12 ` Christian Marangi (Ansuel)
2026-08-09 14:08 ` Benjamin Larsson
2026-08-09 14:14 ` Christian Marangi (Ansuel)
2026-08-09 15:27 ` Benjamin Larsson
2026-08-10 10:33 ` Chen-Yu Tsai
2026-08-10 10:55 ` Christian Marangi (Ansuel)
2026-08-11 19:43 ` Benjamin Larsson
2026-08-12 7:59 ` Chen-Yu Tsai
2026-08-13 5:21 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813170820.GA1143871@bhelgaas \
--to=helgaas@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox