From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 027E6C5CFC1 for ; Sat, 15 Aug 2026 20:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MVlQn7mhKg7177m1+4VT77S5ExQxaD1xM5hHvrwadVQ=; b=vlJiSHgThU60Ft/Z9WBBIEWpKX LUNFOBgHMHQZymXrMBGxPyiHqBOWvjFfEvQ3AdcMpUzbkNQhQ+OOlH/4784PrJS9FoRIxUIw8NI80 seK2X1Yz7IIBJsUSgG1w0aviXYF3Kh51do8CpXgaUvx39SbzTXlgpL01HnfShsitS5t1AjQSt/6Hz pRtd7CvIk/pEi58a9UscOk7SV81wyEZXZlyhnlIP95QWN5Gat3WOBBTf9wySogpCbp/Tp43JEQiPS lefFmWVbssQE+G0xvM6p6lgHVpLZkn+WTZ6Pl0u95L4/XEukztbwH54HgK5k8TAJbtjhhmLWbDQbK 5pANY39g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvKYO-000000049xd-2qwm; Sat, 15 Aug 2026 20:00:28 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvKYN-000000049xU-12Zb for linux-arm-kernel@lists.infradead.org; Sat, 15 Aug 2026 20:00:27 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 63A3560052; Sat, 15 Aug 2026 20:00:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE7F91F000E9; Sat, 15 Aug 2026 20:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786824026; bh=MVlQn7mhKg7177m1+4VT77S5ExQxaD1xM5hHvrwadVQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=L4l3jD1ECqnQTF/yhNzc/eJR7jrjn3+mrO+W/kgiZYosyXq1jmtd1nti/GAXpTMME Mw5+344duDDGFDHv3LNYhItD7JfNCdQy0Bcl8jeUQIDBEUFCZiGtlHvumeI0Ej3NrJ mqHhI8CXXc82NuyM89uSnp/JhYPNVjfL7ntN7ZIDIm7CR1NCgQUJVmLEhPANXTc199 CNBTO9Z8JM0ajyIi8i5UEzHMEZ11kuAK7SD0GlIiWn8dJsg19Dq49SgNPDPB+1V5Mo tWzPYduryLPqihIPzK7+osBRbb1PTN/boGf6XCRZj7mpDn3lqwozhwUPq5Jl7eVtS3 4sgt1LvxJSnbg== Date: Sat, 15 Aug 2026 21:00:18 +0100 From: Jonathan Cameron To: Varshini Rajendran Cc: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 04/17] iio: adc: at91-sama5d2_adc: rework temp calibration layout handling Message-ID: <20260815210018.460c0eca@jic23-huawei> In-Reply-To: <20260806074024.531259-5-varshini.rajendran@microchip.com> References: <20260806074024.531259-1-varshini.rajendran@microchip.com> <20260806074024.531259-5-varshini.rajendran@microchip.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 6 Aug 2026 13:10:11 +0530 Varshini Rajendran wrote: > Extend support to handle different temperature calibration layouts. > > Add a temperature calibration data layout structure to describe indexes > of the factors P1, P4, P6, tag, minimum length of the packet and the > scaling factors for P1 (p1_scale) which are SoC-specific instead of the > older non scalable id structure. This helps handle the differences in the > same function flow and prepare the calibration data to be applied. > > Reviewed-by: Eugen Hristev > Signed-off-by: Varshini Rajendran https://sashiko.dev/#/patchset/20260806074024.531259-1-varshini.rajendran%40microchip.com For the unused define comment. I 'might' tweak this is apply or go meh i can't be bothered and apply it away :) Again - if you respin for another reason please tidy this up. The other comment from Sashiko doesn't seem particularly useful to me even if it is maybe valid. > --- > drivers/iio/adc/at91-sama5d2_adc.c | 66 ++++++++++++++++++++++-------- > 1 file changed, 48 insertions(+), 18 deletions(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 09390f082fc4..82db8f2f4db0 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -444,6 +445,27 @@ static const struct at91_adc_reg_layout sama7g5_layout = { > #define at91_adc_writel(st, reg, val) \ > writel_relaxed(val, (st)->base + (st)->soc_info.platform->layout->reg) > > +/* Temperature calibration tag "ACST" in ASCII */ > +#define AT91_TEMP_CALIB_TAG_ACST 0x41435354 Eagle eyed sashiko spotted this isn't used in this patch. Should have been introduced with first use in patch 5 I think.