Re: [PATCH 4/5] media: nxp: imx8-isi: Add i.MX952 ISI support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

On Wed, Aug 26, 2026 at 11:09:04AM -0500, Frank Li wrote:
> On Wed, Aug 26, 2026 at 12:55:45PM +0800, Guoniu Zhou wrote:
> > The i.MX952 ISI is reused from the i.MX95 ISI with a minor silicon
> > revision. It can process up to 8 image sources simultaneously and
> > obtain image data from up to 4 pixel link sources.
> >
> > Signed-off-by: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
> > ---
> >  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 14 ++++++++++++++
> >  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h |  1 +
> >  drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h |  2 +-
> >  3 files changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > index c1c16dbc1539..5b19b581b38e 100644
> > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > @@ -392,6 +392,19 @@ static const struct mxc_isi_plat_data mxc_imx95_data = {
> >  	.has_36bit_dma		= true,
> >  };
> >
> > +static const struct mxc_isi_plat_data mxc_imx952_data = {
> > +	.model			= MXC_ISI_IMX952,
> > +	.num_ports		= 4,
> > +	.num_channels		= 8,
> > +	.num_vc			= 8,
> > +	.reg_offset		= 0x10000,
> > +	.ier_reg		= &mxc_imx8_isi_ier_v2,
> > +	.set_thd		= &mxc_imx8_isi_thd_v1,
> > +	.format_mask		= GENMASK(30, 24),
> > +	.buf_active_reverse	= true,
> > +	.has_36bit_dma		= true,
> > +};
> > +
> >  /* -----------------------------------------------------------------------------
> >   * Power management
> >   */
> > @@ -582,6 +595,7 @@ static const struct of_device_id mxc_isi_of_match[] = {
> >  	{ .compatible = "fsl,imx91-isi", .data = &mxc_imx91_data },
> >  	{ .compatible = "fsl,imx93-isi", .data = &mxc_imx93_data },
> >  	{ .compatible = "fsl,imx95-isi", .data = &mxc_imx95_data },
> > +	{ .compatible = "fsl,imx952-isi", .data = &mxc_imx952_data },
> 
> It is the almost same as imx95 except model, I am not sure if model is
> used in code.
> 
> why not fallback to fsl,imx95-isi.
> 
> compatible = "fsl,imx952-isi", "fsl,imx952-isi";

Typo here, but I agree - fallback to imx95-isi would be nice.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]