From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2C8DC61DBD for ; Fri, 28 Aug 2026 16:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3uZJ8IQ3rvAOLqsuwriJVKPiTt7W+7qGrB0uMuNGIIA=; b=p46mxOYNS95RTjLo3/1qBfLmgs xoTF1ITHHHoRQBcXg1JlLXJ5XDBjHWUsU6ewaJYfKDgc0V4i3ICNxcW5PgRz6w5mBWIM2Sb+EkdOk HGOcCnjgB/fTN9Es9+sysHw6j0nCabru27FMwp1ulUQwEHIx1J2bmbM/5pcVtGSzkFZTttKMW4LqZ q1lD3jM3AlcXgQq+mznbWUMiLMnLCH9PHUdv8eZtfy9klJSmnnCoSQvBW1phSoOolDcEslqUqEKic RTP1yKcf2DNrXb9cDB96I5LKZ4COG2oFXQt3C9UnaVoACd67TUBRmv2gZiGRPtuMJsSb4ExrMhkGb RWLVW/hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzzkP-00000006E2o-0D6q; Fri, 28 Aug 2026 16:48:09 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzzkO-00000006E2Y-0Sqa; Fri, 28 Aug 2026 16:48:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2311A60052; Fri, 28 Aug 2026 16:48:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03B351F000E9; Fri, 28 Aug 2026 16:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787935686; bh=3uZJ8IQ3rvAOLqsuwriJVKPiTt7W+7qGrB0uMuNGIIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Jr4xjUxHKAt1Q7DFDYX2Upl28VPMnkSAzFFonEzlkqnkbv0NPiiPJ2IOsnd/72/XD 47B9qGO4dBvV3NAmBTkc5P9Q3KF7rRewXQZO7sDxF76axLKw/vYn4GaAQPb8+/NdpX tpkafavH+lTmRdl6xGC9+atGOWEkwytEN8eKuh27gKfW0PIUQKIHZg9bI3EvC+eX14 LpBDqvJCWP3NJDkbBxRlOOws+ekUArnw0iKxUoIV1bkdxMQo6RNyMJhw/z+wsRhtCi G1gpytYmfDAk+dsLtw/Dwz+EmAxGa+CFkYqp53SEBqT86gEm2YaXoIAEK2edIfvaiq 3kTjKoOOyJlVg== Date: Fri, 28 Aug 2026 17:47:57 +0100 From: Conor Dooley To: Michal Wilczynski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Icenowy Zheng , Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall Subject: Re: [PATCH v2 02/15] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller Message-ID: <20260828-stylus-bonfire-b71cbfe8b983@spud> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-2-331680c8b9d1@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hmXiyWp5HkfjJgGf" Content-Disposition: inline In-Reply-To: <20260828-jh7110-clean-send-v2-2-331680c8b9d1@samsung.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --hmXiyWp5HkfjJgGf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 28, 2026 at 03:47:26PM +0200, Michal Wilczynski wrote: > Add the dt-binding for the StarFive JH7110 Innosilicon HDMI controller > (DRM bridge). >=20 > This device is the second child of the starfive,jh7110-hdmi-subsystem nod= e. > It consumes register access clocks (sys, mclk, bclk) from the voutcrg and > both the pixel clock (pclk) and the PHY from its hdmi_phy sibling. >=20 > Signed-off-by: Michal Wilczynski > --- > .../starfive,jh7110-inno-hdmi-controller.yaml | 109 +++++++++++++++= ++++++ > 1 file changed, 109 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/display/bridge/starfive,jh= 7110-inno-hdmi-controller.yaml b/Documentation/devicetree/bindings/display/= bridge/starfive,jh7110-inno-hdmi-controller.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..0e584e7b756e24e2f99a62daa= b3117bbf4b472b6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/starfive,jh7110-in= no-hdmi-controller.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/starfive,jh7110-inno-h= dmi-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 Innosilicon HDMI Controller > + > +maintainers: > + - Michal Wilczynski > + > +description: > + The controller portion of the StarFive JH7110 INNO HDMI IP. > + > +properties: > + compatible: > + const: starfive,jh7110-inno-hdmi-controller > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: System clock for register access > + - description: Module clock > + - description: Bus clock > + - description: Pixel clock from PHY > + > + clock-names: > + items: > + - const: sys > + - const: mclk > + - const: bclk > + - const: pclk "module" "bus" "pixel" would be more informative than spending most of your characters regurgitating what these are by definition? > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: hdmi_tx > + > + phys: > + maxItems: 1 > + > + phy-names: > + const: hdmi-phy With the trend of ?pointless? -names properties, I'm surprised you don't have interrupt-names? I'd ditch 'em all where there's only a single clock. The _ rather than - in the reset name triggers my OCD. pw-bot: changes-requested > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + A graph node with one input port and one output port. > + > +required: > + - compatible > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - phys > + - phy-names > + - ports > + > +additionalProperties: false > + > +examples: > + # Shown as a child of the HDMI subsystem node; see > + # Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem= =2Eyaml > + # for the full node. > + - | > + #include > + #include > + > + controller { "controller" seems over generic for a node, but I guess if the parent is "hdmi-subsystem" or something it makes sense in that context. Cheers, Conor. > + compatible =3D "starfive,jh7110-inno-hdmi-controller"; > + clocks =3D <&voutcrg JH7110_VOUTCLK_HDMI_TX_SYS>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_MCLK>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_BCLK>, > + <&hdmi_phy>; > + clock-names =3D "sys", "mclk", "bclk", "pclk"; > + interrupts =3D <99>; > + phys =3D <&hdmi_phy>; > + phy-names =3D "hdmi-phy"; > + resets =3D <&voutcrg JH7110_VOUTRST_HDMI_TX_HDMI>; > + reset-names =3D "hdmi_tx"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + > + endpoint { > + remote-endpoint =3D <&dpu_out_dpi0>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + > + endpoint { > + remote-endpoint =3D <&hdmi_con_in>; > + }; > + }; > + }; > + }; > + > +... >=20 > --=20 > 2.34.1 >=20 --hmXiyWp5HkfjJgGf Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCapG7vAAKCRB4tDGHoIJi 0pUPAP44G7D1YksuTLzwXOQE0xjkY41H5I6ctxD3+HMYzXvYMwD/dGnps9J8VkOV +p7sgoW/Ih4VAyXMlP+NpyZEU8ULFgY= =mMUh -----END PGP SIGNATURE----- --hmXiyWp5HkfjJgGf--