From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5258C61DC4 for ; Fri, 28 Aug 2026 00:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8n2XnZEXJ+Zx3fSe59Mfpk8b2gJC/sov33G6M/+4tfU=; b=B/kxVM0GQN5As+PwNkbIunjZCP MkiCTVzySACOnAJ52ooZ7QhdKPvw8/lv99l/EjCZ5IEiwF7wmlYD1aY5SN7/Uz57xbV5/uxD71TQT Z4XNZ24n2RPzMwqkvygR6W1cp21WPyfoO7shfrRz/b27Ogf+9Bm+QfoRNT2sECfUQaC6c4R8FURUr gM4lh6sW+eqa4LEjMwNyCLZcXIpnuJ5Gw+mNrcdKtyMJDvXZs0NCdDyLyEGXz56alsUuCd3mOUs2B OPF0MVDSoZnoSHVlyjVAVCGc4To1I193GeXt1yvMRESPzlArr1YJqrskglkj+B/TIxmSwbi/awwMa VyB7JJ9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzk3i-00000004w2i-0EPb; Fri, 28 Aug 2026 00:03:02 +0000 Received: from mail-westus3azon11012052.outbound.protection.outlook.com ([40.107.209.52] helo=PH8PR06CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzk3f-00000004w1j-0ZpD for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2026 00:03:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qoyd3lMONkWoe7FqrG3bKm3cy8qDNqur0V5ao98F0jjTmhoVdNgtsrrkYM91W2K3oTnLrn1Z+16YTxXai+Ivq2j1of7CEZysqVw8+uA8Feb+px60ULh67h54URukgZQOZouDmTr447pQ9AxQHzb2xEZjOt35EuRfEGvUSJxqqEKZJUt60E5eulLdAlcRFNyaTUCDdwF1vhYM3nVYA2G3w6FwfLlncw4xxe1d9+A8KZx0hh6U9PUU52cZOQammebShTpocB/q+2USsEGUM3gtjlcjMT/nE8hk7Q+mxTmbNPU+6ZalXCPlBMGOTIqWvul4aawuNWYg0Wa46PDXfEQh9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8n2XnZEXJ+Zx3fSe59Mfpk8b2gJC/sov33G6M/+4tfU=; b=dUQJYvu4TuqPSOnIjgJRZEbX6f+ydC3WoZMgobnUNm9wNot2gnJy6t0rmaNq+mFqA8SU6fpVBm12agL63NbSdrTATeRlLeg9MOa+iibByIxpt8O3oljDCvGLVGleJDUa2Tn9pp9XtAZ3+qk4KYDEdbRwwkkbuBbJr4fDIWznanx9a3VS5UAoE1QeSqL0rSI0Id3RQLz8U5wUGHeIOAEsNWfcFPYU0Kd25Xk59X2jJQVJuQOKj23MIV6EkXIBPugtLaPqUR+LZc2tGqUFLu6TgrJpNYyQkMTPvTKrAo/sTtkUlynDNMXdf8dE6tC+hKLB222dyV+UI/m+UzzuDX/v4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8n2XnZEXJ+Zx3fSe59Mfpk8b2gJC/sov33G6M/+4tfU=; b=qChbIXmN/0KtJ0256KfmPQQzEeZiETcoMsf1LVuzdESFEu6pCz8860rxkBSx0R6aD7nwHkuO3bT8kppURFrKjveBx1TyyK2QMRZMW9oOdBueSedpNn6AAV5c9isKdIfbDXuZxS1h4RLCiMKWL7ER0vCyPxvYwpMFD3JWN9R9kdUI25CUuEBeK41J/Y3Pft/tiEmGnHkYeC/IQrtvWKO7YyOpD5hoXDim94MYrJ+4PmHwb4WlAmLuhhWExuQpsT6Ha1Idp+ekwEz+DSHhuNGaVwzQMNTutxF5dzs5ccxC2tHt+V25A9ugovPwCuL8ut+WUrwmciFE6sUESJ4LhyeorA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by CY5PR12MB6453.namprd12.prod.outlook.com (2603:10b6:930:37::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.10; Fri, 28 Aug 2026 00:02:53 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%4]) with mapi id 15.21.0360.008; Fri, 28 Aug 2026 00:02:53 +0000 Date: Thu, 27 Aug 2026 21:02:51 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: Will Deacon , Robin Murphy , Joerg Roedel , Bjorn Helgaas , "Rafael J . Wysocki" , Len Brown , Pranjal Shrivastava , Mostafa Saleh , Lu Baolu , Kevin Tian , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, vsethi@nvidia.com, Shuai Xue Subject: Re: [PATCH v5 03/18] PCI: Propagate FLR return values to callers Message-ID: <20260828000251.GB3922654@nvidia.com> References: <178786269177.3808739.6763094519382046767.b4-review@b4> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: YT4PR01CA0104.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d7::9) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|CY5PR12MB6453:EE_ X-MS-Office365-Filtering-Correlation-Id: 711d64dd-bfce-4548-b6c8-08df0497b4b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|23010399003|6133799003|4143699003|22082099003|56012099006|10067099003|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: iOsoZq9KFUmS7nveY2nQJvR1mqACYVnK7v5bXINXu+j2uEqevGDhAm4+1x9lP7Cjj7jduvenNivbRXt1BKbFS2MWcpfSDwkv9M6mkYbLInwRk6wergSaeVsJO7C4mxOq6jyilcMHwzxp7yVobL9y2QRLBV/4audblUuYEZLyjbX7ugQc/M9uYDfiB42TgFqwoOq8oG3FvE3LiV99yqpTCwO2dFlIG9xf1m+F/TiGULr6AfVIPAoJHkKoPQscq4fPWSiiEeiC5KB4YlBoWmk2Bd3OVPK4AF3dB6wzNCcEe/DDN6ZWOyJgagP8DsMHWOF/A6UXJ+ZILI/D8gM24cQTBzVIL02Dj8G1yrF06jCFEgdboDS7owHx/8zzUvhRosoqcNLOfW1hl8YZzW4yMRszeTMRwZdKgeaLXJi9ewKkYTzD0/vwWCCacKMUxkIfamSDda5S56OhgJ/55lpVkcB7QhPO4fxvNlW/9VBDiWjP8QDHWwPLjbjpgC52LBB1HRggvMV8Ickj+2nPFhcgDmGmAfbmtmCalZ2j7aqgJBgrfxCBlgrz6OPEwZg8zZoxIJL0G0NZJ3wF6u/WwbBNZLgq2RKLLsao3fhDxGN4fMIuPdk374g/dNaGj9/Cig+BiQ5wXWPfrw4N4VLOcH7l4Q/kYvQF1qIkNODTWgnzWbY+B1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(23010399003)(6133799003)(4143699003)(22082099003)(56012099006)(10067099003)(11063799006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oWSYvEhsR8dxcPPkOSN9lPJfBY4S6bMw4TSUroeMdZVw86RIItJs5wyp5m/j?= =?us-ascii?Q?mAOd5lmsiCE+JhQuyhVgS6R477NBAJ70GPkXCuzMuHNVOQx+NGqo2BuvZwrn?= =?us-ascii?Q?y6Bw1h8TrH8OSC9P2GrzhbN8fSqjtJ0zUCrwHPvO/H6n49L46fBSfu/a9Qj2?= =?us-ascii?Q?b6JRTLbhfVLsTug6PlpTtZC7RtARq3x6FwVo6A/yU8pp881tErgCNr8uexJX?= =?us-ascii?Q?z5KLVDm37ThMQ2pmqh/pzdT5DP+/91V8YXhx2k3uOouKlv6tSm8F3W9xRwPB?= =?us-ascii?Q?xOM1+jJpXpEaBKVuHyNVgC2tIaOJrTAEnI5T3NxUO1bVis0BhTlWwqZoYs8A?= =?us-ascii?Q?j5yAl+mYYOmsEFlN1k23lmxOPoCC6eEa8ecgIrZERKyNe/qXs403XAeIRZ4u?= =?us-ascii?Q?TbshAjo3s0x8DqWiX7/eVMSfB7yJcZSH9hZo/I7Nd12dzviks4IlR8N/p03i?= =?us-ascii?Q?JZRQFnD9eylnNiq5RwwglFzb2iL5KEgtS4Q9DC+JB07HtXgnSQoOicf+vS78?= =?us-ascii?Q?nwGHPDGzCuiyb0rLESudjKayjBO92ksqdAAZpEN46Qp53e2AQr6y+JJJumaT?= =?us-ascii?Q?gqLcDP06SMQQnzw2guZ26OU90YrxYXa06KYtROES0v2rDA0OafFv8iUQNq/c?= =?us-ascii?Q?+DZ3G6h4XKSvJKMhkyWL2FG46ReseoILYT693VeNIJNDuk063jyttrQw2q5V?= =?us-ascii?Q?WeJ4m1X6s0CDfamYGf0cscTMelZGdah59PCMl5yUEFrXnQ+8nuSOr2+6xL+w?= =?us-ascii?Q?LB0gqfub04kp+YO2uttt0Udz3B+2XkyOCVaqNVBdxODZUP98I2T4QFtQIxDM?= =?us-ascii?Q?yVDOeyQAw9ImQeIphJBcCmM/ZDbWjfqPOENtyGkH1AS+vr7o1/WNFpAMkMEe?= =?us-ascii?Q?d1ru+LBEKeXXGJMnNtmecqJ5D5kS5TTEnIOqbnqAOJdJK8hW8i6jk8My3Vs9?= =?us-ascii?Q?w95eooNuNFZm1izM8iS6MmIfu5MwP++jn805D9VrGWf2AKax2RxYozkXEPNG?= =?us-ascii?Q?1v+NaGDVxIKDShmfdM4VHrZX63zsJB+8/rVoJOcCmZb2gACdgIB5H2NEpqzP?= =?us-ascii?Q?eiU329PwF31mDc+LUkswHmCwrvaor4emwEHTRsvhiYNycfL5u02eCCpM3vky?= =?us-ascii?Q?YR3c7eS61hMb00vLu1oUqmXGMvNpHXAx36/L0v9bLVYKrZrL+9rYrfMwiw8d?= =?us-ascii?Q?vJSy4rZ+yjrwjLoNVeJ4e426ykGTSMLFc2iNy0hyo9ZPAqdZe98aF0iWGUPd?= =?us-ascii?Q?0tDL/sLWS3usgHb8gzYcZJkiPVyrIRsxuM3W29BthfTRsHuIaBQgcJRgODwz?= =?us-ascii?Q?TwFumiK4xOxNqpLfx6GPY6uwX2tC9r7fOQ41wTErhfUBBpbsOKIQWi/2+Ypy?= =?us-ascii?Q?wlLJeroLxeJVhXrlB4VIyfH1mn1Q2EpV28n9FZ2YNPLiIOp5Mh542hWsbsAG?= =?us-ascii?Q?6rBtyHae9srSParzVsuty+oEsY+tGr9yxKmOLSemE+Yrt3BbtgBsLubWTXPY?= =?us-ascii?Q?M0uO2F8YsVDObIBrupmHOT6Ieeaybam4DnHhNO33zaxgcGIYxOtNtv3IUoKs?= =?us-ascii?Q?GxW1RSafHv8t6dZUWrQfxkVya3XNmkSeslgTdrrZV7VNTh0LxxtUZLpwXaIC?= =?us-ascii?Q?bjw0I6Nr5SnJxErMt2ImGNWJOY26jsaPGrQI2UyO3VWvQ6I0zUyDv1frZEPf?= =?us-ascii?Q?1Hbb8/ko12mv8FrWeO/VV/ypWWnzO9SkSMcSM1ilz7S6kqzX?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 711d64dd-bfce-4548-b6c8-08df0497b4b8 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 00:02:53.0373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9m205DedBxOyFZy7r+6xYUJHXANT5U4EbWtGfxxUaIfbRXTLw2b8XMnHUAPi7st0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6453 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260827_170259_181850_0F736128 X-CRM114-Status: GOOD ( 27.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 27, 2026 at 02:18:08PM -0700, Nicolin Chen wrote: > On Thu, Aug 27, 2026 at 05:31:31PM -0300, Jason Gunthorpe wrote: > > > [ ... 24 lines skipped ... ] > > > Since these quirks have always returned success, escalating > > > would be a new and harmful behavior: the next method is typically the plain > > > "flr" method, which would re-run the same FLR without the extra steps the > > > quirk wraps around its pcie_flr() call. Add quirk_flr_err() converting that > > > -ENOTTY to -ETIMEDOUT, so the cascade still stops at the quirk as before. > > > The early "not applicable" -ENOTTY returns are left intact, and they still > > > ask the caller to try the next method. > > > > This seems like a very suspect AI conclusion to me. > > > > I think I'd drop this patch > > > > > Convert it at the quirk level rather than in pcie_flr() or pci_dev_wait(), > > > because those also serve the native "flr"/"af_flr"/"pm" methods, where the > > > -ENOTTY on timeout is deliberate per commit 91295d79d658 ("PCI: Handle FLR > > > failure and allow other reset types"): a timed-out native FLR escalates to > > > a stronger reset (e.g. bus reset), which skips no workaround there and may > > > recover the device. Converting in the core would also change the value seen > > > by every direct pcie_flr() caller. > > > > > > This is not a bug fix, since these functions have always returned success > > > and the propagated values are only consumed by incoming work. > > > > In what way? The quirks flows always succeed and it can keep always > > succeeding. If anyone finds this problematic they can properly > > propogate the error. > > > > Squashing the error just for quirks makes little sense. > > PATCH-5 forwards the return values to pci_dev_reset_iommu_done(), > so IOMMU can keep a device blocked on a nonzero result. Dropping > this patch would leave the three VF quirks here always reporting > success, reopening the stale-ATC issue this series is fixing for > them. Sure its fine, I bet this HW doesn't even have ATC and if it does someone can properly fix the quirk and test it that way if they ever hit a problem. It doesn't make sense to touch this code and make it worse, the right answer is to propagate the error code directly. Jason