From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A2BC61DB9 for ; Fri, 28 Aug 2026 09:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H8NabRqeVDl6V/0Mf+sYcOuuE1n9qJZPVQBsEE5OZg0=; b=0qMswY9fo0jPRLpYjJmtmeiLhW jm+EIcqPU8UhZVCkRatZyb64t+ppgU2U2k7D0CgdOw/400TtqgkYjzDsEu7SRM1rkMO2hEKJImH/4 aX2kSZh+ffuMtrCYd1N8l1smB8X/Hgo6Svay/yk+fHMlzKe6vPrg7cgVfZF56w7z41AtwTyQl8KS7 9+vvNLrPVeT24hH5/tkwaNcZE95uo5Z7bl+t0b6gzihBnadu69LeGgl071E4P1cIAg/smwPJvYU8w VzUsVZ9Bp+zbNtInBuqT6mUbNVKNYhJNArrpOXfSO/oAhhh4N2RojUW2RMCZijsVXUl8m5v+alC0F dO1hdF1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzshq-00000005R5T-3M7X; Fri, 28 Aug 2026 09:17:02 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzshM-00000005Qht-2971 for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2026 09:16:41 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-853f8c34ba4so1159360b3a.0 for ; Fri, 28 Aug 2026 02:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787908592; x=1788513392; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H8NabRqeVDl6V/0Mf+sYcOuuE1n9qJZPVQBsEE5OZg0=; b=SxlkRyj3LRDwQzvx03sUQ0UesmeOpPAJOlmQ0dfwoaw60k8VxZwU72jb6n8/2WF4+z hRgvlzxDsgyNgkFnhwrHXod0z0oMrl46Vkkh3IBo1MZQ3bs3zMNIZSMx9ppQ+FHQQq7H /wjO2IGntYVYERlHLXFbGo35l18qJ1v7MwoP9Zig2llHioPXKibxOcXXzQaCzb4+tht2 aJ7OYaQKXUE9ebmyuLgEv5J6kkmA9kkxzqnrxSHz0d9IBQ5/I96p5rh4JdO4Yz8QZ0K1 1lLu6vSZOzr9Uw2o+5ayqWa+OZzZ+Yj05K0+n0ynYn3gUDbTd+1yRjMkzSITkKfN/rmF 9EIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787908592; x=1788513392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H8NabRqeVDl6V/0Mf+sYcOuuE1n9qJZPVQBsEE5OZg0=; b=Y9inXE7fKsvAYS2N2+edZOfKVjZfk2sFNKfE/ndJRoTMGjVKA5jLny9lM+3uHYBmTY Zf9AiPTcO35CUB0fpD61ZK019/vS7Ab+CdIQg/nClxYlhu+uYvEBkbVyKFsd6+Q4Si09 eqZrClid5dw8YHcJAJ35XFQLITjYF08GbkhqwaJAZ5I9OVMW5TZff48Pos/4uedIWqEY RAZDjjF6MgTkYf31lixP4MLzH6DwmKA9KHV5Nywg8shG93VJCCLCZlJnsSIf7qfPdkXv CYyHWPpIZlHtFPT0F41sf6BCqLnFnqdSwAeXZtJY195AdU339V4SEQgMhhf6H41MhLrv oWRg== X-Forwarded-Encrypted: i=1; AHgh+RoRuoLu1qwV060ZAWLszFsgG1bZxA29ypDZgRY4ovvFbKkE6GIuH+5tg3qmsE+rc9CdaXeNzzJ7/5AqKx3RWcqE@lists.infradead.org X-Gm-Message-State: AFuF++m1Z8nBhNXkXVgYTb+D536dZfjdWVIG86ytTlRs/4ajDR9Y/kxw nZAHvT1qOylqwpC0Q8ibEUuuIkgSZkOQzw18c3OtP1XhgJzN5wklhd5H X-Gm-Gg: AR+sD12FP9mIXWpR/EJKfOZlOGKFK7YmaZ157U+QniSy4rVEgUEbR6FzaUnRMq9w3Op ooTbjLcTDDsDbp2s3qt0aN7IJxBmSNrlcF/W3i3qlGFkrMfI4bR5PLfTTFRooXI6oLQueaWxOkA 3XjCkkwU+DutyRljdcmLAP2myLqqSZTpD0lIPt7JP6pJZX7yyi+RuFJS/MWLh0QalcModiTqOIb UlquRDEujx9kpW8kwSSmW7f5Md1OpzXHRWwOJBAAefsenEjw0XHseY5VBOMS23awx6OGAkqHqQz K1A4yfp4P+q0IRbThrEpiDJciqc71EgXagntZOb3ozWer5fmcEUA7qB6P5FrsUZXiRoZWHTAsxq wS6LSSvqcOdsWTTOFJmbOPCxLTQdwy2TXtNW+Wtocj4CDouJrouDEa7y2RvNcSnl87g3+WsKk18 uREd1zudDcuHcLUq9kRfDhbO2FPMrXRQ0tGXvPi8mJyO9YcaXuHkYwuIrAO7O/QCzR3axPtrSSc IWBgMbgX4OX6KoitYcZnyDYagCt0ptjBjxEmeyYABkxXEW5bWXcesUjGK8Ci4dTFmOFcSyY8i3O /iqJhub47YOqXd4= X-Received: by 2002:a05:6a00:8019:b0:851:d12e:389b with SMTP id d2e1a72fcca58-8562a8d4291mr12413048b3a.14.1787908591962; Fri, 28 Aug 2026 02:16:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8569fe78fc3sm381248b3a.24.2026.08.28.02.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 02:16:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 8/8] ASoC: mediatek: mt8186: Drop redundant probe error messages Date: Fri, 28 Aug 2026 16:15:32 +0700 Message-ID: <20260828091532.600047-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828091532.600047-1-phucduc.bui@gmail.com> References: <20260828091532.600047-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260828_021632_562144_5A071E49 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. platform_get_irq() returns a negative value on error and does not return zero. Therefore, only check for a negative error code and return it directly. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-afe-pcm.c b/sound/soc/mediatek/mt8186/mt8186-afe-pcm.c index 143386c54dd7..4bf098657fb4 100644 --- a/sound/soc/mediatek/mt8186/mt8186-afe-pcm.c +++ b/sound/soc/mediatek/mt8186/mt8186-afe-pcm.c @@ -2852,10 +2852,8 @@ static int mt8186_afe_pcm_dev_probe(struct platform_device *pdev) /* init audio related clock */ ret = mt8186_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error, ret %d\n", ret); + if (ret) return ret; - } /* init memif */ afe->memif_32bit_supported = 0; @@ -2885,15 +2883,14 @@ static int mt8186_afe_pcm_dev_probe(struct platform_device *pdev) /* request irq */ irq_id = platform_get_irq(pdev, 0); - if (irq_id <= 0) - return dev_err_probe(dev, irq_id < 0 ? irq_id : -ENXIO, - "no irq found"); + if (irq_id < 0) + return irq_id; ret = devm_request_irq(dev, irq_id, mt8186_afe_irq_handler, IRQF_TRIGGER_NONE, "Afe_ISR_Handle", (void *)afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle\n"); + return ret; ret = enable_irq_wake(irq_id); if (ret < 0) @@ -2957,10 +2954,8 @@ static int mt8186_afe_pcm_dev_probe(struct platform_device *pdev) &mt8186_afe_component, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_err(dev, "err_dai_component\n"); + if (ret) goto err_pm_disable; - } ret = pm_runtime_put_sync(dev); if (ret) { -- 2.43.0