From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v2] net: stmmac: hold runtime PM reference in setup_tc
Date: Mon, 31 Aug 2026 17:26:32 -0700 [thread overview]
Message-ID: <20260831172632.64aadc2c@kernel.org> (raw)
In-Reply-To: <apWVBrXNt74gtUd4@lore-desk>
On Mon, 31 Aug 2026 16:51:50 +0200 Lorenzo Bianconi wrote:
> - This issue is not introduced by this patch and it needs to be fixed with a
> dedicated patch
Looks like the driver has multiple bugs in handling of TC callbacks
while down. Please fix all of them in one series, otherwise we may
end up changing approach.
Can you also confirm that the device programmed while down retains
all the necessary configuration thru the open path, and everything
works as expected?
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-01 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 7:12 [PATCH net v2] net: stmmac: hold runtime PM reference in setup_tc Lorenzo Bianconi
2026-08-31 9:55 ` Lorenzo Bianconi
2026-08-31 9:59 ` Maxime Chevallier
2026-08-31 14:51 ` Lorenzo Bianconi
2026-09-01 0:26 ` Jakub Kicinski [this message]
2026-09-01 9:33 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831172632.64aadc2c@kernel.org \
--to=kuba@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox