From: Conor Dooley <conor@kernel.org>
To: Sasha Finkelstein <k@chaosmail.tech>
Cc: Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Neal Gompa <neal@gompa.dev>, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122
Date: Tue, 1 Sep 2026 18:41:36 +0100 [thread overview]
Message-ID: <20260901-clapped-fled-2ae6126df5cc@spud> (raw)
In-Reply-To: <20260901-t603x-spmi-v9-1-09e702e3b153@chaosmail.tech>
[-- Attachment #1: Type: text/plain, Size: 1909 bytes --]
On Tue, Sep 01, 2026 at 12:29:00PM +0200, Sasha Finkelstein wrote:
> Add t603x and t8122 compatibles, interrupt support, and support for
> SPMI controllers that are not always-on.
>
> Reviewed-by: Janne Grunau <j@jannau.net>
> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
> ---
> Documentation/devicetree/bindings/spmi/apple,spmi.yaml | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c31..4e73083ecec3 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> @@ -20,8 +20,11 @@ properties:
> - items:
> - enum:
> - apple,t6020-spmi
> + - apple,t6030-spmi
> + - apple,t6031-spmi
> - apple,t8012-spmi
> - apple,t8015-spmi
> + - apple,t8122-spmi
> - const: apple,t8103-spmi
> - items:
> - enum:
> @@ -34,10 +37,36 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + maxItems: 1
> + description: Optional, operates in polled mode if not present
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + power-domains:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - apple,t8122-spmi
> + - apple,t6030-spmi
> + - apple,t6031-spmi
> +then:
> + required:
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
else: false?
Or do the existing devices also support these?
> +
> unevaluatedProperties: false
>
> examples:
>
> --
> 2.55.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-01 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 10:28 [PATCH v9 0/6] spmi: apple: Additional commands and interrupt support Sasha Finkelstein
2026-09-01 10:29 ` [PATCH v9 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122 Sasha Finkelstein
2026-09-01 17:41 ` Conor Dooley [this message]
2026-09-01 18:24 ` Sasha Finkelstein
2026-09-02 17:02 ` Conor Dooley
2026-09-01 10:29 ` [PATCH v9 2/6] spmi: apple: Validate FIFO state Sasha Finkelstein
2026-09-01 10:29 ` [PATCH v9 3/6] spmi: apple: check transaction status Sasha Finkelstein
2026-09-01 10:29 ` [PATCH v9 4/6] spmi: apple: Implement remaining commands Sasha Finkelstein
2026-09-01 10:29 ` [PATCH v9 5/6] spmi: apple: lock around FIFOs Sasha Finkelstein
2026-09-01 10:29 ` [PATCH v9 6/6] spmi: apple: Add interrupt functionality Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901-clapped-fled-2ae6126df5cc@spud \
--to=conor@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=k@chaosmail.tech \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).