From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DF9EC624CF for ; Tue, 1 Sep 2026 10:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G16mJgiGGsS4pp8GycAQb1G+YaBLkP+xLI1RpKwUZGc=; b=PGj+z2DepDwWhPVB9Z9aGyopTq SRFQKDNBNVBoZWfEzVMXmLCHDouLNK4W4/LEg5FUywETbR6bpMnbROyC6/zy04W913nhruNc9/5iv btOziGqbRfqkrFV3B5pDsKK+YlsR0c96vAXHvE+Z10PjKJJEQD7Wibz9vou94ZaLAQ0RJDbNm85Jm wK2sp/V5jHFql/6VzB29wPRyO06OrPaTa3CMMb7jfpXMxPqKweVnl3VcVl7fFkqiGuJV6z9girtuc efItHtbUWby43eeyE3M1dUYN0LxJD5sYviMaxcfgmr+pO04GzI9JJMHspRIZVNqI8/UVqmhlyeAWg zTbw3Geg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1LMz-0000000BV4p-0EC7; Tue, 01 Sep 2026 10:05:33 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1LMx-0000000BV4c-3Uef for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2026 10:05:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 206B1601DB; Tue, 1 Sep 2026 10:05:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08C8C1F000E9; Tue, 1 Sep 2026 10:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788257130; bh=G16mJgiGGsS4pp8GycAQb1G+YaBLkP+xLI1RpKwUZGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SD0xZAu77WmakhKvsElwMocYyHV5VONv5alRC0gmvFAt65Z1kw7pNLGkzYgTgLTJi Dc022miruNpzUJqtHq6YlgTiRSKg8X6ty59O5GagI/lIOUbZuWEkE2nKbMh9SUgTsQ Vx+cyZYI5TJ7brZpjMDdPUV5FqytTgj8IL8p18jr0SGl3fEIImCG3FIFlSqTZmurX9 RC/QckIOjqfRG3wsTxM5QtscJmq/Nrh2zrO40ubwOV5/0AZQsjhREEQkL94xQHYlUI GoLn+pWWZYrFnR6tIHoT3qLwnyagHQjPj+OB9QZdytZgtWS2SofvlIV86k43akrxZc i+pMj7+fEuAqA== Date: Tue, 1 Sep 2026 12:05:27 +0200 From: Krzysztof Kozlowski To: Markus Probst Cc: Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Michael Langer , Andrew Morton , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 1/6] dt-bindings: rtc: Add pinctrl for S35390A Message-ID: <20260901-proud-furious-bison-0edeec@quoll> References: <20260831-rtc_s35390a_int1-v8-0-dac1dc86ce1f@posteo.de> <20260831-rtc_s35390a_int1-v8-1-dac1dc86ce1f@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260831-rtc_s35390a_int1-v8-1-dac1dc86ce1f@posteo.de> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 31, 2026 at 05:42:22PM +0000, Markus Probst wrote: > Synology NAS devices use the output pin for interrupt signal 1 to wake up > the system. > > Move devicetree bindings for sii,s35390a into its own file. > Add necessary properties to configure the individual pins via pinctrl, > which allows the interrupt signal 1 to be used for wakeup alarm. > > Signed-off-by: Markus Probst > --- > .../devicetree/bindings/rtc/sii,s35390a.yaml | 117 +++++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 3 - > 2 files changed, 117 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > new file mode 100644 > index 000000000000..dfe632c4b2c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/sii,s35390a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: S-35390A 2-WIRE REAL-TIME CLOCK > + > +maintainers: > + - Markus Probst > + > +description: > + The S-35390A is a CMOS 2-wire real-time clock IC which operates with the > + very low current consumption in the wide range of operation voltage. > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + const: sii,s35390a > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + description: Supports up to 2 interrupt lines via the INT1 and INT2 pins. > + > + interrupt-names: > + items: > + - const: int1 > + - const: int2 > + > + wakeup-parent: true > + > + wakeup-source: true > + > + "#clock-cells": > + const: 1 > + > +patternProperties: > + "^pins": > + type: object > + additionalProperties: false > + > + patternProperties: > + "-pins$": > + type: object > + additionalProperties: false > + > + allOf: > + - $ref: /schemas/pinctrl/pinmux-node.yaml# > + > + properties: > + pins: > + minItems: 1 > + items: > + enum: > + - int1 > + - int2 > + > + function: > + description: | > + Pin function: > + - ignore: Preserve the previous state. > + - disable: Disable pin output. > + - wakeup: Output wakes up the system. > + - clock: Output clock pulse. > + - pmin1: Minute periodical output with 50% duty. > + - pmin2: Minute periodical output L for 7.81 ms. > + Can only be used with pin int1. > + enum: > + - ignore > + - disable > + - wakeup > + - clock > + - pmin1 > + - pmin2 > + > + required: > + - pins > + - function > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@30 { > + compatible = "sii,s35390a"; > + reg = <0x30>; > + pinctrl-0 = <&rtc_pins_default>; > + pinctrl-names = "default"; > + > + wakeup-parent = <&int>; I don't understand this need. Device does not generate interrupts - no interrupts property - thus how can it wakeup? As explained in commit msg, the signal at int1 goes to the SoC, right? So where does it go? To which pin of which device? &int? Can you show complete upstream DTS using this? Best regards, Krzysztof