Re: [PATCH] usb: dwc3: google: Initialise probe properties with DWC3_DEFAULT_PROPERTIES

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Wed, Aug 26, 2026 at 12:36:29AM +0000, Thinh Nguyen wrote:
> On Wed, Aug 19, 2026, Radhey Shyam Pandey wrote:
> > dwc3_google_probe() zero initialises struct dwc3_probe_data and never
> > assigns its properties member. The unspecified state of gsbuscfg0_reqinfo
> > is encoded as DWC3_GSBUSCFG0_REQINFO_UNSPECIFIED (0xffffffff), not as
> > zero, so dwc3_get_software_properties() reads the zeroed field as a value
> > the glue explicitly requested:
> > 
> > 	if (properties->gsbuscfg0_reqinfo !=
> > 	    DWC3_GSBUSCFG0_REQINFO_UNSPECIFIED) {
> > 		dwc->gsbuscfg0_reqinfo = properties->gsbuscfg0_reqinfo;
> > 		return;
> > 	}
> > 
> > Two things follow. dwc3_config_soc_bus() programs GSBUSCFG0.REQINFO with
> > zero on hardware that never asked for it, and the early return skips the
> > walk over the parent devices, so a swnode or device tree supplied
> > snps,gsbuscfg0-reqinfo would be ignored.
> > 
> > Assign DWC3_DEFAULT_PROPERTIES so the unset fields carry their unspecified
> > sentinels and the controller is left alone.
> > 
> > Fixes: 8995a37371bf ("usb: dwc3: Add Google Tensor SoC DWC3 glue driver")
> 
> Does this need Cc stable?

I'll add it, thanks.