From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33290C61DD6 for ; Wed, 2 Sep 2026 20:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AzXtSV/WWtydTYO3EmejDkL+S0H/FVtNGv1YBW4SI2s=; b=rCK7zN4iOm1QmB2uim8b9AcTec AEt/44DbR64spJRTM11J35YYAl9Nzd5M5/ZODGEqsPafksBD2sTTvuKc4RpoztCrK1w3AUPDgHhSG bNIXx6tOYBeGuV6nOeXfsMhhtzSzpwSFosYnZpBk74zvpNkHKjzWKx9eG0iZrzc9amLd/5IacLWxH J0cqilGPhIURropxLr/X7yeu6TRrwMawCMZqo3eIy0R3VjvgXTL5Ev5cC9Gi/Fq4VVi7lOQkVAG0q lo3c+nd/sie0XUSC76IEbtul+k0P07zQL9VZmjQ7y8uibCjjhFiCs0Wse4bLFILwoH0nMtWRJ9mm8 HBkbB+qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1rOO-0000000FqKM-2xO3; Wed, 02 Sep 2026 20:17:08 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1rOL-0000000FqJD-3wW8 for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2026 20:17:07 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 682KH5g62581012 for ; Wed, 2 Sep 2026 20:17:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=AzXtSV/WWty dTYO3EmejDkL+S0H/FVtNGv1YBW4SI2s=; b=CvbVC+q9kQRRtFSCnNcyzsAX5tj yTWXuwhhl+7w/PCwuugp+uPc+vbrzE7anfZtzqn3uf46kLo72QjQf86fmd1F4AHh YZz5UIP4/Sl0EbR391MOBU/DWnz+wNtMd2+J6UiEf06DeZJ9UcSFFesMDBHrLTuo nyo+CJtNOEw4++m2/oAxc2OmlDoocqY5bhZkHlq6VkXFFqQrcYA3RFW8MxWkdwy5 u4Daiw3zhz6A0Wd1VQbtsPS+efAub9dHQaYctpfIgSP8G4jPWB0Umbn3Ul2wHZvW Cnp59SwGnFPZwPQ09iNce1ycNwr4B7tBac3ES/O25zXm9HWjJ9tn9m4Zt7w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gej2cagwf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 02 Sep 2026 20:17:01 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-398d7e0f3b4so2058270a91.3 for ; Wed, 02 Sep 2026 13:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788380221; x=1788985021; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AzXtSV/WWtydTYO3EmejDkL+S0H/FVtNGv1YBW4SI2s=; b=Pvsl93FgjEslZ4hfCYP8Ds80355ku6XsX5dypWDGVj3OKfpXchHLN6DFIlRk2KaKPI DrqWI8pI9KZlmvKOsjmdkUw02bddbHr7RTXESsTSR7VIwTt/+Gkq7CLD4aaNKWOXLzP1 RdqbloMpu5Q7B4uYZHLWGrleo4GGu7CJWnqFqvi0HxmSCqR1+cPdCU6lKIa2wQBkgXRZ shAgLhyLmR0Qhz1SG3Hz81NGPmwSirfcXR2VBCC89/30lgi5rIjgZ+b/aNsCBlqWWIhB NaDoXlJrxu/tEtI5n9iMdhX7fIEVfD3x2nCLQKXiByMMkB8MIG2kUNk+bpZKD5RyQTL4 gb6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788380221; x=1788985021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AzXtSV/WWtydTYO3EmejDkL+S0H/FVtNGv1YBW4SI2s=; b=TnxZUpYFmnzrO1mdz8a3FKA022AdQuHq41mAtgp8dBTm/DgilN5Hq1peW+ww43TFrs fmBG4bF8qY+jAtst+B0NelVTrVexzbi/sVNANIjavQ46TOWCfLK/Mom4LwWtmNsk80F4 i19obzsyFwZ6Ubu6iho5HzIXjtz/ZuKFA79KVOfXVt6YR2k5drbTHNhv3wocTKHYJOxw hEq6UCq2agPz+Mpd7aOgEz0lP69N/bMUqCLnUM+/IqPzWSg9LyORvvG2iMFOw+bJK9Nt nwX4sGbnHNgxYgSY2WJRfPDkWX8IxlxTYp72LRU71CZw7KBNmmbRjJ8WyUCiQKZQOhaT 1E+w== X-Forwarded-Encrypted: i=1; AKwUvBwNF7YT7u2On8lh7Y6dlqz/0o20ynpCxQhoxLVq2yr0FJAw7lmu8QstKX07MDOgFsnB+6WExFhJ3Wuv/N/dBvDe@lists.infradead.org X-Gm-Message-State: AFuF++lf4SsmP/CohMr+adkYvoREtTd+8bZz5Res5KTrVWpE01rLU602 QHIFn2Gd0xs2zw7mPuum2bp4XxQi0BWd6J7mS5KopItxoG/j2uQJPZlq3Chcpph29W3QmllB8fH zmYKbydxEp+wFsg972YovyNNCpxBOK6Jy93D9HmCgAqloiYeXA3iPcsp4ukTu/Mpl9/AivWJxfr J/kw== X-Gm-Gg: AYBFou0CuKfx/Dbv3avNpD73D0PipKY/0KhFP1a49UkJy8k2jsH3tV8dLp9+QTlskCF 7htIRrhosZYBwEZbZ0oTBF93XJvtOR/QhWmGcdwW/IJgMyZP+I+G7DQXRwVXJUrYTwMr0NHH+n0 LhFEsGP+tAMY5K83iEUCj9/wZMvBpBW8NnxdHlljFIr13xGNt0kQF5Xedm15A9KgLSWz29JdAk/ F1PRJX5rm5HVhRNMGFwwgpopkjm0eQPsu/5foJ2JAQdJhEmjPlWypFLDmZvg3VPbjTq7Us/Dte1 9ErGszBTcs2KANU/1xNgb7E5yrXEzXcTgafesPqWy3rzUqaOUDebZdtDPq2bHloZPqVXzb85i0F FD/g44pCmOEYW3DLrE4tb0grmIlI= X-Received: by 2002:a17:90b:3907:b0:381:11eb:d78e with SMTP id 98e67ed59e1d1-39aee066e04mr8860764a91.14.1788380220867; Wed, 02 Sep 2026 13:17:00 -0700 (PDT) X-Received: by 2002:a17:90b:3907:b0:381:11eb:d78e with SMTP id 98e67ed59e1d1-39aee066e04mr8860691a91.14.1788380220414; Wed, 02 Sep 2026 13:17:00 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33256414c60sm497205eec.24.2026.09.02.13.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 13:16:59 -0700 (PDT) From: Mukesh Ojha To: Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek Cc: Ryan Chen , Billy Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, Mukesh Ojha Subject: [PATCH v2 1/11] drm: logicvc: Use devm_of_reserved_mem_device_init() Date: Thu, 3 Sep 2026 01:46:30 +0530 Message-ID: <20260902201640.2024648-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902201640.2024648-1-mukesh.ojha@oss.qualcomm.com> References: <20260902201640.2024648-1-mukesh.ojha@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDE3OSBTYWx0ZWRfX7LoFm47+QCAf m1ptsne6Ucma4rwvPoDhuwaK8plEuQS6y/ZNKNZMyJk1Mr6tw/Xb28X64HfTvZyssl4HIE46S/W TEz30s8YORHwMOBAE83lQiPOg/R2Z6k= X-Authority-Analysis: v=2.4 cv=G+ss1dk5 c=1 sm=1 tr=0 ts=6a98843d cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ReI0EElcLHst8dYcsfAA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: WoguV3x8NvpMrHwtNs9ezh6yI5xxt1E_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDE3OSBTYWx0ZWRfXz2J0JszDhqnf iLQI7OCvyTk2F50cSjImjILs0UDyYsEw6HmYbgY2Ay2DYpFjfqwAoUcV3yR8cwqAJuyzTF5N2/r y0uRngwyi3XpByFHfygOFqt39r3+ruv0G3QA82nML0547QdVve4xw54ezzXaYPwrtZRHhwVjGbH LEkx3uvoY/ELqdqj3nI2kFmzKCUVEVAH0xt8w1+dMHTffrQM8yPvJENTQovEQAbSfP4I+rvFBA+ k08Y8x6KETm1fC4f3MfGr8KJ/SzUZVlbK/y9D0Sv+acqi25Rm2PQOvXftE29P2BlnavSr67GuAu UcdQyXah3SZDe+CDLdsIPkimRfStc8ftji9RmawYCtFrYsWzt0Bv4yBg92nuwp/jr4eezNNyOM6 XzlJ0Wdk8t9G0P7LdSAb1BNSsT4mrtn19rykyp28298Ahd1m1P+cpQV4gxoxwULrTkfDwpl/Vem t7tLxabbwoiMSLsD2/Q== X-Proofpoint-ORIG-GUID: WoguV3x8NvpMrHwtNs9ezh6yI5xxt1E_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-02_04,2026-09-02_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609020179 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260902_131705_988541_3EAAA51F X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Switch to devm_of_reserved_mem_device_init() so the reserved memory region is released automatically on probe failure or device unbind. Replace all error paths that jumped to error_reserved_mem: with error_early: since the manual cleanup label is no longer needed, and remove the explicit of_reserved_mem_device_release() call in the remove function. Reviewed-by: Paul Kocialkowski Acked-by: Paul Kocialkowski Signed-off-by: Mukesh Ojha --- drivers/gpu/drm/logicvc/logicvc_drm.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c index bbebf4fc7f51..d6dbe52ff0a9 100644 --- a/drivers/gpu/drm/logicvc/logicvc_drm.c +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c @@ -306,7 +306,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) int irq; int ret; - ret = of_reserved_mem_device_init(dev); + ret = devm_of_reserved_mem_device_init(dev); if (ret && ret != -ENODEV) { dev_err(dev, "Failed to init memory region\n"); goto error_early; @@ -327,14 +327,14 @@ static int logicvc_drm_probe(struct platform_device *pdev) ret = of_address_to_resource(of_node, 0, &res); if (ret) { dev_err(dev, "Failed to get resource from address\n"); - goto error_reserved_mem; + goto error_early; } base = devm_ioremap_resource(dev, &res); if (IS_ERR(base)) { dev_err(dev, "Failed to map I/O base\n"); ret = PTR_ERR(base); - goto error_reserved_mem; + goto error_early; } logicvc_drm_regmap_config.max_register = resource_size(&res) - @@ -345,21 +345,21 @@ static int logicvc_drm_probe(struct platform_device *pdev) if (IS_ERR(regmap)) { dev_err(dev, "Failed to create regmap for I/O\n"); ret = PTR_ERR(regmap); - goto error_reserved_mem; + goto error_early; } } irq = platform_get_irq(pdev, 0); if (irq < 0) { ret = -ENODEV; - goto error_reserved_mem; + goto error_early; } logicvc = devm_drm_dev_alloc(dev, &logicvc_drm_driver, struct logicvc_drm, drm_dev); if (IS_ERR(logicvc)) { ret = PTR_ERR(logicvc); - goto error_reserved_mem; + goto error_early; } platform_set_drvdata(pdev, logicvc); @@ -371,7 +371,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) caps = logicvc_drm_caps_match(logicvc); if (!caps) { ret = -EINVAL; - goto error_reserved_mem; + goto error_early; } logicvc->caps = caps; @@ -382,7 +382,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) ret = logicvc_clocks_prepare(logicvc); if (ret) { drm_err(drm_dev, "Failed to prepare clocks\n"); - goto error_reserved_mem; + goto error_early; } ret = devm_request_irq(dev, irq, logicvc_drm_irq_handler, 0, @@ -450,9 +450,6 @@ static int logicvc_drm_probe(struct platform_device *pdev) error_clocks: logicvc_clocks_unprepare(logicvc); -error_reserved_mem: - of_reserved_mem_device_release(dev); - error_early: return ret; } @@ -469,8 +466,6 @@ static void logicvc_drm_remove(struct platform_device *pdev) logicvc_mode_fini(logicvc); logicvc_clocks_unprepare(logicvc); - - of_reserved_mem_device_release(dev); } static void logicvc_drm_shutdown(struct platform_device *pdev) -- 2.55.0