From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25CBFC624D4 for ; Fri, 4 Sep 2026 00:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QQRaLYDUxy93Hz6VAFpiPT/0NSOIPKw/WnvayVAwG9E=; b=mrimJe+IB3eEdfUCTpWwyKbL7A LQKUsiZoqqb3ZHeTnqK39DRoqM8ym8q+6hLgFCuHe9zmW6C4b3z3JX9/OQqwTuh13lxraELFgs7ri V7DLCS/tzPNiWDYKqOkY56lgGGZss2NLGQZpL2cJvaqUHX0N5cGCVK+P/5FnvT6E93dxwWn9J5gjn B+oMMwCIHZ8o7kyWWpzSegCXbOGtfQJBgaRYcX0megzeSQpQxNC6VkKN2r78lmZlgATDS/6VnBdVh v62EV5P/akxYQIyatz4wTMsCl/UpGVPn9ukr7J8IXxE6OgaZ2tSfIBmk4DkA24xnjP06BiYdC2ehi MYaRaslw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2Hu2-00000000oFu-05LN; Fri, 04 Sep 2026 00:35:34 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2Hu0-00000000oFj-48qq; Fri, 04 Sep 2026 00:35:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5804D40822; Fri, 4 Sep 2026 00:35:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E217D1F000E9; Fri, 4 Sep 2026 00:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788482132; bh=QQRaLYDUxy93Hz6VAFpiPT/0NSOIPKw/WnvayVAwG9E=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eNtntJC+ZaU5DuPCGwWC4NMYJuf1+vBiSpsBcsil3YZ/WegGG3own2Hi8iJ3Wcs6U OXFgcfGVog5BiEDaue56KnV+r4azi9rCX+I2xLDr8298x4u3SFPQJfoI3y0gmEcRrA bB09BNDPwatvEH9Hr+QStwvfZDfbhyb63XpSFtSI6IfoXwxjD01d1BATqwtNCG4KfS zWi4QpQdhNTzCfcpe3bVA0MsBgongbtdAX1ADNWrl7hSj8z9LXFa9BeiCpnVT7xaGa sIMSKIe/Lolj2BSpW/8V2kW8FadSsHEhbr7TGJaoTkIv6O2vs490WAE2fOlLzBd6gs mIjZPKG9Sxygg== Date: Thu, 3 Sep 2026 17:35:29 -0700 From: Jakub Kicinski To: Vitaliy Sochnev Cc: Lorenzo Bianconi , netdev@vger.kernel.org, upstream@airoha.com, Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3 1/2] net: airoha: handle RX_NO_CPU_DSCP interrupt, not just RX_DONE Message-ID: <20260903173355.62780188@kicinski-fedora-PF5CM1Y0> In-Reply-To: <17f1beec505b87a4acf16557386a978c98f94b97.1788286284.git.sochnev.v.74@gmail.com> References: <20260831234701.206021-1-sochnev.v.74@gmail.com> <17f1beec505b87a4acf16557386a978c98f94b97.1788286284.git.sochnev.v.74@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 1 Sep 2026 19:32:53 +0100 Vitaliy Sochnev wrote: > Whether NO_CPU_DSCP re-latches while the ring is still empty is not > documented. If it does, a ring that cannot be refilled (page_pool > returning NULL) keeps reasserting it. Masking it until a refill succeeds > is worse: a starved ring never fires RX_DONE either, so it would stay > dead after the memory pressure clears. Since you're not sure you should probably add a timer to retry later? Maybe the IRQ is not needed at all, you could just check on allocation failure if the right is completely drained or have a periodic task a'la fbnic_napi_depletion_check()