From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF66CC79F85 for ; Fri, 4 Sep 2026 08:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jUco8k8loeDw75nokYqtCIPRhQuEjxppf2mE5m0ZQ1k=; b=K2/8C0VyVPLa8FU/QwDqqvnFY7 JRiOLN3nuWn6udo0nnZApaO5EN2HONzEuATpMWIhKELhxA/twB27d6ohOcUGm0G8z3o+XOupH0xPR 8MoQBippRS01QnkPxXEppz+x8VDuxJxq7Ep77JTj9N3PbEDfT4tv8yE5VKpvNlWYb+v9mZra+QUcl OqYP7D2R9pl+4fz7e2JxaeVpj2GZTwB9aN7wXaa5CKcDYXxOtk+vlX0Jei2s0OxhkCX+lXq5kQYAc syOxSvo7jBHX22KFHv92fB/XR86Vwfjis0gRjBnBvAGpWt6y84vvX9UuvCmkxb5HBNNmdwgDyXxX8 18WiMWSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2PVG-00000001Pa0-0J7y; Fri, 04 Sep 2026 08:42:30 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2PVD-00000001PXs-2U6p for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2026 08:42:28 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2d7195706f1so8517685ad.0 for ; Fri, 04 Sep 2026 01:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1788511347; x=1789116147; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jUco8k8loeDw75nokYqtCIPRhQuEjxppf2mE5m0ZQ1k=; b=RTygDaQqLuRVA6rSx5+V6+3A7ybRSJu7q1vfrufrRTML+4C2Q0nq9Jb3B5T+fN8pvP uLIsYnoFLlAzvZC3G0fvZr3/S0jleIKPe+xHbk2Gd41EZSfUYem5R+8Q+v4yaLLgwFsM zyrgSOgo9akncfX14+II2jSnuR0ajrtwA1QV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788511347; x=1789116147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jUco8k8loeDw75nokYqtCIPRhQuEjxppf2mE5m0ZQ1k=; b=eU0QZ0/by9FcDMVDlstQuXxRqxzWZhZiXPmsZgYXEm8NSg/qSmhOmkKKGW7NhDT6pe yrsIqNwC0HZyO9mS5KAlStGEVgpbDHdAdawjAKIGlK6+Xv4GBR9p/WSvpRJK+3OS6wBf ZZvzJ0M06aMLH+wxkenSXizk3snpclBaohEyWAt716a+GzjE+rauYL8Dt+M0Fbz9h/Op AKmDOfiO7Q3N8a/lcqXpPHoqdnrhD4i4didwPBm3JAHZLEPq2sajAn7vjgbV5ETCMYSp aL6gQHX88FExKUFaY8NKOAHse7aU7RStRjTfTyY4OuZ2OQW/ouPRxH5cgJgrnfw4EF6M vnSw== X-Forwarded-Encrypted: i=1; AKwUvBx7yKigjWEz2G31efNRmsvByz9jvms11mqpqz3rCAOtMexMQsKlCY3wvXkBQvuuvCogpF9Eg2mQKlzeFyyh3a2d@lists.infradead.org X-Gm-Message-State: AFuF++mk2Rg730RZxe6+EEGGCklK7FylDUQcSeexWGMmTIR9fKO7QhmF CoQhO+8EgAcUq/vXjZaFuuC3mQkaB3XPhftous6Zdyav0W+hgoCrD+Fzn/hdOCJ15Q== X-Gm-Gg: AYBFou1hmQH9/DJ+5ETqobkg3GSxldXV+xA80nhXI/40vTAyyBxxKlXsjwkney9M3d4 eX77JisTczpe9RiSS1mzaUwKrRbM1YzBD35//GcB4IIVMHbm1Zfb692zX4E/h3kj9hRskoD+Ioc /M5f+YmYorkkU1eUL8+qpPsyTMBTaTaIMe2JdHIKKKHsgB+nnQWDPH0iFMcWTvDwFlZCuZXlVs0 Tx4hjDs+jD/f0SjhQORRAYHeaQUkivdEZgd/5P+CZ4ajtdlXRdarDjzR4Gsjoce16NiDUutpf+K Bz4nPELiPlSFMt1QJdKI53NOqUbOR7zpAC0spFr6+MPgKA9a1AfLbcva+rNAOnA/0/sjSl2AgkJ Xq023I9HpEVGY5PLtzY3z7R20bgW0FfcYWBd6+UBpb7CarwR8ccuwyZcAeyvh4h1YCWeiqmoaiZ r+dniZdJPl5oIki+s0gQFO6okFJp4M6jfS3MK1LJdnrT2CWa4EpKDYchpX68ZKZhY7EE/APdVzH SyppS6GHEQ5mS4foNOR+J7Yjv38xFteTBx/MGXugA5y X-Received: by 2002:a17:90b:3a8e:b0:390:8361:a532 with SMTP id 98e67ed59e1d1-39b260d2eb3mr6786889a91.7.1788511346596; Fri, 04 Sep 2026 01:42:26 -0700 (PDT) Received: from wenst-7875.tpe.corp.google.com ([2a00:79e0:201d:8:343:bf21:3095:9c5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b260fdf9asm3343538a91.9.2026.09.04.01.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 01:42:26 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Konrad Dybcio , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski , Manivannan Sadhasivam Subject: [PATCH v8 03/16] power: sequencing: Add pwrseq_get_state() Date: Fri, 4 Sep 2026 16:41:42 +0800 Message-ID: <20260904084158.1341550-4-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.979.g7e5102b832-goog In-Reply-To: <20260904084158.1341550-1-wenst@chromium.org> References: <20260904084158.1341550-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260904_014227_649592_B7C4B3CC X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The power sequencing consumer API already does power on state tracking internally. Expose the state to consumers through pwrseq_get_state() so that they don't have to reimplement it locally. Instead of just on/off and error codes, the function can also return "unknown" state. This is in anticipation for "uncontrollable" power sequencers (such as GPIOs left unconnected). Acked-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Chen-Yu Tsai --- Changes since v7: - Adapted to pwrseq_enable/disable() rename Changes since v6: - Changed to pwrseq_get_state() with enum return value Changes since v5: - Reverted back to returning -EINVAL if descriptor is NULL Changes since v4: - Make pwrseq_power_is_on() return 1 if descriptor is NULL, i.e. if the descriptor is optional, matching the other pwrseq consumer APIs Changes since v3: - Added missing stub function for !POWER_SEQUENCING Changes since v2: - New patch Needs to go in with "usb: hub: Power on connected M.2 E-key connectors" as it is a build time dependency. Bartosz wants the change on an immutable branch to pull into the pwrseq tree. --- drivers/power/sequencing/core.c | 19 +++++++++++++++++++ include/linux/pwrseq/consumer.h | 12 ++++++++++++ 2 files changed, 31 insertions(+) diff --git a/drivers/power/sequencing/core.c b/drivers/power/sequencing/core.c index 721e888b658d..dbb2bd2f8864 100644 --- a/drivers/power/sequencing/core.c +++ b/drivers/power/sequencing/core.c @@ -968,6 +968,25 @@ int pwrseq_disable(struct pwrseq_desc *desc) } EXPORT_SYMBOL_GPL(pwrseq_disable); +/** + * pwrseq_get_state() - Queries the last requested state of the power sequencer. + * @desc: Descriptor referencing the power sequencer. + * + * This returns the last requested state of the power sequencer. + * + * Returns: + * On success, PWRSEQ_STATE_ON for on and PWRSEQ_STATE_OFF for off; + * negative error number on failure. + */ +int pwrseq_get_state(struct pwrseq_desc *desc) +{ + if (!desc) + return -EINVAL; + + return desc->powered_on ? PWRSEQ_STATE_ON : PWRSEQ_STATE_OFF; +} +EXPORT_SYMBOL_GPL(pwrseq_get_state); + /** * pwrseq_to_device() - Get the pwrseq device pointer from a descriptor. * @desc: Descriptor referencing the power sequencer. diff --git a/include/linux/pwrseq/consumer.h b/include/linux/pwrseq/consumer.h index 16fad5f3e3ab..e2a2991b20c2 100644 --- a/include/linux/pwrseq/consumer.h +++ b/include/linux/pwrseq/consumer.h @@ -11,6 +11,12 @@ struct device; struct pwrseq_desc; +enum { + PWRSEQ_STATE_UNKNOWN, + PWRSEQ_STATE_ON, + PWRSEQ_STATE_OFF, +}; + #if IS_ENABLED(CONFIG_POWER_SEQUENCING) struct pwrseq_desc * __must_check @@ -22,6 +28,7 @@ devm_pwrseq_get(struct device *dev, const char *target); int pwrseq_enable(struct pwrseq_desc *desc); int pwrseq_disable(struct pwrseq_desc *desc); +int pwrseq_get_state(struct pwrseq_desc *desc); struct device *pwrseq_to_device(struct pwrseq_desc *desc); @@ -53,6 +60,11 @@ static inline int pwrseq_disable(struct pwrseq_desc *desc) return -ENOSYS; } +static inline int pwrseq_get_state(struct pwrseq_desc *desc) +{ + return -ENOSYS; +} + static inline struct device *pwrseq_to_device(struct pwrseq_desc *desc) { return NULL; -- 2.55.0.979.g7e5102b832-goog