From: Aleksei Sviridkin <f@lex.la>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: Vladislav Karmanov <vladislav.karmanov.dev@gmail.com>,
chester.a.unal@arinc9.com, daniel@makrotopia.org, andrew@lunn.ch,
olteanv@gmail.com, nbd@nbd.name, lorenzo@kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux@armlinux.org.uk, dqfext@gmail.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v5 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support
Date: Fri, 4 Sep 2026 23:24:54 +0000 [thread overview]
Message-ID: <20260904232454.391138-1-f@lex.la> (raw)
In-Reply-To: <780c9e93-ca6d-4481-8709-c8e5058f0073@wp.pl>
On Sat, 5 Sep 2026 01:10:33 +0200, Aleksander Jan Bajkowski wrote:
> I'm a little confused by this patch. At the same time, there are patches
> floating around mailing list to disable EEE on the MT7530 PHY[1]. Does
> the EEE work, or is it broken?
Both, at different layers, and the two patches don't collide.
The MT7530 internal GE PHY really does have broken EEE, and Vladislav's
patch fixes that in the PHY driver where it belongs. Mine is on the MAC
side: since the phylink managed EEE conversion, lpi_interfaces was left
empty for every mt753x port, so phylink never saw the MAC as EEE capable
and ethtool answered "Not supported" everywhere, including on boards
whose PHY is fine.
They compose, and the PHY wins. phy_disable_eee() clears
eee_cfg.tx_lpi_enabled and fills eee_disabled_modes, phy.c:1027 builds
phydev->enable_tx_lpi from that flag, phylink copies it into
pl->phy_enable_tx_lpi at phylink.c:1997, and phylink_activate_lpi() is
gated on (pl->mac_supports_eee && pl->phy_enable_tx_lpi) at
phylink.c:1583. A PHY that disabled EEE keeps LPI off no matter what the
MAC declares.
So with both applied, boards with the broken MT7530 PHY stay EEE off
through the PHY driver, and boards with a working PHY get back the
ability to turn it on. Mine doesn't enable anything by itself, LPI stays
off until userspace asks.
next prev parent reply other threads:[~2026-09-04 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 12:36 [PATCH net v5 0/2] net: restore EEE on MediaTek switches and SoC MACs Aleksei Sviridkin
2026-09-03 12:36 ` [PATCH net v5 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support Aleksei Sviridkin
2026-09-04 23:10 ` Aleksander Jan Bajkowski
2026-09-04 23:24 ` Aleksei Sviridkin [this message]
2026-09-03 12:36 ` [PATCH net v5 2/2] net: ethernet: mtk_eth_soc: " Aleksei Sviridkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904232454.391138-1-f@lex.la \
--to=f@lex.la \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chester.a.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vladislav.karmanov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox