From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48FD7C79F82 for ; Tue, 8 Sep 2026 17:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b0N7yiitrW6dR7p59PNZxxyK3pZtNPXwOVD0qGLv/uw=; b=Q8OC3rFlRSJPXjvNPEbibKE0Jh jUQ/JROlqvSWOtQ44iaPtCxyFSEA/Qmgs9YKNFCGPUiXW4Ee21BnSDOL7SFpyv3OWbuabWQCE0N0c iizW1xT97BPazDJQpjrq4cfrhutQGYaAAG20tnheTgdyqH2jewcjQOKJ2Sp7bwNOrf1DzpE9TPZ2x PB9KOyfSxkIRauk3V2kCVM8pzVgypqCw5SBQTWXgIPP8cT8/GVSlzt7N81wS7J2wggdPUZMBVXE/6 dg4PtTeLKSrxS5lkrg3cxjaMjm7Qzp0Qqc6T3RhV0p2kN50iLCYaw5u7BKtPJk70mufZdJ0WXWFF/ w7GZ1MWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xHn-00000009N4n-0Jxg; Tue, 08 Sep 2026 14:58:59 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xHD-00000009MTp-0b2y for linux-arm-kernel@bombadil.infradead.org; Tue, 08 Sep 2026 14:58:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=b0N7yiitrW6dR7p59PNZxxyK3pZtNPXwOVD0qGLv/uw=; b=bDm+m3SXuxO3PrJnGuCb1zYpQu lt81QLbgOpDAq1GJXkX+zoqoIIlBIKPrSNdW5vW94/U+ihnZDr9jywxwDpmg0FZRBHX34QKmi0SA4 WtYH4oZMTFZ6TW6f5ChYr4gQnJEZKfemdTThpbEoQWZIPvMulR69S5oR7ocrezALyhbYbDxXmtmG0 HEUsauF/p5ExnSm19x9xamKTC5Amt5kIfKC9Khs/y6g9ZV5hMJaAmtY9PwWGgmN45vI7KUbb5qgeX 2TrdDNg4jR/x+xGLi2GTlSI5OuEOHAFJNug+LnskDC/sTSCNmhK46QSUvdRtUU1dDt7IK/KKqe0in GOMq8djw==; Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x3xHA-0000000HZcm-0JVo for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2026 14:58:22 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Eive83298156 for ; Tue, 8 Sep 2026 14:58:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b0N7yiitrW6dR7p59PNZxxyK3pZtNPXwOVD0qGLv/uw=; b=UrNdHwA16moFMjxf fJMD7pH4j0/lZ0U+AgJVseFdFW4hLsnlOMdoR8Iobss+OloYgzBNeMoBUZOMDjYS N56805fokNTB/bpnz8TJv9pQUhiYoRKNrzkNbjhkMUE3qLMTtgHjLQ5vAXizYydr IW/DH8y6a4dQq/Gg6Gw/YclNkuv6eaPdQ13pKuChIJQc1QRqm63HT9ZKlIl2/y4W Y/mQht2pu4kkJy3loTphjQF0/1HdO0BBpfPMnzOS4xSIU9jNccw4s3zO7R0Iz8Pj w98506pIY5mq3j/8EmKgnocSZ/is7sS39+oSAnfkAZhy2MbHIXmzuFHKCPXbaH4p 5diaRg== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjhkj0ww5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 14:58:18 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-97cb32961e3so2721565241.2 for ; Tue, 08 Sep 2026 07:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788879497; x=1789484297; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b0N7yiitrW6dR7p59PNZxxyK3pZtNPXwOVD0qGLv/uw=; b=PasbNqAyYt7SiUbQ8uYFb795FGotYoif73nmmB+ZT6cdYO0Grc0XwAfiu4SoRFrQI6 lGt/88+ZtdKj6e9hQues52vqzfBQNgHCAQYUMdX0tpQDMK3l2Qxj4la5aE3Mri6nIN6B NF8mMxE8jEzF9Y78irsA4URuSqo0BrHQeKlHB1bEuqXtOr7EJpzMa/QYu6l3Y54Tpep+ 8ZXNjuIrqoBX/b/ldgZsaWYsnNAFJ6+6aLX7f8lr+RSkFg0/y/Mv1HWS9AwDaj6tMNvz TmqMaOCJckP/EEqywN4tNsjWDr8yJFXC2PmHIvTwLBO0XYivedXrn1Bqi4IfuwVQSd32 04RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879497; x=1789484297; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b0N7yiitrW6dR7p59PNZxxyK3pZtNPXwOVD0qGLv/uw=; b=SjHHhscIfLQf8TyfjNb4y9GbLKkpM5c8SLVUq8hOAl4gN4ZfBeRSGx/F0szXFS8DLE mdbOvj8eZvCC95S6ZM8co/iY5mkppmhhZloQ5KWe6TLICjiJ1SJlCPeJMPDnk0rQaDwO WgFmOB4wUqeTghPe3WPibTUjMmX3rJPsXiXVmZ+lBi58PqkY4bInIa+gXsN95Y5Zxou4 AyqI+03OWpZmN+zheAOybpRz0MoSMrd1zi/d3B6/dYa6Rcrson520LK+cbUMBcmXXyeM PkhdXGrBP3sExJF7oftrDIFZbMw44VR37ZkD3AdZW6Kk1rwznaP5vdyRVqYssJkhTDTa g/6Q== X-Forwarded-Encrypted: i=1; AKwUvBwTNRSnnBfl3uRlyGsSAZ05/XLf3nKVwJ/vh7429+nAZijhsXt+nO3kNcbClWcor15osjEoXVPcoaAkYdrTkhr9@lists.infradead.org X-Gm-Message-State: AFuF++knFRROdw5boZMuIlwkiG/d/qblaclCL0FabqxIB7HNC5/g+k+z 2GSax+iWx3NuB1FPNvMw3ADm8SeWZ6CmNW5QLswGThWm/FyGUgxXL7tQ1tAUBw3IDJVkIJywDgL opWN5pkXtB20LXrzhHnK+DXvuosJwgt3ITUq4P8B2EeJ1vfg0s0T0bQXE0HG515gnVn19izJwII 8vBA== X-Gm-Gg: AYBFou3jBPSnshAzlEww0Ox9Wo0BWAqnJnvJAH7yFPjIxzLziiFkN57Gx+NfOw7Rs8w tBLb/139k3uwyubHyhBAJGkU6Fxju+vaIE13pPcCeFI3QUvKzeYpuyQNylhQYtEGoKeKO2ygeon lWbAzRCFdpCSahqWcvCR76rK5aWu4wgASKkIK6fFqvmeWWmjLXVKDYdMbv/B01715CKc6QcqctW S4X38WYt2tT6nqE6NuG9WCbuDl0cORC7q5CPvUTT5pX12cC5KSP8M8x8c9edxZ5DhixNG+4eqVn IRWOjNix5NSgigKe7xNjabEipNhwy1gTRmHotSJ5VHwaBSpwns6y2/s2lCuKGNbjK/IrwRTLc1x alM52T/0mHoZbAdNfu1vOA2ACimmT X-Received: by 2002:a05:6102:6b03:b0:77b:ae7:1bba with SMTP id ada2fe7eead31-78a4a72eac3mr14116030137.3.1788879497202; Tue, 08 Sep 2026 07:58:17 -0700 (PDT) X-Received: by 2002:a05:6102:6b03:b0:77b:ae7:1bba with SMTP id ada2fe7eead31-78a4a72eac3mr14115998137.3.1788879496786; Tue, 08 Sep 2026 07:58:16 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:79a2:f118:df09:fe51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485958f1493sm25191276f8f.37.2026.09.08.07.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 07:58:15 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Sep 2026 16:57:25 +0200 Subject: [PATCH net-next v14 06/10] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260908-qcom-sa8255p-emac-v14-6-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> In-Reply-To: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1884; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=DLq5kJ6GnQDKhq8FVuX32328SGe67zNr4t3N9JmNPY4=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqoCJs9HybHaSqzBfK2Veao8xyX8UXTlPcezcbj QlPlyhTxkiJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaqAibAAKCRAFnS7L/zaE w1v+D/9iBpy/Ln8FSiJNFaOgPkx7WGqGjICkj3LljoYYONiLgB2AbbniiS/o11WhO6qaA3KlYCy 5LpbCtIpTVc8+Hr/pdu+wDKOYKMU1x3Co7RJPcQDRTDBXbAn3UOdmYo48WkNu3mDMU4Dkd3bbw5 K45RxGgRtI80+uqgWHFtKkKHnUi/KtbJH+4tT+bTmk0bhPQ7fqcgh/q+Pg9ijh4Zmfh6yyOwq7U TY6rIOEV6WalGxA0WrT7qNqvvIV4jB42F1qdYuSD4ce3AGZ9iemrKyl7qTE5LfOEMezpQ6lEr5P 5RRxrJOOFtAHSKMf7H+8q039bFTIzhHKyG2hin3YL0duAYz55SGcBdfcPLxdfPga7JS04y2xkr5 /04dhHN+1c65cwArcgWGGuCapxI2hvyEJdJEUg0Ny0+ezM3BvVFt8KW4xAa4rcO+mRjvvTFEfhT wwRHE77XpXq8zpL4yzW4wHiT023lGqHKQaBfqtJOzpD56dgQlZYX8zIZ/XVnz80DVKdb0VuJ6TI Tjtej0zBwwzi2noJhR4vy8malCbdiMtieCLlMibgq/nXB9FCnsQjTIIIn2oZI3uZfPtT8hn2TsF ASBniHYS1DB52vO23N8V8cd3Idv3x+i7LCDlX/FL99+cCvn8L/PVicsv9qc7QKgIiy2f2JaIrej lGHVVieGgj1UMyQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2MSBTYWx0ZWRfX5Yh5Z/+pHSBo 8YTeuFC2+azIpSIhkAtyBVOfDQSN14EThdN1IacoP8aGkfyukxErl5sxCkp1Ij9v6EpguZue0Nb KRI5O0+lHZ9I+GCk4P+LGnfite1fhdI= X-Proofpoint-GUID: Xov5jXqu346dI0_FyjyGj3TWfq63y-1a X-Authority-Analysis: v=2.4 cv=VYjH+lp9 c=1 sm=1 tr=0 ts=6aa0228a cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=fYsbkC7JaC8eFfGKQicA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: Xov5jXqu346dI0_FyjyGj3TWfq63y-1a X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2MSBTYWx0ZWRfX4xHjT/FVW7ji QLhPpf4c3LnYQciKiVVFVUxgDUitTGH7tH8dBER8kvw9HfrR96hLQNPWVo3KvPQ80tdIEEiChdb xZhFjEZbMVyRhQs6RBTIntuoKlMOH3ekSa6zE4+F5O1NEHVD00rdVNvsrZvbYnwJBqP1sJ8LJzr /eBsWxRiTXul2tZV/yTgkevz9eeVzsg7c9AXk9rVm15VY63X7Z4qWqPzKNIXBVAGxbjcX75aGBc Wx95ckDEo0FFGJ85zeaiiDrDGsneAefjNlST4LWIVTyZ33MUEqjdWfpfE6b9KCNvA3aTZYyr1Vu EbPi4umv+aYzCS5FtSuu2VpL7RAHlRl9u82LRXMadDGvja0j97lPk2+NB3poWMh3HNiLw0+zVzP piLDX9EYtJYrWBE9q6tn4/Ygox3S6oxGlFQhH3AIeUHZ4oPjf3ONwi7Q86vf6kXqOHzgj16H+zw Y1ndvWjN5V8kfCVO6ug== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080161 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_155820_483772_98F7F23F X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ethqos->phy_mode is read by serdes_powerup() and qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its wrapper for the correct interface. It is set once at probe from the DT phy-mode property and never updated. phylink resolves the actual runtime interface and passes it to the mac_finish() callback. On platforms that only ever operate at one speed these two values are always the same, but when the interface changes at runtime - for example switching between SGMII and 2500BASE-X — the stored value becomes stale. The next serdes_powerup() call, on a subsequent link cycle, then reinitialises the SerDes to the wrong mode. Update ethqos->phy_mode from the interface argument in ethqos_mac_finish_serdes() so that it always reflects the last resolved interface. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 47b70b5e706f221c01f1c0ae3b1acafae6641165..fd7414a50eb4e7d4d5adad7e93d49a55500c7f32 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -634,6 +634,12 @@ static int ethqos_mac_finish_serdes(struct net_device *ndev, void *priv, qcom_ethqos_set_sgmii_loopback(ethqos, false); + /* The interface mode is only known once phylink has resolved it and + * may change at runtime, so keep it in sync for later + * serdes_powerup()/serdes_powerdown() calls. + */ + ethqos->phy_mode = interface; + if (interface == PHY_INTERFACE_MODE_SGMII || interface == PHY_INTERFACE_MODE_2500BASEX) ret = phy_set_mode_ext(ethqos->serdes_phy, PHY_MODE_ETHERNET, -- 2.47.3