From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F10C79FAA for ; Tue, 8 Sep 2026 14:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aiTPy9wnX6iEjnXA5Ef3E1UBuWBeMwUWVY4Mf/ds1Tc=; b=OBYBN+SzDGMsi6q5G62adE5Eoc To13HsMp6JKVXZ8S/aARLzV2f46wQOvdcMEkmpfADh7aiouEVbgAaw+sGQdv5fMnv5w4QpsXoxK1L I4cQ9fI6qM8mwDosSL/FJJS1aGtDk4bwODQJzDNHMk1iumXiuvW+Pll/Mvtv3uzwHSs4CBzy3HLKC 98Ac0cdUEY0EtjAnb+Czo4iRLDYf9MF6MWGxQ47xv7dTSTvpaklqdzSfDfAa+8vH6uHTFHKKu3K32 ulvQpvG29YC7S1YGyib2pm1sMD/Wbh8RUL+DOH9D/3P+fZgb5wGrOXMsOPWVRGJyewbhtfEgqt6Ss m61yIN3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xAo-00000009KCG-0H7R; Tue, 08 Sep 2026 14:51:46 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xAl-00000009KAm-2FwZ; Tue, 08 Sep 2026 14:51:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1788879101; bh=xW4LeQKGVm10NdrT7G+AboGl+alKfkI0kXweV+6EAlQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=XITebiz8sCBUSB51TxPDsp0eAqYjh8o0CYhi99c5KRkA1gZ+A54Ne95vvVdqVM7o+ MJOcfCB3XiWBmC/x56pe1VcNIH4tG49URWKgGUIwdORBefwEkVBi1hWeWuuntXI7ga pZ4YMW3mmqsCaLarwrT0HSqyxB06HAsQ4deq9OB+B6tSH3UHf/+msIheY1AU62l0X8 stYlaXpQ18UVc/vV9hkle6U1w3EwM27oVG+WYUtAik6lLws1/gfawkiASGq8VjnQvO RA8deXfKmHK0U85Hex0HqMH2/bOBWs65hVSlE4RYivLTrJYmhTgz4xH4R9gjV2hfjp hG6FXk02M2Elg== Received: from jupiter.universe (unknown [100.64.1.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id D6EA817E0B0B; Tue, 08 Sep 2026 16:51:40 +0200 (CEST) Received: by jupiter.universe (Postfix, from userid 1000) id 9098A480030; Tue, 08 Sep 2026 16:51:40 +0200 (CEST) From: Sebastian Reichel Date: Tue, 08 Sep 2026 16:51:21 +0200 Subject: [PATCH v6 03/10] PCI: dw-rockchip: Move devm_phy_get out of phy_init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260908-rockchip-pcie-system-suspend-v6-3-fbabcca9921b@collabora.com> References: <20260908-rockchip-pcie-system-suspend-v6-0-fbabcca9921b@collabora.com> In-Reply-To: <20260908-rockchip-pcie-system-suspend-v6-0-fbabcca9921b@collabora.com> To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , Jingoo Han , Shawn Lin , Liam Girdwood , Mark Brown , "Yury Norov (NVIDIA)" , Nicolas Frattaroli Cc: Alexey Charkov , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1528; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=xW4LeQKGVm10NdrT7G+AboGl+alKfkI0kXweV+6EAlQ=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGqgIPzP5vtX1eOUuG/C0eZZ0K7IKtb+8xCK9 BCYcww5LZCknYkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJqoCD8AAoJENju1/PI O/qaByYQAIctAdoBWshDPlv0tQeySFix3D56ihdtVGD+K8r25coThtHVEUmXTrlgvkafyA0D3U3 3l9srdpmUfFX6cqhRt6PcO1Vo3ChZ4l7eEGdRLWkGbV5/+8ZmodUgF2djTIwK5Ey9JdA8XuLg1H OfGV9WX40kpGh79mOgrrdlFCAzD2advUyuCnOyH29Z4AoEGVAKs1gMiTKWSiHQhs3jbekiCdFsT g0x+iOpucKPQftMYpg/xYF3zS3F8P8srioK/mx/fGn2EEofBRZLQxERqhrLupd9+2E/eCpSLY0l qskFZswIzVa6/a+IccD7YACoBOGauvfCCdSYP/hsz4QY7A2yfoCl0wDmmMhgBC3/18Mn2hpsyWf dMye2K3J3jZ/bk5hiE9mTwtDEakh3iH9jVzwahrIzD8frGgVx7F4jrcranAg8NhsUwa5i9btwg6 jbOwmOq2ZnemLUeWOA3ZXagnGEOmygRCmA7ChP/ZDzGvDuSvJalb+LiULiLQlMYlgmZjo71Dukr JFrRIoyKBfeOy3tc9DyGa4/Y1S05nJO+MBl/I11EIWet0nGRnQA23wKbL76BLISHVCI39tIcp/p PfHhKLs2eBwAt8SLo/k1JmMdVX0QFTJjxvkOEpwXar5zKsGl1EKNjziZwR7csHcd/t7lpDP9QXO KCFB4N/PQXyBK0rY7Nl8pDg== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_075143_769001_FF5A4FF4 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org By moving devm_phy_get() to the probe routine, rockchip_pcie_phy_init() can be used to re-initialize the PCIe PHY, which is for example needed after a system suspend/resume cycle. Signed-off-by: Sebastian Reichel --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index f67ad3c31c35..7472ec78b473 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -612,14 +612,8 @@ static int rockchip_pcie_resource_get(struct platform_device *pdev, static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip) { - struct device *dev = rockchip->pci.dev; int ret; - rockchip->phy = devm_phy_get(dev, "pcie-phy"); - if (IS_ERR(rockchip->phy)) - return dev_err_probe(dev, PTR_ERR(rockchip->phy), - "missing PHY\n"); - ret = phy_init(rockchip->phy); if (ret < 0) return ret; @@ -858,6 +852,13 @@ static int rockchip_pcie_probe(struct platform_device *pdev) "failed to enable vpcie3v3 regulator\n"); } + rockchip->phy = devm_phy_get(dev, "pcie-phy"); + if (IS_ERR(rockchip->phy)) { + ret = PTR_ERR(rockchip->phy); + dev_err_probe(dev, ret, "missing PHY\n"); + goto disable_regulator; + } + ret = rockchip_pcie_phy_init(rockchip); if (ret) goto disable_regulator; -- 2.53.0