From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CB89C79F9E for ; Tue, 8 Sep 2026 14:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KDuIAOmD9TOy7wbeKmvOrBhyXGkPda+5cVc0xJOwDR0=; b=qLDTq0j/WfpqtJwdz+d8ruFhGp uaAymSsdv1RHa1zi7IgUPwggFZXeffwGYUkb0VktSCprmNpuxCmO56zNwZBqOap1HwV2lX7CKNcEg d0G4zwicgkMY2nRXE67xeTf+XIwGaaxvCaB8/fO4j4KipSRgGw1BmVBpaGv+AkX79HZ1UgapJrARr FkOkWeqlbHCu8kZSblJQKjg5ySiOlmSwMQExDkwKnbYqCT9Fta5fAO8HhjiaR3ua3dB4bPjkN8/2C dvTd+vEsKI2fSWQAOgZ0wPz85PUopGEAfFdar6NZLbOmM/3bmWMjYtwh7CDwLKJQe7rHGuCYVSdDF 4mMZeLOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3x2a-00000009J7w-1dOX; Tue, 08 Sep 2026 14:43:16 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3x2Z-00000009J7P-01Ed for linux-arm-kernel@bombadil.infradead.org; Tue, 08 Sep 2026 14:43:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=KDuIAOmD9TOy7wbeKmvOrBhyXGkPda+5cVc0xJOwDR0=; b=Jk9YYpkFW7EtFXnXjCCX3rd7cn k9BjuH4EJU2/Xtn7gNvyP5GGJ+wnEVxDwfjH0HNa5I/gGwRdl3t8cE8Evy4qXol9IHi8pGtfI7zUf 6P8Yaha8m0gK6Z26aiIWYKzg4GnGm9MU4by/B7jSImqd5tnabyewN1PRYY0okZnDRewvlzs9NUVJn MlXBaiH0qneDdaVEmLG+7a+EbFsJCM+1FZziZH2zMw4XowPI3y1CosHSZCThZ42mHH05mh2P1QdVu 6bExEQKEaGR5BHNLeULp23YH7D91Ul6W7CH1NosaHCpRZuz2IdQWBa1Wz/9XJHVrjsy4IhgBb6mXi JPYRinog==; Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x3x2W-0000000HYIW-0hGS for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2026 14:43:13 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-499db1740e4so2255635e9.0 for ; Tue, 08 Sep 2026 07:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788878591; x=1789483391; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KDuIAOmD9TOy7wbeKmvOrBhyXGkPda+5cVc0xJOwDR0=; b=RMrMLbOBPO1IPTYo9G/rplCt9bdeCXeq/lu/k1cmA44mo/ToxfJYcfNrMFFlKppI0p ADV1O3wXlN8f84WKUxNKF3UQL8Z6hGjIhp4ZBuHjeHumntVH0dRZ2e8eAxVidufwCc2G 7fohtvYLHx55iEModmHAtEcWJREMglHN3ge6hySwCTEk+OYQXeDeBOlVAQi6BqmAynH7 Fe2V5jLiS40Lr3njPvBh7jssbune5fo0TpvsXyvWStdmkl4PqSNOWY/e/dlP5qXPWaMm /zZIaKtY3EbIxF2Pfr2OlQW79tAwQp0u9M6MW0HlBt5HmKS1TVSB4bHst8/NIRnwb56k 6eBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788878591; x=1789483391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=KDuIAOmD9TOy7wbeKmvOrBhyXGkPda+5cVc0xJOwDR0=; b=pTS7EBYfj5Es3xlLrve+FH6PaDo6z2blPh6/LSJhaUb30/3Ngn3ztAQn+zw/1uRCmU AKYceZ2M4VLwQKGHRpAfGHnuVDpDh1XzDGrE+DVITXbNfWRccbsLG7dbuzYfKJ9fikWi FHIbyH6a7rwdrBNljTAdI7ApNajC96GXdXFjo9df9yALC45Zd3ksAs2Br+8kU2ue8zUf M19e+q51/bKC2XbOolqlhzdL4wKhj16j0vsXAkPHP0t0vlG/selHrvm9N32QvtS7qaOC pqZrJyY6wedlGIcDhcNqhqJkOEdlvz68PFwrprybC7dMGfM7eVFIFN6LlkMF2sPqYTwm aXHA== X-Forwarded-Encrypted: i=1; AKwUvBzUS+W6ecHafUS2RzCLWlE/RAfwXF9R7EPZ8XzkFa/hXduTEx76gPx2C4ZXLaO2eUYmcYsfyo0jRQv8w96G8uq8@lists.infradead.org X-Gm-Message-State: AFuF++kczud4X8vvQ0Z/rY7CbxKSR6RZGQcB4U9votonrp+RSHdz9+m0 UqgwPLctllMwvz0jgRJaklR0MVGJbEUfLwp8nQhJ9qene9qhsp4xEPSP X-Gm-Gg: AYBFou2K50JxaCrJOanlk6QwF2wRPBP+8Pa0p4I1KF6dgndxh6NIrx4ftqxmkA13SXN gbQMqKj5fOa+twULCDAqFQa0dp4+Eny5N5vjf9ZEZV+9/lDHXuZ2n2FDccwjhBOt20YFZf8JRH3 MxDGjo4oJuWIGs6WtnobHB4IR6nEtxNQ8qVKXzD5qC5ZlYmQzs3DTQyIs5A5YkvAbtdEK3CVexe MucgjdPT4nL19a/5tcknH0M6PkqFv+9YJCaz7XQEZh5v5ZBJSf4gigt0ZNDRjL1qO3CFPIndx3o V+vIZ0b5QVpdCx/v5yvzX04GZlhZODCs9kMPDo+Oqb7MG7wA7lvQI7qnlKmfJTU3Mt9orx1UTSB OiuLDvs8tQbQWLLEpESN1jb7YrqZvZsrqFsP7CaRNz0olZb7NuV8mytc86jSt3BHwFzUkc8CiWM e9mbCJ4hyahv+Qm81IUk+QmWxYihBlU8YnGcVlg9Qh3r0YJYFcoaoMH6/Yz/dv8b8dXJHgmFAzm 01Hn1Lf+VJGQdCnIUmDtoUGQiq8f+USDwQxGP8I72ywZuPZV5zEBWLC8J/uUty0DjmgZA== X-Received: by 2002:a05:600c:4f48:b0:49d:798:67a4 with SMTP id 5b1f17b1804b1-49d079867f5mr193440325e9.0.1788878590675; Tue, 08 Sep 2026 07:43:10 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B825D00A0B3828666A65C4F.dsl.pool.telekom.hu. [2001:4c4e:1b82:5d00:a0b3:8286:66a6:5c4f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee7fec25sm564356455e9.13.2026.09.08.07.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 07:43:10 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel Cc: Igor Paunovic , Alan Stern , Greg Kroah-Hartman , Vinod Koul , Heiko Stuebner , Neil Armstrong , Manivannan Sadhasivam , linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: s2idle resume hangs in ohci/ehci on RK3588: HC registers touched before the USB2 PHY is powered back on Date: Tue, 8 Sep 2026 16:42:44 +0200 Message-ID: <20260908144245.10700-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908133147.8291-1-royalnet026@gmail.com> References: <20260907190000.s2idle-usb2-resume-royalnet026@gmail.com> <20260908133147.8291-1-royalnet026@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_154312_478265_EC9CA72D X-CRM114-Status: GOOD ( 22.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Sebastian, I tested 53014abc on the Orange Pi 5 Plus and it fixes the hang here. Setup: same kernel (7.3.0-rc1 based), same dts, same procedure as the report, all four USB 2.0 hosts bound, RTC alarm as the wakeup source. The only change is that commit in phy-rockchip-inno-usb2. Result: 4 full s2idle cycles, all of them resumed. The controller that used to hang, fc840000 (the OHCI on u2phy2, the port with nothing plugged in whose 480 MHz clock had it as its only user), went from "enters ohci_platform_resume and never returns" to: ohci-platform fc840000.usb: PM: ohci_platform_resume returned 0 after 20649 usecs ohci-platform fc840000.usb: PM: ohci_platform_resume returned 0 after 20773 usecs ... 8 out of 8 resume passes in that boot returned 0 (4 real s2idle cycles plus the pm_test device/platform phases), each around 20.7 ms, and the same for fc8c0000. For comparison, before the patch the all-bound configuration hung every single time and needed a cold reset, while the control with the four hosts unbound completed 4 out of 4. Tested-by: Igor Paunovic # Orange Pi 5 Plus (RK3588) Two things about how the module was built, so the tag is not read as more than it is. The kernel was built with aarch64-linux-gnu-gcc 13.3.0 and I built the module with gcc 15.2.0 on the board itself, against the installed linux-headers package (that package is arm64, so its host tools cannot run on my x86 build machine). vermagic and the modversions CRCs match, and as a control I first rebuilt the unmodified file from the same commit and got exactly the srcversion of the stock module, so the difference in the tested module comes from your patch and nothing else. The module is also unsigned, since the headers package has no private key, so the kernel is tainted O and E. Two log entries I do not think are related, mentioned so you know I read the whole log rather than only the part I was looking for. On one resume there is an rcu_preempt stall report, but RCU marks the CPUs "(false positive?)", the NMI is answered, and the backtraces show them in cpuidle_enter_s2idle, i.e. asleep where they should be - the opposite of the original failure, where the CPUs did not answer the NMI at all. And on one of the three resumes there is a WARNING in drm_crtc_wait_one_vblank ("vblank wait timed out on crtc 0"). It is display side, and it happened on one resume only rather than on all of them; one of the monitors on this board goes into its own power saving after a while, which would leave the CRTC with no vblank to wait for while keeping HPD asserted, so nothing about it appears in the log. I cannot prove that from the log either way, but it is not the USB path. Also, the network check right after resume fails for about a second before r8169 reports "Link is Up - 2.5Gbps/Full"; that is my script asking too early, not a regression. Happy to re-run this on the version you post this week, and to test the PCIe suspend series on this board as well if that is useful - it has NVMe, two r8169 NICs and an rtw89 card on PCIe. Igor