Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@nabladev.com>
Cc: linux-arm-kernel@lists.infradead.org,
	 Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Michal Simek <michal.simek@amd.com>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: zynqmp: Add ifm ZynqMP VHIP6 EvalBoard
Date: Fri, 11 Sep 2026 09:32:17 +0200	[thread overview]
Message-ID: <20260911-sweet-industrious-stallion-b7a727@quoll> (raw)
In-Reply-To: <20260909182641.165383-2-marex@nabladev.com>

On Wed, Sep 09, 2026 at 08:26:05PM +0200, Marek Vasut wrote:
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/phy/phy.h>
> +
> +#include "zynqmp.dtsi"
> +#include "zynqmp-clk-ccf.dtsi"
> +
> +/ {
> +	model = "ifm ZynqMP VHIP6 Evaluation Board";
> +	compatible = "ifm,zynqmp-vhip6-evalboard", "ifm,zynqmp-vhip6", "xlnx,zynqmp";
> +
> +	aliases {
> +		ethernet0 = &gem0;
> +		ethernet1 = &gem1;
> +		ethernet2 = &gem2;
> +		ethernet3 = &gem3;
> +		gpio0 = &gpio;
> +		i2c0 = &i2c0;
> +		i2c1 = &i2c1;
> +		rtc0 = &i2crtc;
> +		serial0 = &uart0;
> +		spi0 = &qspi;
> +		usb0 = &usb0;
> +		usb1 = &usb1;
> +	};
> +
> +	chosen {
> +		bootargs = "clk_ignore_unused";

You should not have such bootargs in mainline DTS. It ties DTS to
currecnt Linux driver implementation, not mentioning that it is
subjective choice. And once such bootargs appear, then they are tricky
to remove because users of DTS might rely on them.


Best regards,
Krzysztof



  reply	other threads:[~2026-09-11  7:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 18:26 [PATCH v2 1/2] dt-bindings: soc: xilinx: Document ifm ZynqMP VHIP6 EvalBoard Marek Vasut
2026-09-09 18:26 ` [PATCH v2 2/2] arm64: zynqmp: Add " Marek Vasut
2026-09-11  7:32   ` Krzysztof Kozlowski [this message]
2026-09-11 14:50     ` Marek Vasut
2026-09-11  9:38   ` Peter Korsgaard
2026-09-11 14:49     ` Marek Vasut
2026-09-13 14:27       ` Peter Korsgaard
2026-09-10  6:22 ` [PATCH v2 1/2] dt-bindings: soc: xilinx: Document " Michal Simek
2026-09-10  7:01   ` Marek Vasut
2026-09-10  7:17     ` Michal Simek
2026-09-10 23:39       ` Marek Vasut
2026-09-11  8:38         ` Michal Simek
2026-09-11 15:54           ` Marek Vasut
2026-09-11  7:32 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911-sweet-industrious-stallion-b7a727@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@nabladev.com \
    --cc=michal.simek@amd.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox