Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Hanjun Guo <guohanjun@huawei.com>,
	Sudeep Holla <sudeep.holla@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
	Ben Horgan <ben.horgan@arm.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Fenghua Yu <fenghuay@nvidia.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Pawel Chmielewski <pawel.chmielewski@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
	Trilok Soni <tsoni@quicinc.com>,
	Srinivas Ramana <sramana@qti.qualcomm.com>,
	Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
	Ritwick Sharma <ritwick.sharma@arm.com>,
	Gavin Shan <gshan@redhat.com>,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH v10 13/14] ACPICA: actbl2.h: MPAM: adapt to MPAM ACPI v3.1 changes
Date: Fri, 11 Sep 2026 13:28:34 +0200	[thread overview]
Message-ID: <20260911112835.714162-14-andre.przywara@arm.com> (raw)
In-Reply-To: <20260911112835.714162-1-andre.przywara@arm.com>

There is a pending update to the ACPI for MPAM platform design document
(Arm DEN0065: [1]), which re-purposes the "Reserved2" field in the MSC
node as holding an MPAM-Fb offset value, to allow several MPAM-Fb
firmware managers in a system, each using their own internal MSC ID
namespace. The "Identifier" field in the same table still holds an ID
which is unique per system, but within the MPAM-Fb protocol a private ID
is used. The difference between the two is held in this new field.

Change the name of the struct member from "reserved2" to
"mpam_fb_offset", to allow using that value in the code.

[1] https://support.arm.com/documentation/den0065/3-0/

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
Hi,

I do understand that the header file update should go via the ACPICA
repo on github first, just wanted to present the full picture here on
the kernel side.

Thanks,
Andre

 drivers/acpi/arm64/mpam.c | 2 +-
 include/acpi/actbl2.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/arm64/mpam.c b/drivers/acpi/arm64/mpam.c
index 09c7af6bca69e..8c87b4a663439 100644
--- a/drivers/acpi/arm64/mpam.c
+++ b/drivers/acpi/arm64/mpam.c
@@ -338,7 +338,7 @@ static int __init acpi_mpam_parse(void)
 		 * to enable it safely, because we cannot determine safe
 		 * system-wide partid and pmg ranges in this situation.
 		 */
-		if (tbl_msc->reserved || tbl_msc->reserved1 || tbl_msc->reserved2) {
+		if (tbl_msc->reserved || tbl_msc->reserved1) {
 			pr_err_once("Unrecognised MSC, MPAM not usable\n");
 			pr_debug("MSC.%u: reserved field set\n", tbl_msc->identifier);
 			continue;
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index baef525367b5c..f74003878f9fd 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -1971,7 +1971,7 @@ struct acpi_mpam_msc_node {
 	u32 overflow_interrupt_affinity;
 	u32 error_interrupt;
 	u32 error_interrupt_flags;
-	u32 reserved2;
+	u32 mpam_fb_offset;
 	u32 error_interrupt_affinity;
 	u32 max_nrdy_usec;
 	u64 hardware_id_linked_device;
-- 
2.43.0



  parent reply	other threads:[~2026-09-11 11:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 11:28 [PATCH v10 00/14] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-09-11 11:28 ` [PATCH v10 01/14] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-09-11 11:28 ` [PATCH v10 02/14] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-09-11 11:28 ` [PATCH v10 03/14] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-09-11 11:28 ` [PATCH v10 04/14] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-09-11 11:28 ` [PATCH v10 05/14] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-09-11 11:28 ` [PATCH v10 06/14] arm_mpam: propagate MSC access errors for state saving function Andre Przywara
2026-09-11 11:28 ` [PATCH v10 07/14] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Andre Przywara
2026-09-11 11:28 ` [PATCH v10 08/14] arm_mpam: propagate MSC access errors for interrupt control Andre Przywara
2026-09-11 14:26   ` Ben Horgan
2026-09-11 16:19     ` Andre Przywara
2026-09-11 16:23       ` Ben Horgan
2026-09-11 11:28 ` [PATCH v10 09/14] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-09-11 11:28 ` [PATCH v10 10/14] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-09-11 15:13   ` Ben Horgan
2026-09-11 11:28 ` [PATCH v10 11/14] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-09-11 11:28 ` [PATCH v10 12/14] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-09-11 15:09   ` Ben Horgan
2026-09-11 11:28 ` Andre Przywara [this message]
2026-09-11 11:28 ` [RFC PATCH v10 14/14] acpi: arm64: use MPAM-Fb offset field from ACPI table Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911112835.714162-14-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=ben.horgan@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fenghuay@nvidia.com \
    --cc=ganapatrao.kulkarni@oss.qualcomm.com \
    --cc=gshan@redhat.com \
    --cc=guohanjun@huawei.com \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=lee@trager.us \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=niyas.sait@arm.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=rafael@kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=ritwick.sharma@arm.com \
    --cc=sramana@qti.qualcomm.com \
    --cc=srivathsa.rao@oss.qualcomm.com \
    --cc=sudeep.holla@kernel.org \
    --cc=tsoni@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox