From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20F42C88E71 for ; Mon, 14 Sep 2026 11:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DX6kV0ZzebFjrVoVzacIcfAIkWhZq6+fwdC7V2md6H0=; b=alASDDDlz+vjsox3aybnZuh/2I Of7XubGF7CYUjxR7pIC0qGMnRy21LHHDvPu0vxibO1Uj2D9qsqCbRGbntz/WQkvvOEqd58YN8NfJ7 jrdadpViFM3HT+jpsDYyilda5gshtsOh58y0digSnBDTDKen28jLUrqFnELNt0dGvVGyEUaR4W+B+ AMzwYnczFcV6FFV9b4WTg+okR/ZncewLGD25hgYBSEJAw5khfK0iugXJMAdvLBdY9cXCjkyHV9chO +1SxR+E3ip7Y8Xh7tKNAPk7PA9PYQ2d/oTdD9mcNDt7JpBOy4nbtAVHgp77Iy/s1cbKh5vBHHCqPX HeRl3N6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6537-00000003JWf-3qSD; Mon, 14 Sep 2026 11:40:38 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6522-00000003IZD-0VZJ; Mon, 14 Sep 2026 11:39:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1789385967; bh=X4xB2yha54MuwUAmZf3ArFB1dOWc8OJRAQxExcnHYq8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=B1Z9HRcISHe76xu8LyXNP4ZOjw9aXqyrxqYfcoWmJWhX4OhjKzNoCKZsNYT1E5/8l 8c2cygr3Q7DxLgG0t7/UGahxb0iYR/yea16HjbT+cYhrHo4LtFsTSJFerNE8xgqilm Nr2K/kNZHVqq+vc4lMyUV8d4eIPraNHwEntybKNJ4itidldCibMKW8DI+0/bUzAyDn t13u+191tstslaelhYrKkF65aJ32xT5o0obeEDW2DmayNiyTG1a9INSeMtTMTd96rH lpBxMQrGIsP35PpVGrj3LVETSTP3l+h+X1yM2+WCvjik+Kukxr78q7klB8T0gS2PcS mAM0B+MQOOT/w== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id F011917E093B; Mon, 14 Sep 2026 13:39:25 +0200 (CEST) From: Louis-Alexis Eyraud Date: Mon, 14 Sep 2026 13:38:57 +0200 Subject: [PATCH v12 11/24] scsi: ufs: mediatek: Handle misc host voltage regulators MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260914-mt8196-ufs-v12-11-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> In-Reply-To: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Avri Altman , Bart Van Assche , Stanley Jhu , "James E.J. Bottomley" , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , "Martin K. Petersen" Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789385943; l=3082; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=TF3p9jbq2nMjNrHdI9y8GJWx1eGdMeHgZ9JSMsgxvcU=; b=qb+XKP/S0SYbg7hmTxbN1Ao8v0S9ZUAlq5KrdJAc/4sP17Q1ohTt+iLFYO69HHq3Q/IBXx/9x neG74sZhB4ZAlKFr4lv3flyAI/tS6H9Y7shOGqBfS0riAWg4nwd0yN5 X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260914_043930_416859_695054E8 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nicolas Frattaroli MediaTek SoCs handled by this driver contain a per-SoC specific set of miscellaneous supplies. These feed parts of the UFS controller silicon inside the SoC, as opposed to the UFS card. Add the necessary driver code to acquire these supplies using the regulator bulk API. They should be kept on during suspend, so enable them when acquiring. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 4e6182d2cb6d..15960d7d99af 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -42,6 +42,8 @@ static void _ufs_mtk_clk_scale(struct ufs_hba *hba, bool scale_up); struct ufs_mtk_soc_data { bool has_avdd09; bool has_avdd09_1; + u8 num_reg_names; + const char *const *reg_names; }; static const struct ufs_dev_quirk ufs_mtk_dev_fixups[] = { @@ -1224,10 +1226,22 @@ static int ufs_mtk_get_supplies(struct ufs_mtk_host *host) { struct device *dev = host->hba->dev; const struct ufs_mtk_soc_data *data = of_device_get_match_data(dev); + int ret; if (!data) return 0; + if (data->num_reg_names) { + ret = devm_regulator_bulk_get_enable(dev, data->num_reg_names, + data->reg_names); + if (ret) { + dev_err_probe(dev, ret, + "Failed to get misc regulators: %pe\n", + ERR_PTR(ret)); + return ret; + } + } + if (data->has_avdd09) { host->reg_avdd09 = devm_regulator_get_optional(dev, "avdd09"); if (IS_ERR(host->reg_avdd09)) { @@ -2400,14 +2414,30 @@ static const struct ufs_hba_variant_ops ufs_hba_mtk_vops = { .config_scsi_dev = ufs_mtk_config_scsi_dev, }; +static const char *const ufs_mtk_regs_avdd12_avdd18[] = { + "avdd12", "avdd18" +}; + +static const char *const ufs_mtk_regs_avdd12_ckbuf_avdd18[] = { + "avdd12", "avdd12-ckbuf", "avdd18" +}; + static const struct ufs_mtk_soc_data mt8183_data = { .has_avdd09 = true, + .reg_names = ufs_mtk_regs_avdd12_avdd18, + .num_reg_names = ARRAY_SIZE(ufs_mtk_regs_avdd12_avdd18), +}; + +static const struct ufs_mtk_soc_data mt8192_8195_data = { + .has_avdd09 = false, + .reg_names = ufs_mtk_regs_avdd12_ckbuf_avdd18, + .num_reg_names = ARRAY_SIZE(ufs_mtk_regs_avdd12_ckbuf_avdd18), }; static const struct of_device_id ufs_mtk_of_match[] = { { .compatible = "mediatek,mt8183-ufshci", .data = &mt8183_data }, - { .compatible = "mediatek,mt8192-ufshci" }, - { .compatible = "mediatek,mt8195-ufshci" }, + { .compatible = "mediatek,mt8192-ufshci", .data = &mt8192_8195_data }, + { .compatible = "mediatek,mt8195-ufshci", .data = &mt8192_8195_data }, {}, }; MODULE_DEVICE_TABLE(of, ufs_mtk_of_match); -- 2.55.0