From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B460C88E70 for ; Mon, 14 Sep 2026 11:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vJE3SGmaBQwkYyATzxfWU4JY8kDxFgp2zRISTEdRCzM=; b=hxP2e+O6knJoBasycgNyOFziBW M3qW3OqsLHHQm9rBTRiU/UlsHnBlITIAp3rs3uGr1eTACbT8TP9WQC2GLsoU6MzInnapJviY5t5fi xkS+uaBsxMD+lJV0btgsDDsZIrge0vEke9TPFtb9Ao+nfKFuN7j1CX+pNLQ95oC4f752PquZKsjyr gzMUMMrvKmfFl/WTzW2UXQhd4R0bH100w0iF4c409p8F97W8LxNTdHldzJlkjwSGd3bVGqjQpnXH+ NkFXukg9SJAFEypj769sZKoPhrs5H5gfOFy9pifTUEjboMu8+b5p/SwB2SEaV6gz8TDXivYpYzc7s 3tmgmPfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x653z-00000003KF8-0nFF; Mon, 14 Sep 2026 11:41:31 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x652O-00000003IxA-0K1Y; Mon, 14 Sep 2026 11:39:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1789385990; bh=oyDACN4F0IHYK0RFHSGVNT3KdvFnraKnx4i5QptMDQg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UIigl5c8z+HlMZpJIYQ5VWlUrLur/v+rScdLmfMc4aDubYFZE/mV1ErFEN0rPMqaQ HmbwZoZt3KnExhJQX1FiPOiDJ95qAuJJrMkoXmK+NBGM9bdxQrJlWiFlxjaz2xqlNA acE1m4dhGZZneinZhaUZ27OC6P9P3B2J6zVNTxB/X8/ZqbOZb9uC8pMIq/+EyM26U/ RYuVZsIOVaa1YHmG1/SHhJHSgpRmdEGij51WbedRP+vsTW1pwZaCDrg7sVO1np8gGV TA13BwAqkiTQjIvo05k8+ZmqNSGMrlwONTAYSEpmf4fjpRgiuu2D5qvgesxRV3QjFB Dp+6ZMy5CM6hQ== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2C82517E08A1; Mon, 14 Sep 2026 13:39:48 +0200 (CEST) From: Louis-Alexis Eyraud Date: Mon, 14 Sep 2026 13:39:08 +0200 Subject: [PATCH v12 22/24] scsi: ufs: mediatek: Remove ret local from link_startup_notify MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260914-mt8196-ufs-v12-22-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> In-Reply-To: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Avri Altman , Bart Van Assche , Stanley Jhu , "James E.J. Bottomley" , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , "Martin K. Petersen" Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789385943; l=1411; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=nvl2pTrzoEcoOiuYgn0QzQJDrspxIU1eSeChpwbZxnE=; b=1emF6kyB+Qj1bLrfbvlT4Vd+lZbfAPUyrIdQmcDSA73fZO6i3ltdylto93oswfyAW1/dsyw+p 9WOG3Id/ipDAuBhQV16UtCdqF+CllQJFI3bRBaMtI+cv0U0Mkn5qw4Y X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260914_043953_121770_38EB8583 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nicolas Frattaroli Remove the "ret" local variable from ufs_mtk_link_startup_notify, as it's pointless; in all cases it is assigned, it is returned right after without being read first. Rework the code to just return directly, and get rid of the default branch while at it. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 9cd852cadab5..2ebf7a3118da 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1553,21 +1553,15 @@ static void ufs_mtk_post_link(struct ufs_hba *hba) static int ufs_mtk_link_startup_notify(struct ufs_hba *hba, enum ufs_notify_change_status stage) { - int ret = 0; - switch (stage) { case PRE_CHANGE: - ret = ufs_mtk_pre_link(hba); - break; + return ufs_mtk_pre_link(hba); case POST_CHANGE: ufs_mtk_post_link(hba); - break; - default: - ret = -EINVAL; - break; + return 0; } - return ret; + return -EINVAL; } static int ufs_mtk_device_reset(struct ufs_hba *hba) -- 2.55.0