From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 417AAC88E75 for ; Tue, 15 Sep 2026 11:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4qmsMe70cvP6d+oPocwA2wChSivZ912kkTecHoSs1f0=; b=gnB+9oEJ49vM9n6BMHB/nT/ydX JFEBDdXeP3V4NYB8O9X5DRKjQkihl0uELmagkPUWUetn+RelovBh4Kzk/UoJxyLgDf4ig10qsKRRS 2AJ1BOME/8dM4BMTYRPtT4s+chgy1J6jLLwtiT1IZbXY+oEAKV9ifF+zGxNHLVDzl/bqsQLbI7yhx eMlF+MLtLwJCLGebIRGUTgnIIcyttF/qoQup2I2mbV6OOfw0OivShZxYQrEC9agv7CptZ7bwqhr8H AffBKJfq4i3iBTrfpcuCjd3AavFrd/fgAS/2+DUvbe5hWaCFC7UGvFV/gJ6zuqZAshNKpzUz2hYgD cBIspIuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6RRX-00000006Bue-1gdk; Tue, 15 Sep 2026 11:35:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6RRE-00000006BRy-2UBl for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2026 11:35:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79B321764; Tue, 15 Sep 2026 04:34:56 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A0013F86F; Tue, 15 Sep 2026 04:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1789472100; bh=Duw0rbqzZc0OG8KYw+ZvnTS3Mf0PkCHjPT/8/o374fg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ubQaglxNXq4qNU8MsaS0WgAY7sdhdrjBgFc54fGQ0OrluhnLKBaWrylQfo/jiFnOj noaCyq0eRwTI7ktPwU2JZ+dbAYLSiiB1p6qza0czBveoqQT4okS0EUFt91E/3RQ4XE O4L7lbnZvkOXwlA4PMkk+LR5hSGdRkrLz5W8pcMg= From: Yeoreum Yun Date: Tue, 15 Sep 2026 12:34:40 +0100 Subject: [PATCH v11 5/9] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260915-separate_etm_cfg_v2-v11-5-d2b258d51747@arm.com> References: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> In-Reply-To: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> To: Mike Leach , James Clark , Leo Yan , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Yeoreum Yun X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1656; i=yeoreum.yun@arm.com; h=from:subject:message-id; bh=Duw0rbqzZc0OG8KYw+ZvnTS3Mf0PkCHjPT/8/o374fg=; b=owEB7QES/pANAwAKAW3Vw9FaxTEzAcsmYgBqqS1VxtLGhlN+N1BuP+VZSI9LLtuZwzXMSFhzD cJm06wmiq+JAbMEAAEKAB0WIQQtg+CS3QUzuFh1pJ1t1cPRWsUxMwUCaqktVQAKCRBt1cPRWsUx M5oHC/4obvV3deG87NX18PbEDGugKhTfIn9gqv6fz9NhXM6HyIrjXjD4DVK5XxGFiK2eVM7oaGi eEa/pbQCBgm2S+CPk8T1XIS6+vOB3BHyVJ6OTbkBdqotTI9HQPm8DJdZb/j7kVJSwFYuuitU2dJ m7ZRUbgW7EUFDcPi1w+x6kgeP46rumS88EmFqFx5j55B4QebBdzrRTsfpchABb7WCz1seXzMIN4 zKnTnPOyxkVfTAlztZYbnIZ0Afn+DnEdG1t7rvAbRw7I+KgN6oMmRx3YnyXoe+HiT1hLg6P0DWZ Pu86gmKAp9GHYZcyf5XCwqR31IbloZvfF90Lm1hche/se+SGXnmlGRQGImUfA+Uc8k5kD2prFW+ 8kyenPOI1xeDXrsLwDQ9ngwKpTQFswEoB+Xj7Ccv1AYRJhcnLiWPnqGOT9hGvUuvz/j0vDrurXW nMqI9GZ3PoqkzKRX0eDL9QncIxTm/jlioe1ChJVwykjqsDhc7Wy6vYcwv2HNI41Eku+TA= X-Developer-Key: i=yeoreum.yun@arm.com; a=openpgp; fpr=2D83E092DD0533B85875A49D6DD5C3D15AC53133 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260915_043502_111875_FD9D0D6E X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cpu online() check is done in coresight_validate_source_sysfs() already. and smp_call_function_single() will fail when cpu is offline. Therefore, remove redundant check in etm_enable_sysfs(). Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm3x-core.c | 26 +++++++++------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index fd76a57e5f861..12bb38dc596e7 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -515,25 +515,19 @@ static int etm_enable_sysfs(struct coresight_device *csdev, struct coresight_pat return -EBUSY; } - /* - * Configure the ETM only if the CPU is online. If it isn't online - * hw configuration will take place on the local CPU during bring up. - */ - if (cpu_online(drvdata->cpu)) { - arg.drvdata = drvdata; - arg.path = path; + arg.drvdata = drvdata; + arg.path = path; - scoped_guard(spinlock, &drvdata->spinlock) { - arg.config = drvdata->config; - } + scoped_guard(spinlock, &drvdata->spinlock) { + arg.config = drvdata->config; + } - ret = smp_call_function_single(drvdata->cpu, - etm_enable_sysfs_smp_call, &arg, 1); - if (!ret) - ret = arg.rc; - } else { + ret = smp_call_function_single(drvdata->cpu, + etm_enable_sysfs_smp_call, &arg, 1); + if (!ret) + ret = arg.rc; + else ret = -ENODEV; - } if (!ret) { dev_dbg(&csdev->dev, "ETM tracing enabled\n"); -- 2.43.0