From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFEC5C982C1 for ; Thu, 17 Sep 2026 06:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i4O8U0MAhOl2eGKyRFael2sPT5jAuyl8qT2oFFIB9dU=; b=Kq9yzIEmhrzW5S7Neca8H/nUVj 3ruNPIcdlj7pNoYwDDWCmBz2gkj+Wu8lZTxn0vXDU1WC+bvr8C8JgU7fvyA7mAYRx71fQ7/mtco06 m2oMVJkHao/tlok2Kls2ilPpIrnQIqfaZiSAV814TFB261pKKTKdJOI7uK02nk5g9Qcl0mjhuFKrx UUV/ZUe0o/be4kfgjgtwZ5f3kA+7DvUYiaEQOyqPeD+SHl5IGGj6rG23+3yaZBwpMhV0joc9PkOSb XNIdHdq44/2BI2ILCQ7AiG+8c4WNEsKG+XcHBLnTzM3AQ6fnsza9j6ok0Mefb8TBhelQQw9VURlWZ +M9Psfdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x760b-0000000AimS-0cr2; Thu, 17 Sep 2026 06:54:13 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x760a-0000000Aim4-0PtZ; Thu, 17 Sep 2026 06:54:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DE6F6437B7; Thu, 17 Sep 2026 06:54:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B6B1F00893; Thu, 17 Sep 2026 06:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789628047; bh=i4O8U0MAhOl2eGKyRFael2sPT5jAuyl8qT2oFFIB9dU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BYQFrk844ugfaT6DeR5Ft1dspJCO7mkNvKkEWiSRYfJEObqmoAO8iKBYCdfKArq7D 0WPM4VGXSASZc6WIQHDopchjqu3GYLh42OP+xh02fhP1Euq8KAmQglwftymtG+EBqc sDE++Mp5Wr3eG6kIvmgwD3puh2C5J+eZPQD8i6yy0mQqUp4hKEfemG2UTQecWiKcEe uX/3W0ULVC4asOMa2RCLACdnkXzV2aPiC50CkHJFr1xcoCbYk98NF4SXBxTaqqYOlL WUHdTXIwUZPDP85sBpAmsjOpFdXOjYmtxb365QAKppO8ve2+zxc1rv5vlNDiJP9IWo xqPZtVC8ZFffQ== Date: Thu, 17 Sep 2026 08:54:03 +0200 From: Krzysztof Kozlowski To: Michal Wilczynski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Heiko Stuebner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v4 03/20] dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem Message-ID: <20260917-colossal-phenomenal-rattlesnake-7aca88@quoll> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-3-f0e4fd6f2cc8@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260915-jh7110-clean-send-v4-3-f0e4fd6f2cc8@samsung.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2026 at 05:32:11PM +0200, Michal Wilczynski wrote: > Add the dt-binding for the StarFive JH7110 HDMI subsystem. Your cover letter, in the first paragraph, should explain the merging/dependencies constraints - this depends on previous patches and cannot be taken alone. > > The JH7110 HDMI IP is a monolithic block containing both the digital > controller and analog PHY in a single register space. This binding > defines the parent device, which holds the shared register map and > populates its two children: the PHY and the controller. This is > necessary to resolve a circular clock dependency between the HDMI block > and the VOUT clock generator. > > Reviewed-by: Joshua Peisach > Signed-off-by: Michal Wilczynski > --- > .../mfd/starfive,jh7110-hdmi-subsystem.yaml | 95 ++++++++++++++++++++++ > 1 file changed, 95 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..18034d8273b860b71d386cfc63a125f21b20a6b1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/starfive,jh7110-hdmi-subsystem.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 HDMI subsystem > + > +maintainers: > + - Michal Wilczynski > + > +description: > + The StarFive JH7110 HDMI block is a monolithic IP containing both > + the digital controller logic and the analog PHY logic in a single > + register space. It sits inside the video output subsystem, which owns > + the NoC bus clock and reset gating this region and the power domain it > + belongs to. > + > +properties: > + compatible: > + const: starfive,jh7110-hdmi-subsystem > + > + reg: > + maxItems: 1 > + > + phy: > + $ref: /schemas/phy/starfive,jh7110-inno-hdmi-phy.yaml# > + > + controller: > + $ref: /schemas/display/bridge/starfive,jh7110-inno-hdmi-controller.yaml# This node is just too empty... but let's discuss this in the phy patch, where I already commented. Best regards, Krzysztof