From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F2D5C982D1 for ; Thu, 17 Sep 2026 13:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=NvYtCDsJ/2GtmmgYCC1kgs0GY/EQ4feVsPP1dN17Sbs=; b=C2RdqzZI8SUv+tMI74CAJrJ5ea OJfaIdp/e7yEKQv8ePBRpXq8AFIAkkFlWJUsN4mGOwu/D/m/aVb9GedElvywlydvOkYPk7UzQN8wY IWItHh5CXzaHmKnEfmLd/6EbeSBPQlmzSbGoNfNVeAU9d1sfmYcJVVj66+AFaYVxWSXbJV2mhH3lL HSGc9d5O/sToU+MsHxZ2C3J3BxA368T9OdKs3LM7PmpzwcaBJ2hZlyQjMgYiR9yZ0I+Qm3NTsa9mL ldTtFQNE9j81Th1i+X75jYqxyB8x7Qwwag0qG0mY6riUOyZprPqFkAuVFYVQ/HBSrYo0uisRYHBuB nAjmoamw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7CEN-0000000BP8o-1ctY; Thu, 17 Sep 2026 13:32:51 +0000 Received: from smtp25.cstnet.cn ([159.226.251.25] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7CEK-0000000BP83-0XLz for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2026 13:32:49 +0000 Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACXADv566tqtIeBCA--.3671S2; Thu, 17 Sep 2026 21:32:41 +0800 (CST) From: Wentao Liang To: cuiyunhui@bytedance.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, renyu.zj@linux.alibaba.com, will@kernel.org, xueshuai@linux.alibaba.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] perf/dwc_pcie: Fix PCI device reference leak in dwc_pcie_pmu_probe() Date: Thu, 17 Sep 2026 13:32:41 +0000 Message-Id: <20260917133241.2153478-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowACXADv566tqtIeBCA--.3671S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtF17JrW5tFyxAFW7KryrCrg_yoWDKrg_Ga 4xua9rX34DCFnFyF1jyFy3ZryfA3srZa4xWFn7ta1aqrZFvF1rAr9F9r95AF47Wws5Gry8 tw1DWr43ZrW3ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbg8YjsxI4VWkKwAYFVCjjxCrM7CY07I20VC2zVCF04k26cxKx2IY s7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4 kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_ Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1q6rW5McIj6I8E87Iv67AKxVWxJr0_GcWlOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq62Iq12xI8VA0II8E6IAqYI8I648v4I1lFIxG xcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l42 xK82IY6x8ErcxFaVAv8VW8GFyrJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GF ylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV W8Jr0_Cr1UMIIF0xvEx4A2jsIEc7CjxVAFwI0_GcCE3sUvcSsGvfC2KfnxnUUI43ZEXa7I U5o5l5UUUUU== X-Originating-IP: [36.110.52.2] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAANA2qrrJrB-wAAsL X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_063248_531090_789C369D X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dwc_pcie_pmu_probe() gets a reference to the PCI device with pci_get_domain_bus_and_slot(), but returns -ENODEV directly when dwc_pcie_des_cap() does not find the RAS DES capability, leaking the reference. The other early returns and the success path drop it. Release the reference on that path as well. Fixes: 7f35b429802a ("perf/dwc_pcie: fix duplicate pci_dev devices") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/perf/dwc_pcie_pmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c index 5385401fa9cf..edaf5d2e0daa 100644 --- a/drivers/perf/dwc_pcie_pmu.c +++ b/drivers/perf/dwc_pcie_pmu.c @@ -710,8 +710,10 @@ static int dwc_pcie_pmu_probe(struct platform_device *plat_dev) } vsec = dwc_pcie_des_cap(pdev); - if (!vsec) + if (!vsec) { + pci_dev_put(pdev); return -ENODEV; + } pci_dev_put(pdev); name = devm_kasprintf(&plat_dev->dev, GFP_KERNEL, "dwc_rootport_%x", sbdf); -- 2.34.1