From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44080C88E72 for ; Thu, 17 Sep 2026 13:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=BItBd5yqbkIzqGiQqJNCWIZn+1NtHarCWyhmmMoG8p4=; b=IngZfyg/7lqi61SxC1ZRWy4ber mXtFMLY3kJ0VNyz8vh4FddBAtu7pIXsDcQFHPWEVRwANqVagkRlfMoT+14L6f6/lIFljBc9se+Lmn YSfAyvXvBqIK3L7wmBoNL3iyMwR7y1Sknq+AsfzRatjRYVxe723bOjZNF51GzUBzAdRI6MKBvQObq /UljSnzQe1elZX4x0aLO+5+DGUKBn+BnRO3ywRmfD9JTdBwE4SaGl1+P8d3zCBQ1OzZQEreqBHkK9 8z9dtvbiPQ3DtMBC/18Pd0NPZGdmWUV7gokVAw7ANKuEYHdl3MhgjMWwSzXXzi+uHnjc5Of186YQM IUQKDQGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7CRd-0000000BQmX-02AN; Thu, 17 Sep 2026 13:46:33 +0000 Received: from smtp25.cstnet.cn ([159.226.251.25] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7CRa-0000000BQlY-0VVd; Thu, 17 Sep 2026 13:46:31 +0000 Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACH7zkz76tq6sCBCA--.4006S2; Thu, 17 Sep 2026 21:46:27 +0800 (CST) From: Wentao Liang To: bivvy.bi@rock-chips.com Cc: heiko@sntech.de, kishon@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, neil.armstrong@linaro.org, vkoul@kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on() Date: Thu, 17 Sep 2026 13:46:27 +0000 Message-Id: <20260917134627.2153845-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowACH7zkz76tq6sCBCA--.4006S2 X-Coremail-Antispam: 1UD129KBjvdXoWrur18ZrykKw4kCr43Gry8Zrb_yoWkXFc_K3 4fXwnrZa10vF4ruan8t3s3u34qyF1qgw4xWa1Iya43Aayqyw1FqFWfuwnxAFyDXF47Cr47 Gw1qva47CrZxKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbg8YjsxI4VWkKwAYFVCjjxCrM7CY07I20VC2zVCF04k26cxKx2IY s7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4 kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_ Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1q6rW5McIj6I8E87Iv67AKxVWxJr0_GcWlOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq62Iq12xI8VA0II8E6IAqYI8I648v4I1lFIxG xcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l42 xK82IY6x8ErcxFaVAv8VW8GFyrJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GF ylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV W8Jr0_Cr1UMIIF0xvEx4A2jsIEc7CjxVAFwI0_GcCE3sUvcSsGvfC2KfnxnUUI43ZEXa7I U5o5l5UUUUU== X-Originating-IP: [36.110.52.2] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwYNA2qrrRnFrgABsQ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_064630_550916_8E941503 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org inno_dsidphy_power_on() resumes the device with pm_runtime_get_sync(), but the default case of the mode switch returns -EINVAL without dropping that reference. The matching pm_runtime_put() lives in inno_dsidphy_power_off(), which the PHY core does not run when power_on() fails. Release the runtime PM reference before returning. Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c index 30d5e5ddff4a..5a7962af946b 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c @@ -672,6 +672,7 @@ static int inno_dsidphy_power_on(struct phy *phy) inno_dsidphy_lvds_mode_enable(inno); break; default: + pm_runtime_put(inno->dev); return -EINVAL; } -- 2.34.1