From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 710B1C982D6 for ; Thu, 17 Sep 2026 14:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cb96GaT2UcuRzLPsQMdrt7Itu40lc0yhplAWhST9MqE=; b=vzcwVjAUoP7jDkOEmdZ6bEGCnE rHaYCgXJ6Mm0qgJt3hn196JMKAh7CXkVwykMCVAYyjpOd7D8WgbU+BBEhD7vFjRK/I6Brr06yA9XI V48I0c9MCIWCxB0wy9DiPBGnwWUIxTOs8T21L/kK+vbeh5gJKeN3qMHE9vP4TDNuEpYkmrImyNfbi w4dbLtwZQSFXCngt+UKIhAbiNBfkuAeJT7QOwETY7SkqLpFKn2pKcdDz0RQ59+ST94L/7tE4gfDb8 6Rbn0RnrNjo+QGhKEvtJmgmjUzNTp0BA2bynlH7eoRnvB7F5eTS8zim994pA7MzmEXmVAjzDmvf8e SR9UDWlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7Cfe-0000000BUDJ-1Sds; Thu, 17 Sep 2026 14:01:02 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7CfW-0000000BU9S-3DYE for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2026 14:00:57 +0000 Received: from francesco-nb.. (xcpe-178-82-167-143.dyn.res.sunrise.net [178.82.167.143]) by mail11.truemail.it (Postfix) with ESMTPA id 0A6ED2282D; Thu, 17 Sep 2026 16:00:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1789653653; bh=cb96GaT2UcuRzLPsQMdrt7Itu40lc0yhplAWhST9MqE=; h=From:To:Subject; b=z2m1W13s7Y6oMflIZChFD/KvG8EczvC2rz9nJfoih/euCjY18Ddw2TBJ9KGoEXE33 zSK8VQc68LcHCwoPHt8Vl4TnCBXYKvmQnbsRw9zR6J5aM0XY5OnSYuO773kDq9w0dq LUEbIhVT31x5xDCoZKVXG8TXjPpDfRWFV7V+ziwyRrltANiopvfxxitY8DYn6jysdl xRT00OymGIf/C2F1m9hsIGhR72y9E+Mp7tREsb6RU4/Fn41uXRKu0RPoaurA441yFO b8/B1TekyGjulIq/FLfYVogjusPeyJkejQAECSdSupQYAaTXhShCWGrjaupDOCRHPR yesFXZWaTRX2g== From: Francesco Dolcini To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Francesco Dolcini , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Alexander Stein Subject: [PATCH v5 2/4] drm: mxsfb: Add optional DPI output bus-width configuration Date: Thu, 17 Sep 2026 16:00:37 +0200 Message-ID: <20260917140042.118181-3-francesco@dolcini.it> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260917140042.118181-1-francesco@dolcini.it> References: <20260917140042.118181-1-francesco@dolcini.it> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_070055_114842_74AE08EF X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Francesco Dolcini LCDIF programs LCD_DATABUS_WIDTH from the selected media bus format. The format reported by the downstream panel or bridge describes the display input, but it does not describe how the LCDIF data pins are physically wired on the board. These can differ. For example, a 16-bit LCDIF bus can be connected to a 24-bit display by wiring the available color bits to the corresponding display inputs. In that case, using the display's 24-bit format to configure LCDIF selects the wrong data-bus mode and changes the assignment of color bits on the LCD_DATA pins. Read the optional bus-width endpoint property from the LCDIF output port and use it to select the media bus format used to configure LCDIF. This allows the LCDIF bus mode to describe the physical interface independently of the downstream display format. When the property is absent, continue using the format reported by the downstream display device, preserving the previous behavior. The devicetree binding restricts bus-width to 16, 18 or 24; any other value means the devicetree is broken, so fail the probe instead of silently falling back to the previous behavior. Signed-off-by: Francesco Dolcini --- v5: fail probe on invalid bus-width instead of falling back to the previous behavior; factor the property parsing into its own mxsfb_of_bus_fmt() helper. Drop the r-b/t-b tags below since they were given for the previous silent-fallback behavior and for a different code shape; needs re-review. v4: add r-b and t-b tags v3: improve commit message and make it clear that the code assumes that the DT is correct, when the DT contains an invalid property value, the code safely fall-back to the previous behavior v2: use the common bus-width property instead of the legacy interface-pix-fmt Dropped for v5: Reviewed-by: Frank Li Reviewed-by: Alexander Stein Tested-by: Alexander Stein # TQMa6UL[L]x --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 43 +++++++++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 ++ drivers/gpu/drm/mxsfb/mxsfb_kms.c | 12 +++++++++ 3 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 8b4a500347fb..641691fc92c8 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -12,7 +12,10 @@ #include #include #include +#include #include +#include +#include #include #include #include @@ -207,11 +210,41 @@ static void mxsfb_irq_uninstall(struct drm_device *dev) free_irq(mxsfb->irq, dev); } +static int mxsfb_of_bus_fmt(const struct device_node *ep, u32 *bus_format) +{ + u32 bus_width; + int ret; + + ret = of_property_read_u32(ep, "bus-width", &bus_width); + if (ret == -EINVAL) + return 0; + if (ret) + return ret; + + switch (bus_width) { + case 16: + *bus_format = MEDIA_BUS_FMT_RGB565_1X16; + break; + case 18: + *bus_format = MEDIA_BUS_FMT_RGB666_1X18; + break; + case 24: + *bus_format = MEDIA_BUS_FMT_RGB888_1X24; + break; + default: + return -EINVAL; + } + + return 0; +} + static int mxsfb_load(struct drm_device *drm, const struct mxsfb_devdata *devdata) { struct platform_device *pdev = to_platform_device(drm->dev); + struct device_node *np = pdev->dev.of_node; struct mxsfb_drm_private *mxsfb; + struct device_node *ep; int ret; mxsfb = devm_kzalloc(&pdev->dev, sizeof(*mxsfb), GFP_KERNEL); @@ -238,6 +271,16 @@ static int mxsfb_load(struct drm_device *drm, if (IS_ERR(mxsfb->clk_disp_axi)) mxsfb->clk_disp_axi = NULL; + ep = of_graph_get_next_endpoint(np, NULL); + if (ep) { + ret = mxsfb_of_bus_fmt(ep, &mxsfb->bus_format); + of_node_put(ep); + if (ret) { + dev_err(drm->dev, "Invalid bus-width endpoint property\n"); + return ret; + } + } + ret = dma_set_mask_and_coherent(drm->dev, DMA_BIT_MASK(32)); if (ret) return ret; diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h b/drivers/gpu/drm/mxsfb/mxsfb_drv.h index d160d921b25f..bdc47ce5be79 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.h +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.h @@ -46,6 +46,8 @@ struct mxsfb_drm_private { struct drm_connector *connector; struct drm_bridge *bridge; + u32 bus_format; + bool crc_active; }; diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c index d8ebebc5314b..1d78c486d147 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c @@ -386,6 +386,18 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc, if (!bus_format) bus_format = MEDIA_BUS_FMT_RGB888_1X24; + /* + * Prefer the bus format derived from the OF graph endpoint "bus-width" + * property when available. Otherwise, use the bus format reported by + * the downstream bridge or panel. + * + * This supports mismatched display and interface bus widths, such as + * a 24-bit panel connected through an 18-bit interface or an 18-bit + * panel connected through a 24-bit interface. + */ + if (mxsfb->bus_format) + bus_format = mxsfb->bus_format; + mxsfb_crtc_mode_set_nofb(mxsfb, bridge_state, bus_format); /* Write cur_buf as well to avoid an initial corrupt frame */ -- 2.47.3