From: Daniel Machon <daniel.machon@microchip.com>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Steen Hegelund <Steen.Hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
<linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
Date: Fri, 18 Sep 2026 08:50:37 +0200 [thread overview]
Message-ID: <20260918065037.bs2mcha2laf5efg7@DEN-DL-M70577.microsemi.net> (raw)
In-Reply-To: <20260917064736.77354-1-kmehltretter@gmail.com>
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
>
> drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
> index 97f43fd4473f..1af30a358a15 100644
> --- a/drivers/net/ethernet/microchip/vcap/Kconfig
> +++ b/drivers/net/ethernet/microchip/vcap/Kconfig
> @@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
> bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
> depends on KUNIT
> depends on KUNIT=y && VCAP=y && y
> - select DEBUG_FS
> default KUNIT_ALL_TESTS
> help
> This builds unit tests for the VCAP library.
>
> base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
next prev parent reply other threads:[~2026-09-18 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 6:47 [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests Karl Mehltretter
2026-09-18 6:50 ` Daniel Machon [this message]
2026-09-21 7:56 ` David Gow
2026-09-21 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918065037.bs2mcha2laf5efg7@DEN-DL-M70577.microsemi.net \
--to=daniel.machon@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=brendan.higgins@linux.dev \
--cc=davem@davemloft.net \
--cc=david@davidgow.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kmehltretter@gmail.com \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raemoar63@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox