Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Jimenez Carrero <juan@jimenezcarrero.com>
To: rf@opensource.cirrus.com, khalilst@gmail.com
Cc: khalil@rentman.nl, broonie@kernel.org, hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com, patches@opensource.cirrus.com,
	linux-spi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, daniel@zonque.org,
	haojian.zhuang@gmail.com, robert.jarzmik@free.fr
Subject: Re: [PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios
Date: Fri, 18 Sep 2026 13:52:40 +0200	[thread overview]
Message-ID: <20260918115240.29204-1-juan@jimenezcarrero.com> (raw)
In-Reply-To: <a15eae4d-d533-4280-986c-5de90d5fd2e4@opensource.cirrus.com>

On Thu, 17 Sep 2026 14:42:18 +0100, Richard Fitzgerald wrote:
> The latest BIOS (01.06.02) is reported to fix the problem:
> https://bugzilla.kernel.org/show_bug.cgi?id=221064#c23

Thanks, Richard. Confirmed on the same machine as my earlier report:

  HP EliteBook 8 G1i 14 inch, DMI board 8D8A, SKU D75TQET#ABE
  BIOS X91 Ver. 01.05.02 -> X91 Ver. 01.06.02 (dated 07/22/2026)

I dumped the ACPI tables before and after the update. The only change
in Scope (\_SB.PC00.SPI0) is the cs-gpios property:

   "cs-gpios",
  -Package (0x01)
  +Package (0x05)
   {
  +    Zero,
  +    GSPK,
  +    Zero,
  +    Zero,
       Zero
   }

CS0 stays on the native chip select and CS1 becomes GpioIo resource 0
of GSPK, which is the same GPIO that 2/3 installs. Device (GSPK) is
unchanged between the two versions.

On 01.06.02 with an unpatched kernel (7.2.5, no out-of-tree modules,
taint 0) both amplifiers probe, the calibration is applied and the
speakers play. The "cs1 >= max 1" error is gone.

With 2/3 and 3/3 still loaded on 01.06.02, the quirk matches the DMI
entry but returns early because cs < num_chipselect, so the series
does no harm on the fixed firmware. On 01.05.02 it is still needed,
and my earlier Tested-by stands for that case.

One small detail in case there is a v4: the DMI entry's .ident says
"HP EliteBook 8 G1i 16 inch", but board 8D8A is also the 14 inch model
I tested on.

Thanks,
Juan


      reply	other threads:[~2026-09-18 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 19:26 [PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios Khalil
2026-09-01 19:26 ` [PATCH v3 1/3] spi: Preserve preset cs_gpiod in __spi_add_device() Khalil
2026-09-01 19:26 ` [PATCH v3 2/3] platform/x86: serial-multi-instantiate: Fix SPI chip select on platforms with incomplete ACPI cs-gpios Khalil
2026-09-16 21:24   ` Juan Jimenez Carrero
2026-09-01 19:26 ` [PATCH v3 3/3] spi: pxa2xx: Handle clock gating for GPIO chip select devices Khalil
2026-09-16 21:24   ` Juan Jimenez Carrero
2026-09-03  9:21 ` [PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios Richard Fitzgerald
2026-09-11  9:10   ` Juan Jimenez Carrero
2026-09-16 21:23 ` Juan Jimenez Carrero
2026-09-17 13:42   ` Richard Fitzgerald
2026-09-18 11:52     ` Juan Jimenez Carrero [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918115240.29204-1-juan@jimenezcarrero.com \
    --to=juan@jimenezcarrero.com \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=hansg@kernel.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=khalil@rentman.nl \
    --cc=khalilst@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox