From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7C2CC982DA for ; Fri, 18 Sep 2026 13:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=llyAgK4rLGd3YL367jNvPIU26fpmrEy121V33jASlwI=; b=4MLgzwVNvEjpcTS5i6PixGXRJ8 RbvQaAX2oIYxsDhwslstC0TrPfimAv+nNglTzAQOlSSmSEhxIwfkAvTV91oCqwX3BYspp+fr3DwuO M1VlDQ8VHDQu1OyMy45Lj3PqSAnRUbsZSStxdJzAdBSsbd4NoJu3kX5F1wPxbpJO78JmwOWjHznES SsqHfvCtelj3fbFiSuF5mJO7eyNupvxEQg//wL9zsBt/p43w3wkhrOrYPl/mCXABSJ9FOAzEOAbvE rFM84RJ5CVPOSWaep+bCdzpG0J2CVhkmaa/bAd+sJerZVc9dd4kjwU0DQtJFv2+NLRxoOCaADqgKb a8ilU+IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7YVq-0000000EUgY-2wFz; Fri, 18 Sep 2026 13:20:22 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7YVo-0000000EUfP-1QUI; Fri, 18 Sep 2026 13:20:21 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AC89E4D7A; Fri, 18 Sep 2026 15:18:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789737511; bh=mOT+ZZhGP5ccEcxa5D9560p30Tzgnpb1fQq5rAFNPHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pVJEF3zeBamo6zonI09xcQri3fYoyTjGlvpxKQvq8DA1lZUyrBmF3fmlNg0QWBZm6 afftWWvrHEmYx4GaVVvK1jDBAQ+k0yoD15sXk0zXSC/smn8d4sQ8kyFbgMtLr1wyOT +X88e9xf8szv0kV8lYRCDNVlWSRE0OMtfHSWlm0Y= Date: Fri, 18 Sep 2026 16:20:13 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Benjamin Mugnier , Bjorn Andersson , Conor Dooley , Daniel Scally , Fabio Estevam , Frank Li , Geert Uytterhoeven , Heiko Stuebner , Jacopo Mondi , Jacopo Mondi , Jimmy Su , Jonathan Hunter , Konrad Dybcio , Krzysztof Kozlowski , Magnus Damm , Martin Kepplinger , Matthias Fend , Mauro Carvalho Chehab , Michael Riesch , Mikhail Rudenko , Paul Elder , Pengutronix Kernel Team , Quentin Schulz , Richard Acayan , Rob Herring , Sakari Ailus , Sascha Hauer , Svyatoslav Ryhel , Sylvain Petinot , Thierry Reding , Tommaso Merciai , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, Vladimir Zapolskiy , Konrad Dybcio , David Heidelberg Subject: Re: [PATCH v6 2/6] arm64: dts: qcom: Convert to new media orientation definitions Message-ID: <20260918132013.GG59058@killaraus.ideasonboard.com> References: <20260918-kbingham-orientation-v6-0-5e8b1f01be29@ideasonboard.com> <20260918-kbingham-orientation-v6-2-5e8b1f01be29@ideasonboard.com> <178972979131.1723501.9444120486527129452@ping.linuxembedded.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <178972979131.1723501.9444120486527129452@ping.linuxembedded.co.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_062020_525796_E70791D3 X-CRM114-Status: GOOD ( 25.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2026 at 12:09:51PM +0100, Kieran Bingham wrote: > Quoting Kieran Bingham (2026-09-18 11:44:14) > > From: Kieran Bingham > > > > The orientation property for video interface devices now has definitions > > to prevent hardcoded integer values for the enum options. > > > > Update the users throughout the qualcomm device trees to use the new > > definitions. > > > > Reviewed-by: Laurent Pinchart > > Reviewed-by: Vladimir Zapolskiy > > Reviewed-by: Konrad Dybcio > > Reviewed-by: David Heidelberg > > Sashiko has noted that there is another new dts added in dts/qcom since > I wrote this patch. > > I don't want to invalidate the above reviews by adding another change, > so I will send the single update to the new file separately as the core > definitions are already accepted now. > > If someone /really/ wants me to add the change to > arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi in this patch, > please let me know. > > it looks like this: > > ----------- arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi ----------- > index 945127dacc82..f86d3e0d51a6 100644 > @@ -3,10 +3,11 @@ > * Copyright (c) 2022-2024 Jianhua Lu > */ > > #include > #include > +#include > #include > #include > #include > #include "sm8250.dtsi" > #include "pm8150.dtsi" > @@ -571,11 +572,11 @@ camera_front: camera@10 { > reset-gpios = <&tlmm 109 GPIO_ACTIVE_LOW>; > > pinctrl-0 = <&cam_mclk3_default &camera_front_active>; > pinctrl-names = "default"; > > - orientation = <0>; /* Front facing */ > + orientation = ; > rotation = <270>; > > port { > ov8856_front_ep: endpoint { > data-lanes = <1 2>; I don't mind either way, and I think you can keep the existing R-b tags if you add that hunk. > > Signed-off-by: Kieran Bingham > > --- > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 3 ++- > > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 3 ++- > > arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi | 3 ++- > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > index f41ad446a39e..e2b7f1bd05ab 100644 > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -701,7 +702,7 @@ camera@10 { > > pinctrl-0 = <&cam_mclk3_default>; > > pinctrl-names = "default"; > > > > - orientation = <0>; /* Front facing */ > > + orientation = ; > > rotation = <270>; > > > > port { > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > index 218573a97785..3b5f6a29e969 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include "sc8280xp.dtsi" > > @@ -683,7 +684,7 @@ camera@10 { > > > > clocks = <&camcc CAMCC_MCLK3_CLK>; > > > > - orientation = <0>; /* Front facing */ > > + orientation = ; > > > > avdd-supply = <&vreg_l6q>; > > dvdd-supply = <&vreg_l2q>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi > > index b4854801a5f5..7880d85b52fe 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi > > @@ -9,6 +9,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include "sdm670.dtsi" > > @@ -460,7 +461,7 @@ camera@1a { > > pinctrl-names = "default"; > > > > rotation = <270>; > > - orientation = <0>; > > + orientation = ; > > > > port { > > cam_front_endpoint: endpoint { > > -- Regards, Laurent Pinchart