From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>, "Peng Fan" <peng.fan@nxp.com>,
"Deepanshu Kartikey" <kartikey406@gmail.com>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Fan Wu" <fanwu01@zju.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH] media: use assign_bit() where applicable
Date: Fri, 18 Sep 2026 22:17:43 +0800 [thread overview]
Message-ID: <20260918141757.3023034-1-peng.fan@oss.nxp.com> (raw)
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit and their
non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
API.
Done with Coccinelle semantic patch:
// set_bit -> clear_bit => assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- set_bit(bit, addr);
-else
- clear_bit(bit, addr);
+assign_bit(bit, addr, cond);
// clear_bit -> set_bit => assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- clear_bit(bit, addr);
-else
- set_bit(bit, addr);
+assign_bit(bit, addr, !cond);
// __set_bit -> __clear_bit => __assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- __set_bit(bit, addr);
-else
- __clear_bit(bit, addr);
+__assign_bit(bit, addr, cond);
// __clear_bit -> __set_bit => __assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- __clear_bit(bit, addr);
-else
- __set_bit(bit, addr);
+__assign_bit(bit, addr, !cond);
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/media/dvb-frontends/rtl2830.c | 5 +----
drivers/media/dvb-frontends/rtl2832.c | 5 +----
drivers/media/platform/marvell/mcam-core.c | 5 +----
drivers/media/platform/samsung/exynos4-is/fimc-capture.c | 5 +----
4 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/media/dvb-frontends/rtl2830.c b/drivers/media/dvb-frontends/rtl2830.c
index 4c44e2d695f8..fadc12c6d6ae 100644
--- a/drivers/media/dvb-frontends/rtl2830.c
+++ b/drivers/media/dvb-frontends/rtl2830.c
@@ -612,10 +612,7 @@ static int rtl2830_pid_filter(struct dvb_frontend *fe, u8 index, u16 pid, int on
if (pid > 0x1fff || index >= 32)
return 0;
- if (onoff)
- set_bit(index, &dev->filters);
- else
- clear_bit(index, &dev->filters);
+ assign_bit(index, &dev->filters, onoff);
/* enable / disable PIDs */
buf[0] = (dev->filters >> 0) & 0xff;
diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index b31cdb44b383..011c1366e0db 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -986,10 +986,7 @@ static int rtl2832_pid_filter(struct dvb_frontend *fe, u8 index, u16 pid,
if (pid > 0x1fff || index >= 32)
return 0;
- if (onoff)
- set_bit(index, &dev->filters);
- else
- clear_bit(index, &dev->filters);
+ assign_bit(index, &dev->filters, onoff);
/* enable / disable PIDs */
buf[0] = (dev->filters >> 0) & 0xff;
diff --git a/drivers/media/platform/marvell/mcam-core.c b/drivers/media/platform/marvell/mcam-core.c
index 2d0b8b60c509..074b86ae09c0 100644
--- a/drivers/media/platform/marvell/mcam-core.c
+++ b/drivers/media/platform/marvell/mcam-core.c
@@ -252,10 +252,7 @@ static inline int mcam_needs_config(struct mcam_camera *cam)
static void mcam_set_config_needed(struct mcam_camera *cam, int needed)
{
- if (needed)
- set_bit(CF_CONFIG_NEEDED, &cam->flags);
- else
- clear_bit(CF_CONFIG_NEEDED, &cam->flags);
+ assign_bit(CF_CONFIG_NEEDED, &cam->flags, needed);
}
/* ------------------------------------------------------------------- */
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
index d85811f4b8c5..1e34119ee117 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
@@ -997,10 +997,7 @@ static void fimc_capture_mark_jpeg_xfer(struct fimc_ctx *ctx,
ctx->scaler.enabled = !jpeg;
fimc_ctrls_activate(ctx, !jpeg);
- if (jpeg)
- set_bit(ST_CAPT_JPEG, &ctx->fimc_dev->state);
- else
- clear_bit(ST_CAPT_JPEG, &ctx->fimc_dev->state);
+ assign_bit(ST_CAPT_JPEG, &ctx->fimc_dev->state, jpeg);
}
static int __fimc_capture_set_format(struct fimc_dev *fimc,
--
2.51.0
reply other threads:[~2026-09-18 14:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918141757.3023034-1-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=Julia.Lawall@inria.fr \
--cc=alim.akhtar@samsung.com \
--cc=fanwu01@zju.edu.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=kartikey406@gmail.com \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peng.fan@nxp.com \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).