From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96B15C982F0 for ; Mon, 21 Sep 2026 20:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Za9naEHOWE90qDwxxDpS0xl91VPuA8VV517xO2LcsZI=; b=ulmHp1Tm4UDcXkHWh3v15yy4+b DRA9SxwWCKhYD+L9znJjxPqYPIYwcSEkqHslrxEsSZnmBMPkULGKje08fTjKsJsytbGnXouOL0twl aPI7VOkuSl0O4L3GQ8b8wG4BalrqcJ/vc7rVTzrgE7Jr9D1O0LQqQu2Dg+9f+4ZB1bjlSg4l8Hkdc 7rnisCbN41co32EjSOv3fz8tD0WbyvA+wa9xq3iSfeGgJcJnaDiAaBd7EaSOXYoqATcnfiwbAyW7f H4NfqOKqpUNP7XbzZ5v3gyKWnVvr9mGgQTDpES7w8vK4YwHKlqIQ1NvPC9dAO3/0jiI6nMsGNYuJe 9jpIwH5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8khZ-00000003LrT-1mQi; Mon, 21 Sep 2026 20:33:25 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8khQ-00000003Lk6-1P98; Mon, 21 Sep 2026 20:33:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1790022792; bh=R+0ORjkMahdOCQPNUtjC94W9dr82Rbx5na9hVn3u/Ng=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DmHh7oB8N0I6iFYsM/yLTvS9u6vZiXDQVNkQ6JQWkISX7/8YkLi32jUnYQuC0APAA xHJgvcBNTlwEUKDGvY8SCdEAraQUNkB87ulF5+jvGZHshOcB3wS4QhzprTGlEpogZM x8FgB9ZAH/qGpGlOeamxANNLL9xmDVTcrLSvNZjZmN2Xyd66/ktepJBOJGCKEQ9Uua mKK7E6cIFmNblXdJeJAWAJzdcH7+RUqIko8+u8aMqka1pbQa03/cvpS2O5dF5rHm/V USMCNR1SJGyH5KWUCrPuC49UMaWNQrGs9ZPFbYJlrlsxs20loCUEWaNPvO+30UA7hT ytidfkGKyeAJg== Received: from jupiter.universe (unknown [100.64.1.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id 413BB17E0C41; Mon, 21 Sep 2026 22:33:12 +0200 (CEST) Received: by jupiter.universe (Postfix, from userid 1000) id EEB73480031; Mon, 21 Sep 2026 22:33:11 +0200 (CEST) From: Sebastian Reichel Date: Mon, 21 Sep 2026 22:32:47 +0200 Subject: [PATCH v2 4/8] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260921-rockchip-dfi-cleanup-v2-4-43ff34ac8599@collabora.com> References: <20260921-rockchip-dfi-cleanup-v2-0-43ff34ac8599@collabora.com> In-Reply-To: <20260921-rockchip-dfi-cleanup-v2-0-43ff34ac8599@collabora.com> To: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Sascha Hauer Cc: Nicolas Frattaroli , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1817; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=tS8n9fy0LBJivuuQhw0+orcBEclVJquJmZ0El2PFwMU=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGqxlIfN8AICiJVidNsvdIb21QpyjLFYOPgg6 9qMij7pt/NHAIkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJqsZSHAAoJENju1/PI O/qaH1AP/RFHTpW/TW6nZa9Wux+qImLvlT7+QAO0/A9qepx4hqt1BRaHVmF/9+GTpNRc2XMW04R i4BsfDf/ryZHWHFsXa1ppMd/Zq0wHvGWciOX4e1euF64KXEAg9aTN56W9dIdTb/2v1+io2XaGd6 yfP4/TNGtZKIEW/1+lCVTMOTs8YtgqnY8OpVhZ1leDm9mWC9k/ZwDPRIE4lTFEjGtDkdYntw6UO 3D2IkmEWLK6d5u1HesCtA7Fbr4jLn5Xd3tTKHa1mQIT56+R3FypRR8/PrpT7O41oaZ4QgCLtmcC PQCc+FcN8OZNuLGsdNwf0GFV3TNuQV6RJyuo5gn80tqh529JO6h3G2UKCkmTL4gWFI+inTWifL7 BUtkoVVj8UTK/1iqFpO7pBGnRmyqO7PZVQr8WTDASar77JyS9C01NwS5KQFpYaAI96uDhFxGCPa gcarMHPMWw+kUAoVTtXn2jxqJv5Xdx2SN24FjA57ppV3afDeVr3Lix5BqUTkSc3s8aKb/mXO+dj cL4NhbEkHvlRCEUJq7khtr+2rMe0RCYBuMlFyDGD735TFxvPHnOXmGy9ak9XbHsfB+WtLgeaPbR XkhHHz+7j3JY45Oyi1kqg85f3j2Zsl42GpMqnPR3qJvqvs/uOjd3dWGDfx4vqL9q5tm1Ibm0ZL0 LtNPY7WeoFW5URyn+ZD0tTw== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260921_133316_539946_C603C94E X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nicolas Frattaroli The perf subsystem's PERF_PMU_CAP_NO_INTERRUPT is a bit of a misnomer.[1] Instead of meaning that the PMU has no interrupt, it actually means that the PMU does support sampling. On CPU PMUs, this is equivalent to not having an interrupt, but for uncore PMUs like the rockchip-dfi PMU is, no meaningful sample data could ever be generated regardless of whether or not there is an interrupt, as it is not a CPU. Since rockchip-dfi doesn't seem to make use of the interrupt the DT provides it with anyway, this was probably never a confusion that existed in this case; the capability flag was likely just forgotten. Add PERF_PMU_CAP_NO_INTERRUPT to the set flags for the pmu struct's capabilities member, so that the perf core knows about this limitation. Fixes: 4d586b5724d3 ("PM / devfreq: rockchip-dfi: Add perf support") Link: https://lore.kernel.org/all/20250619140442.GH1613376@noisy.programming.kicks-ass.net/ [1] Signed-off-by: Nicolas Frattaroli Signed-off-by: Sebastian Reichel --- drivers/devfreq/event/rockchip-dfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c index 5339616f7ca6..dd9edfd6a674 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -646,7 +646,7 @@ static int rockchip_ddr_perf_init(struct rockchip_dfi *dfi) seqlock_init(&dfi->count_seqlock); pmu->module = THIS_MODULE; - pmu->capabilities = PERF_PMU_CAP_NO_EXCLUDE; + pmu->capabilities = PERF_PMU_CAP_NO_EXCLUDE | PERF_PMU_CAP_NO_INTERRUPT; pmu->task_ctx_nr = perf_invalid_context; pmu->attr_groups = attr_groups; pmu->event_init = rockchip_ddr_perf_event_init; -- 2.53.0