From: "Richard Genoud (TI)" <richard.genoud@bootlin.com>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Udit Kumar <u-kumar1@ti.com>,
Abhash Kumar <a-kumar2@ti.com>, Beleswar Padhi <b-padhi@ti.com>,
Thomas Richard <thomas.richard@bootlin.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Richard Genoud <richard.genoud@bootlin.com>
Subject: [PATCH v4 2/7] remoteproc: k3: skip mapping firewalled lpm-metadata memory region
Date: Mon, 21 Sep 2026 16:53:20 +0200 [thread overview]
Message-ID: <20260921145325.300025-3-richard.genoud@bootlin.com> (raw)
In-Reply-To: <20260921145325.300025-1-richard.genoud@bootlin.com>
The region lpm-metadata is firewalled by TIFS on Jacinto devices, so it
should not be mapped to prevent speculative access crashes
Just skip this memory region during initialization.
Signed-off-by: Richard Genoud (TI) <richard.genoud@bootlin.com>
---
drivers/remoteproc/ti_k3_common.c | 36 +++++++++++++++++++++----------
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_common.c
index 3cb8ae5d72f6..5158e5e7c816 100644
--- a/drivers/remoteproc/ti_k3_common.c
+++ b/drivers/remoteproc/ti_k3_common.c
@@ -471,7 +471,7 @@ int k3_reserved_mem_init(struct k3_rproc *kproc)
struct device *dev = kproc->dev;
struct device_node *np = dev->of_node;
int num_rmems;
- int ret, i;
+ int ret, i, j;
num_rmems = of_reserved_mem_region_count(np);
if (num_rmems < 0) {
@@ -501,30 +501,44 @@ int k3_reserved_mem_init(struct k3_rproc *kproc)
return -ENOMEM;
/* use remaining reserved memory regions for static carveouts */
- for (i = 0; i < num_rmems; i++) {
+ for (j = 0, i = 0; i < num_rmems; i++) {
struct resource res;
+ const char *region_name;
ret = of_reserved_mem_region_to_resource(np, i + 1, &res);
if (ret)
return ret;
- kproc->rmem[i].bus_addr = res.start;
+ ret = of_property_read_string_index(np, "memory-region-names",
+ i + 1, ®ion_name);
+ /*
+ * lpm-metadata is a firewalled region accessible only by TIFS.
+ * Skip mapping it to avoid speculative access crashes.
+ */
+ if (!ret && !strcmp(region_name, "lpm-metadata")) {
+ dev_dbg(dev, "Skipping firewalled memory region %s @0x%x\n",
+ region_name, (u32)res.start);
+ continue;
+ }
+
+ kproc->rmem[j].bus_addr = res.start;
/* 64-bit address regions currently not supported */
- kproc->rmem[i].dev_addr = (u32)res.start;
- kproc->rmem[i].size = resource_size(&res);
- kproc->rmem[i].cpu_addr = devm_ioremap_resource_wc(dev, &res);
- if (IS_ERR(kproc->rmem[i].cpu_addr)) {
+ kproc->rmem[j].dev_addr = (u32)res.start;
+ kproc->rmem[j].size = resource_size(&res);
+ kproc->rmem[j].cpu_addr = devm_ioremap_resource_wc(dev, &res);
+ if (IS_ERR(kproc->rmem[j].cpu_addr)) {
dev_err(dev, "failed to map reserved memory#%d at %pR\n",
i + 1, &res);
return -ENOMEM;
}
dev_dbg(dev, "reserved memory%d: bus addr %pa size 0x%zx va %p da 0x%x\n",
- i + 1, &kproc->rmem[i].bus_addr,
- kproc->rmem[i].size, kproc->rmem[i].cpu_addr,
- kproc->rmem[i].dev_addr);
+ j + 1, &kproc->rmem[j].bus_addr,
+ kproc->rmem[j].size, kproc->rmem[j].cpu_addr,
+ kproc->rmem[j].dev_addr);
+ j++;
}
- kproc->num_rmems = num_rmems;
+ kproc->num_rmems = j;
return 0;
}
next prev parent reply other threads:[~2026-09-21 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 14:53 [PATCH v4 0/7] dts: ti: k3-j7: Reserve memory for LPM metadata Richard Genoud (TI)
2026-09-21 14:53 ` [PATCH v4 1/7] dt-bindings: remoteproc: k3-r5f: Add Jacinto LPM memory region Richard Genoud (TI)
2026-09-22 16:02 ` Rob Herring (Arm)
2026-09-21 14:53 ` Richard Genoud (TI) [this message]
2026-09-21 14:53 ` [PATCH v4 3/7] arm64: dts: ti: k3-j7200-ti-ipc-firmware: Reserve memory for LPM metadata Richard Genoud (TI)
2026-09-21 14:53 ` [PATCH v4 4/7] arm64: dts: ti: k3-j721s2-ti-ipc-firmware: " Richard Genoud (TI)
2026-09-21 14:53 ` [PATCH v4 5/7] arm64: dts: ti: k3-j784s4-ti-ipc-firmware: " Richard Genoud (TI)
2026-09-21 14:53 ` [PATCH v4 6/7] arm64: dts: ti: k3-j722s-ti-ipc-firmware: " Richard Genoud (TI)
2026-09-21 14:53 ` [PATCH v4 7/7] arm64: dts: ti: k3-j742s2-ti-ipc-firmware: " Richard Genoud (TI)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921145325.300025-3-richard.genoud@bootlin.com \
--to=richard.genoud@bootlin.com \
--cc=a-kumar2@ti.com \
--cc=b-padhi@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox