From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AB1BC982FA for ; Tue, 22 Sep 2026 07:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m6RhWUuU6In2Zao3hDUD1vpbLTCibSWwKZ0cfNwJQ3I=; b=aNHRO4gGI6EP3hwefQhgcKhy/T g0hYB6KFSClfRMmpKBhbVkNk/NKsPoMnLJTk7M7hrgJBkVfEfFyIuBHIDbzUjEI8XmdRJ9Prfujol xVOBee8gZX0RIP2/eFZnr1IYAYGV6wgz1acnA0D0LqNrOXNpSRBy3oIYl9wHitJHJYiHhwNSA/ITn z/Nme01LulNwUya5xjCnzSU+NnV8CrQ+CdsuENSnqc+8F9JqqjD4SBurSvFB1tErVvt/3v2M6jQdO EZHrDOEk08AI/eQP4U1hatK3u2K1bqsQpATaVggTri89m7EQresFf809ozokJ5yRJdJvbEofJPXtr 6KQQB+vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8v8J-00000004YTj-1VTM; Tue, 22 Sep 2026 07:41:43 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8v8I-00000004YTU-3NNq for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2026 07:41:42 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 60930410BC; Tue, 22 Sep 2026 07:41:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D291F000FF; Tue, 22 Sep 2026 07:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790062902; bh=m6RhWUuU6In2Zao3hDUD1vpbLTCibSWwKZ0cfNwJQ3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=i5V7onsuosKcdKoiqRfPOCnWfZ2CiYRXzhjx9nFZuIUX+sft49fNq66YfjbzPgq6f 8lw7XLrEwOV2fvWwZAgMpybUwJtpfXNhXlPZA7p3pLJ318DJ1P0WdpsvJZFQM3+vYR Lin11/XNWefPyfz0/1PHvpM5eyLTgL6dnaZdXjjoTpy+68ehe1u4fANmm/mL0ETOGr hKbAF2A67GyJ7vzF1zmKywYv6t8tH5OymhfIboRGqVvzhLKFYwzZtPdKN7cq9AhFLG g5weevg3I2MReX3F1PGBO51j4hFsbnafnXd9hK/X6cqaCLoZUVYFgDYlGpfzxxjFcE lU+0A80KquMZQ== Date: Tue, 22 Sep 2026 08:41:37 +0100 From: Lee Jones To: Guangshuo Li Cc: Linus Walleij , Samuel Ortiz , Mattias Wallin , Ludovic Barre , Alexandre Torgue , Julien Delacou , linux-arm-kernel@lists.infradead.org, mfd@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mfd: ab8500: fix child device leaks on probe failure Message-ID: <20260922074137.GG2348773@google.com> References: <20260921110909.370945-1-lgs201920130244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260921110909.370945-1-lgs201920130244@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 21 Sep 2026, Guangshuo Li wrote: > ab8500_probe() registers MFD child devices before completing the > remaining device initialization. > > On AB8540, the main MFD device batch may be registered successfully > before registration of the cut-specific batch fails. In that case, > the probe returns without removing the child devices registered by > the earlier mfd_add_devices() call. > > The same issue occurs when sysfs group creation fails after the MFD > children have been registered. Since the probe returns an error, there > is no later teardown path to unregister those devices. > > Call mfd_remove_devices() on these error paths so that MFD child > devices successfully registered earlier in the probe are properly > unregistered and released. > > The issue was identified by a static analysis tool I developed and > confirmed by manual review. > > Fixes: cca69b67b3ba ("mfd: Export ab8500 chip id to sysfs") > Fixes: 9c717cf3fa16 ("mfd: ab8500-core: Add device for new RTC version for AB8540 cut2") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/mfd/ab8500-core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c > index f0bc0b5a6f4a..e675223b6023 100644 > --- a/drivers/mfd/ab8500-core.c > +++ b/drivers/mfd/ab8500-core.c > @@ -1220,8 +1220,10 @@ static int ab8500_probe(struct platform_device *pdev) > ret = mfd_add_devices(ab8500->dev, 0, ab8500_devs, > ARRAY_SIZE(ab8500_devs), NULL, > 0, ab8500->domain); > - if (ret) > + if (ret) { > + mfd_remove_devices(ab8500->dev); What about switching to devm_*() a.k.a. managed resources? > return ret; > + } > > /* Add battery management devices */ > ret = mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs, > @@ -1243,8 +1245,10 @@ static int ab8500_probe(struct platform_device *pdev) > ret = sysfs_create_group(&ab8500->dev->kobj, > &ab8505_attr_group); > > - if (ret) > + if (ret) { > dev_err(ab8500->dev, "error creating sysfs entries\n"); > + mfd_remove_devices(ab8500->dev); > + } > > return ret; > } > -- > 2.43.0 > -- Lee Jones