From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A576C982FF for ; Tue, 22 Sep 2026 08:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jHvRFtQyx9UQ53om8i4AUQfufcwc3sWn9Gux2Mdm/VQ=; b=HIJxzWyn8R5Mf/9OVS4RQWTnEU VdYFukGEV2duOb7xsqhYRpc6KH8kIbw7xtRTTQaZ2j0gxtxC9Zgh820uX+4gb3HJyNxlrcazKOQwx ZplhGqGlvh6dBIaCxqoFJEyAMxwSPRSiX5vY20fq5oOhlThe4W1S3citbD6UXizmftss4S9FtbRyv vnw0UZf6t5D/+uDLrrdyBSEfca17Cz+105KSN27yjPLzbZYrzMkEIuaH1dFd3Vh510MW87KRlY63h VK8qisDLKyAXohmkGruGNyU60MnvdZQJyXreOtV0Vu13YhtVBjrbGr/uCGRL/AXnNrojWBfa9f2Yj W9ir9sIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8wIL-00000004mrT-07iF; Tue, 22 Sep 2026 08:56:09 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8wIJ-00000004mqb-3I0t for linux-arm-kernel@bombadil.infradead.org; Tue, 22 Sep 2026 08:56:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=jHvRFtQyx9UQ53om8i4AUQfufcwc3sWn9Gux2Mdm/VQ=; b=CPPwvpoQNWEJp0CvKpPiG1lZCf h7oIiYZKGfCO3q9dBwhybovgqc3ylkgUbVQupmR2hpMqKljnCqlfSzNFl38bLUy2+V65DyhT6isIj Uk8wyx1hQpGZVGNZY71ISDuORDddcKA2rNtivZ1msJq+t1f0qOoBRZzwKbKAvKUSsEk8g1I5VYoO6 8bAbQBxGaSkDA6dqUY4sFF5iJbwlS2sJj2E8k/ByIbaSI1n0ShWWPCXRUobmSiYEyT8V7nSHNZikE 36sZL9dTdmh2U1bTQGiQaySuTpLutjLrsAie2W+sYMHeKbBw5oi9E1Wm8CtcledBpuE0DyfYebdA0 L7B0DsJg==; Received: from mail-wm2-x11.google.com ([2a00:1450:4864:31::11]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x8wIG-0000000DJFS-3RWU for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2026 08:56:06 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49e6baf77afso1733315e9.2 for ; Tue, 22 Sep 2026 01:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790067363; x=1790672163; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jHvRFtQyx9UQ53om8i4AUQfufcwc3sWn9Gux2Mdm/VQ=; b=mIYYxSmZaBDzaEVFekMP7hHr7y8hp7q8/HQ0H1iNnXFACznK5D2UmPyq6hi9yKeXBm fwVZyE2UGmMcZRIE8qnHyOWHBdli4YEB3zxqowfPsJ3dm+DnBDoED7oNyLIopL22XGXg OJifm0ED6ajNyn/rfmGb63NE3GTfLcSK3yCSVNZTfmXzO1IWXT/5RmhaTkDSz31ScF1L Q4xJD2VNAA+vjVCUuAh1ONX1bZ1+iwc/zvKl1T7k3nndR2htVq/JvuCpXp6UlMT3Bj4X qNiqZKOzvQKoHRZNPNk9R8vguj+bctGLCMzz+76D4nzZ6oIdEGfVQuit4gH3o4BSGwMN psKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790067363; x=1790672163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jHvRFtQyx9UQ53om8i4AUQfufcwc3sWn9Gux2Mdm/VQ=; b=Jfm4XHqWvtpBZceoUDDX67CGjvAg/+unqRJJhbJbtTb3sBaG3PK12l6y99jaq6rWAA 4Aqvzswyr/+X4MJOYgbMlXlhUY5sAtv+ZFjxirp659Y27p+O9ARBfMuN8LPyi/XgcRW7 Cs4F4cLUuWHvO9rJ8s0kql3Gs8Y6fpodZPNcQf3dsK6KQUxDN+PJVOi0Du4DyhX1bnBw yT2mv1sVj8REtzyMHJeQ8NKa/ZU/OdsOdAP0dlPr5TmNp4vreZd0mtguSYW+4TRw34US YJraTfCwq/0ji+Xtz091K9jP9bCFTwsBnwC8/qP5wI80eMg+6QtGQrFCme6fz7C1KOSS 1rhg== X-Forwarded-Encrypted: i=1; AKwUvBy9q5sJyf2bVXuPILtoVbIQ/xrbQNCjVBZBk4wM3LfoRvhqMB6vA3ya32eGpxbNQbRs9//SU62vI9sLRRBTICZF@lists.infradead.org X-Gm-Message-State: AFuF++lYkudcuahxiH9WVxyOiUaLttuPu2RVftEPac5YAP0cqzhjb2p0 1qRr+n7nBiQaJzhbWwVNPlfTHuFe0bpSbTOUToKLiNyNz1JHPa/ONEry X-Gm-Gg: AYBFou1XQUPRz7wh73CMSAs3GT4w3DKaO0fkKSznqiqAZkDKkJQyIv9wqgSXRlGLfS8 lk8f1kvQY+SxVrpC79wPIE4Ta8SKDY5CfXv7uDxyDmoU2UcyDkLANWi9qIoGbhhkp/kgw70Lmty 03hJh8GVSDalWx9BA2NK3XQLgNHD/WiNMGJPCEJZfwB/DE4Zrw7YgsNuvC9oThaTfBcSYbDp/DK /cFyS1aleHCSRvoxg8qiLVuV9b6TD/LBRTTTrbCKcoJlmXjgGkACU9vwKS41qs0rNHX0E5BY/4j AKrfiYXPMJQa2bm0HGJvj6EFDy+ALLvlhN+jVchbLPSGrbJE2yYI70IXb8hG7qCcYEC7uvOy+LW Kqkjjds48oAtzFzfsPEk/kGl1BD1a6tclPbCSqoUNTxGM1Nom/UVnecBRi0L/o9C4lmhCCvFcRe NxwuwdS3m9xESO8XC0I6GKEcnHn4WV7Q8SDwc8ywiIrlvcztN8l9SYoYXh6ROZm6xz9qOm6a5Ya Ysqzu3K0WbhYlUSQTcIzxlU0JY1d39vVKju0hEYcLLQE6Jty2yo/EEzr5zRHDvAbz3nz5Y0uI4l c8M= X-Received: by 2002:a05:600c:1c13:b0:49e:7186:f36e with SMTP id 5b1f17b1804b1-49fc7dc1e75mr211705895e9.1.1790067363190; Tue, 22 Sep 2026 01:56:03 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B80530056971C6280202175.dsl.pool.telekom.hu. [2001:4c4e:1b80:5300:5697:1c62:8020:2175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4886277e611sm3538781f8f.18.2026.09.22.01.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 01:56:02 -0700 (PDT) From: Igor Paunovic To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner Cc: Igor Paunovic , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Hugo , Robert Foss , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , Guangshuo Li , =?UTF-8?q?H=C3=BCseyin=20BIYIK?= , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/11] accel/rocket: restore the NPU clock boot rate before powering the cores down Date: Tue, 22 Sep 2026 10:55:37 +0200 Message-ID: <20260922085537.53363-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260922081326.B46651F000FF@smtp.kernel.org> References: <20260922080114.44662-1-royalnet026@gmail.com> <20260922080114.44662-9-royalnet026@gmail.com> <20260922081326.B46651F000FF@smtp.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260922_095605_108850_D726C44E X-CRM114-Status: GOOD ( 11.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On the shutdown question from the Sashiko review of this patch: The gap is real, but it predates this patch. The driver in drm-misc-next has no .shutdown callback at all, so a reboot or kexec with a job in flight already leaves the cores running today. The callback added here takes the devfreq device down and puts the clock back to its boot rate; it does not stop, drain or reset the cores. Quiescing the cores on shutdown (stopping the schedulers and resetting the cores through rocket_core_reset()) is part of the same teardown work as the use-after-free under "Not done" in the cover letter, where a core is unbound while clients submit: both need the driver to stop its schedulers and cores while files are still open. I would rather fix both in one follow-up, once Tomeu has said which way he wants the teardown to go. Igor