From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C6F2C98304 for ; Wed, 23 Sep 2026 16:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m8DBmCwTPj1HLJxixk1IybieKhVRtaJzcM/QTZMWWjU=; b=PRbKp57Dlp0sGCCI59+/sPDYly fBQjo5LX143EaJN+r7hDhMlRRLvW6usUjRA0WHqeCleqcnfyhENJB0TFOPxL6VNu9oh4sWmAxs3k+ GdR/tksWysKdyCnFZpX0thutP+mFPXXY62I4fZHAarPbg4kMErPmd7Y7EfhwuuONS6Uk8FunJDR72 GyL3kB/mSLRdxNuy5VFRE6VfEZ4K9x2VHdPqDDhDfksygep+kATDG6QPio9Y7o8pArS6Q9BIxbaSr XYxQU1Iqexiawr6p94vGidbEoJfRNldZi755ePT+QMOWel40W4aKMpnPY/0GyQuIQIvE6SSu8ZBbB pO3YhONQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9Py3-00000008tEJ-3Xv0; Wed, 23 Sep 2026 16:37:11 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9Py1-00000008tDz-0ka0; Wed, 23 Sep 2026 16:37:09 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9CF2E406AA; Wed, 23 Sep 2026 16:37:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 318FC1F00898; Wed, 23 Sep 2026 16:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790181428; bh=m8DBmCwTPj1HLJxixk1IybieKhVRtaJzcM/QTZMWWjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OQf4pIblBoaTwNI1vgYOnKhNp/sI31yk//Xw9BqFUy7G/htBaC1NWTmeOya/KJSKj K/NGiYIvAia/lMUsHtjNHNqpTfO9nq7hthRnvWANp0ndLdh59OVduYheLv3N+uZ/XC nOWOeHDaKX7dly2b5WUSdcmPgt4b8tXszQwP+xye9ctzkZGhP60mIBypeIeqjq2H7A /3Lnb0i65OdNrEN8SFXtvowiX4I66P+1EVPVHx4+F2HLUpCoya2FenCeBqg+xrgdgx M1TfReFrPG/QDzCLMNMCX0ZAaWQ+8TjhgNMiRAKgqhFW47l7p+9gw22AIaUiyhqRkK pku6EJq0GyryQ== Date: Wed, 23 Sep 2026 17:37:04 +0100 From: Conor Dooley To: Sander Speetjens Cc: Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Jonathan Bell , Stefan Wahren , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/2] dt-bindings: rtc: Add property for Raspberry Pi 5 RTC Message-ID: <20260923-browbeat-judgingly-b047721f5cb3@spud> References: <20260923131323.1099979-1-sander.speetjens@gmail.com> <20260923131323.1099979-2-sander.speetjens@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JCSrJm94KekIipH6" Content-Disposition: inline In-Reply-To: <20260923131323.1099979-2-sander.speetjens@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --JCSrJm94KekIipH6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2026 at 03:13:22PM +0200, Sander Speetjens wrote: > The Raspberry Pi 5 has a built-in RTC that can be battery-backed > via the VBAT pin. When a rechargeable coin cell is used, the > hardware requires a trickle-charge voltage to keep the battery > topped up. >=20 > Expose the trickle-voltage-millivolt DT property so the driver can > program the correct charge voltage for board specific configurations with > the attached battery. >=20 > Signed-off-by: Sander Speetjens > --- > V3 -> V4: Add a reff to uint32 >=20 > V2 -> V3: Fixed the firmware property naming >=20 > V1 -> V2: As discussed with Krzysztof Kozlowski, this property is folded = into > the existing raspberrypi,bcm2835-firmware properties. >=20 > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm283= 5-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm= 2835-firmware.yaml > index 983ea80eaec9..9349fc8908a5 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmw= are.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmw= are.yaml > @@ -133,6 +133,13 @@ properties: > required: > - compatible > =20 > + trickle-voltage-millivolt: > + allOf: > + - $ref: /schemas/rtc/rtc.yaml#/properties/trickle-voltage-millivolt > + - $ref: /schemas/types.yaml#/definitions/uint32 Is this actually needed? Shouldn't the type of uint32 come from the same source that the type in rtc.yaml does? Or is this missing in dt-schema? > + - minimum: 1300 > + maximum: 5000 > + > required: > - compatible > - mboxes > @@ -144,6 +151,7 @@ examples: > firmware { > compatible =3D "raspberrypi,bcm2835-firmware", "simple-mfd"; > mboxes =3D <&mailbox>; > + trickle-voltage-millivolt =3D <3300>; > =20 > firmware_clocks: clocks { > compatible =3D "raspberrypi,firmware-clocks"; > --=20 > 2.55.0 >=20 --JCSrJm94KekIipH6 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCarQAMAAKCRB4tDGHoIJi 0uyDAQCECFdvo/mCsj8XGZ3LnWxt/mRzZS/C+eKt/t7T7Cvr2wD/WTdqT56+5e32 CI1NMazHWbLAWGdFQqbYmY5B9BJXrAo= =FVJW -----END PGP SIGNATURE----- --JCSrJm94KekIipH6--