From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15227C98304 for ; Wed, 23 Sep 2026 15:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZRec4Y9W6ELtgC6hEwcMUks6eDmdzxDe4O7gdt/GoFo=; b=AsOBsGmcCdTcCofSB9nbngJbHu y/uHzJ7B8FrxS8eLOKrTqeOych5V/XhM2J0Ya5x+IDu1pVe8A9+nkp25v1QVu21yX1qJQYTBwueqb +I/u4/znp5/5NkCJ2FNAfrXMHZA/HTL8FGxi+zX5wluo6kGyR9vkUGFUhQ7TF8hvcSmGYMq2RFN4G W/VJJzvOIPEHPib/b14qPpjEiiAeIZ0uZahSNMNiNFqLvboxDZz1TgxfGXgLVQ220YA6SzpXPqodn 2/Pnd6uYgOqsOboI2PlFlyRMFvD76rkrgPfb7kdlS/UPtDM2Oudhwrks7Ccd+3gky2N8wiEbp9Umk 7zTg+ipg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9PIT-00000008oR7-3Rb5; Wed, 23 Sep 2026 15:54:13 +0000 Received: from mgamail.intel.com ([192.198.163.16]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9PIL-00000008oMY-1K1a; Wed, 23 Sep 2026 15:54:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790178845; x=1821714845; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u/EwzTM/NnzSfEVRVlTGSUu5KUBYwA6lJMr21sRdsVY=; b=JrR0eVe1xAoebPebzsuaFaVa17lLUs6FBwbRJ1uvkyIXCVilQkXZRug1 Mk3nJmRwhQeYxacxm1Sr5WqzEoGhWdNwqeRB95t4lXmvnN32KYQe5e4Qt ow08rmk5FSL7rslNBmJJelZ4qhmFYDaIOQ2tizSSfx8oPv3Rb/hghzaLC qt1dMHDsFVdMSu3FZYtp67iinLCW1Vub4kI0pK2sThBLYkI3icLzJtaIU b9YQXY6nSy5AbqIV8kZ859TEqwlidxiKU2PGQfG8s0w7YrfSq+ftTrhIZ S8I00NN4DrSnTwNX6gwhdyutAKFypNlOnONTKD7vmu5dZkt1WmchC0VOm g==; X-CSE-ConnectionGUID: uKYBmXKwTqKY4mqen9XiRQ== X-CSE-MsgGUID: 9/9FJQbjSKucsHwTf67LpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11914"; a="78445062" X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="78445062" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 08:54:03 -0700 X-CSE-ConnectionGUID: 7lue524bROaPLXzmdodnwA== X-CSE-MsgGUID: 36FTiqfuQTOcmIIrMf9pGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="4756769" Received: from igk-lkp-server01.igk.intel.com (HELO 1bbc298b9a73) ([10.211.93.152]) by fmviesa011.fm.intel.com with ESMTP; 23 Sep 2026 08:54:00 -0700 Received: from kbuild by 1bbc298b9a73 with local (Exim 4.98.2) (envelope-from ) id 1x9PIA-000000000j5-0Jdb; Wed, 23 Sep 2026 15:53:54 +0000 Date: Wed, 23 Sep 2026 17:53:25 +0200 From: kernel test robot To: Coia Prant , Heiko Stuebner , Maxime Chevallier , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: oe-kbuild-all@lists.linux.dev, Sebastian Reichel , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coia Prant Subject: Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails Message-ID: <202609231728.boP5N9Xr-lkp@intel.com> References: <20260919174223.2356964-1-coiaprant@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260919174223.2356964-1-coiaprant@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260923_085405_530283_C6EB07BC X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Coia, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Coia-Prant/net-ethernet-stmmac-dwmac-rk-fix-bulk-clock-leak-when-the-PHY-clock-fails/20260920-014223 base: net/main patch link: https://lore.kernel.org/r/20260919174223.2356964-1-coiaprant%40gmail.com patch subject: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260923/202609231728.boP5N9Xr-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 16.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260923/202609231728.boP5N9Xr-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202609231728.boP5N9Xr-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c: In function 'gmac_clk_enable': >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1165:25: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 1165 | if (ret) | ^~ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1168:33: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 1168 | return ret; | ^~~~~~ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c: At top level: >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:11: error: expected identifier or '(' before 'else' 1177 | } else { | ^~~~ >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1189:9: error: expected identifier or '(' before 'return' 1189 | return 0; | ^~~~~~ >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1190:1: error: expected identifier or '(' before '}' token 1190 | } | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c: In function 'gmac_clk_enable': >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:9: warning: control reaches end of non-void function [-Wreturn-type] 1177 | } else { | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c: At top level: >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:199:12: warning: 'rk_gate_rmii_clock' defined but not used [-Wunused-function] 199 | static int rk_gate_rmii_clock(struct rk_priv_data *bsp_priv) | ^~~~~~~~~~~~~~~~~~ vim +1177 drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c 7ad269ea1a2b7d Roger Chen 2014-12-29 1152 7ad269ea1a2b7d Roger Chen 2014-12-29 1153 static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable) 7ad269ea1a2b7d Roger Chen 2014-12-29 1154 { ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1155 int ret; 7ad269ea1a2b7d Roger Chen 2014-12-29 1156 7ad269ea1a2b7d Roger Chen 2014-12-29 1157 if (enable) { 7ad269ea1a2b7d Roger Chen 2014-12-29 1158 if (!bsp_priv->clk_enabled) { ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1159 ret = clk_bulk_prepare_enable(bsp_priv->num_clks, ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1160 bsp_priv->clks); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1161 if (ret) ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1162 return ret; 7ad269ea1a2b7d Roger Chen 2014-12-29 1163 ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1164 ret = clk_prepare_enable(bsp_priv->clk_phy); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 @1165 if (ret) cb278e6780d874 Coia Prant 2026-09-20 1166 clk_bulk_disable_unprepare(bsp_priv->num_clks, cb278e6780d874 Coia Prant 2026-09-20 1167 bsp_priv->clks); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1168 return ret; cb278e6780d874 Coia Prant 2026-09-20 1169 } 23c94d63a7e395 David Wu 2018-06-28 1170 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1171) rk_configure_io_clksel(bsp_priv); 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1172) rk_ungate_rmii_clock(bsp_priv); 2f2b60a0ec2826 David Wu 2022-08-30 1173 7ad269ea1a2b7d Roger Chen 2014-12-29 1174 mdelay(5); 7ad269ea1a2b7d Roger Chen 2014-12-29 1175 bsp_priv->clk_enabled = true; 7ad269ea1a2b7d Roger Chen 2014-12-29 1176 } 7ad269ea1a2b7d Roger Chen 2014-12-29 @1177 } else { 7ad269ea1a2b7d Roger Chen 2014-12-29 1178 if (bsp_priv->clk_enabled) { 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1179) rk_gate_rmii_clock(bsp_priv); 7f864458e9a6d2 Sebastian Reichel 2025-10-14 1180 ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1181 clk_bulk_disable_unprepare(bsp_priv->num_clks, ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1182 bsp_priv->clks); fecd4d7eef8b21 David Wu 2017-08-10 1183 clk_disable_unprepare(bsp_priv->clk_phy); fecd4d7eef8b21 David Wu 2017-08-10 1184 7ad269ea1a2b7d Roger Chen 2014-12-29 1185 bsp_priv->clk_enabled = false; 7ad269ea1a2b7d Roger Chen 2014-12-29 1186 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1187 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1188 7ad269ea1a2b7d Roger Chen 2014-12-29 @1189 return 0; 7ad269ea1a2b7d Roger Chen 2014-12-29 @1190 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1191 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki