From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B034C98314 for ; Thu, 24 Sep 2026 13:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IMJke5iOLDnWkz3jQXth+/pn/WHEhS9+3RUVCj3fdzw=; b=hXarKJ+YQ/Sq35KXicIeFEtNCx /L7CHfGIjH5PkMQdYr/WS9AiizX7YnsaRQQY6BFRrkCB9JV6D2rqKEbjYCgYMDGUG2xGoENidqZxv 7r1tz1x7fnno18ekFhScsXq5P9bHasrKqQBQpZGrR6a59ApAxqhp6YZ9mJcInt4sNW0jEcgD3QgPI ROJ/9+pQbLLf9M1F3QCbkJ3vNRNawNyBJrZGHtbgnMpbqhgaVhZK918lj7UpjNRTiluD1SMdNlMVh qF0+X5qt5+CUAPI3kPb0GRGiLxdzes9pjD9C6i0FcZmvKdZijdxpvSrmUzivQPKfnPe9MVzizPETe Mg3Vecrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9jPO-0000000B4Z6-2pr9; Thu, 24 Sep 2026 13:22:42 +0000 Received: from mail-wm2-f13.google.com ([74.125.225.141]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9jP6-0000000B4Sz-0huz for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2026 13:22:26 +0000 Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49cd38e0e5dso26025595e9.2 for ; Thu, 24 Sep 2026 06:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790256142; x=1790860942; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IMJke5iOLDnWkz3jQXth+/pn/WHEhS9+3RUVCj3fdzw=; b=UeiwUUHWlv3QcwuqILtLTIkqOobJxQyO8x39NoVmTEdEdF+o3BbO6Sv+BvKodimGT+ pWEWvbWINxtbRl9ZlLzN73BlmJMlT26i6ZMM7/fzxHo3MZIadkW9UmgEfxIZpoAt4PBj vyXrOrBU5uG0q63k4tI8zYAC1rThEPAVjg1h4HJhwX6VWyTzMoeZMS8DWiibz8QH84AY tF28/e1aN2wERONhDP69Whe2mB375wbEZI2yKJH0EC/DgB88BlYh8wRK4HueIuh+DTxa LBJu2prVa/tWHM0lUdBoIhh1wcFfLdmmJFTje1+xtCMC6tFBq1dox6eQG//eQtUKLWrR Ql5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790256142; x=1790860942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IMJke5iOLDnWkz3jQXth+/pn/WHEhS9+3RUVCj3fdzw=; b=fKCiPtfLlh+0KI8GgmGJzXT32G16aZlvLoQ2HGkmPo1oh68qoHze3juWlhdEedN8at avbXdxqXZKNScusH8kmzl2efXe4NKN3k8baRdSpT7CEA2YVuOhNiAoaQ9eXZyHwK5AiH UZ+6vKaRau5TmGVAA4P8qDM3Cp9joFZVmFdaG3OpohHC//B1R48E/feyo8lN7i0sNQ0y EDFq5giNJ5fDEpFbQVch7q8Fbu9CNH62z1aESA+WrGII6BSPxyCKDRRs0czL8P5gO7nh CgUWBtpWl3Ea3VQ5BOAHNtKR+YNTqIpBBY8J8ujgZWSLyDJA7/7TrqNB/S9Lz1aDwZCJ 6m5w== X-Forwarded-Encrypted: i=1; AKwUvBwixFuZ0ttx72lXOFQcgEVsR4sechkIwjl0j8D+zb1X0dl6Xlq81QuroHX/wPYDcIcPubRVYnJItAz6P7MqRM9R@lists.infradead.org X-Gm-Message-State: AFuF++k0zNn1lgEXWEBOUETxibGgjODRMH+TQZgkim9BvgqThnUBssMH y0z77nrPXXvIRzYOzBUI4z0ume6G4dPF9rEJvSJM5J6RlpfvpozB0Boh X-Gm-Gg: AYBFou39BXyESa2mJL0gW/Vy68CdKxegd1qSovZR8XRm/9a24FCuCu5r0BlA57rw5UP pWq9XvXbGQK8z9srGxfG8FQd/3SQ8TKnrUK3+vBfXG5Q7VKSTdG4dEzkFWUQdiB4emdjcWCCHUG g+6EVPMMFxJIOQQzzWG1d7eK9dpx/oLQrDa5sCPrlfEyokKzRcgcuHckWhOBauMGxjvlzOzAXnW MiUIlQIOscJmFCYC8AeL6/hbUvg2N2Apw8mG+c7QryXfKFBsW+wL7hNJF6A/qrMzV+sv1FFU2rW J8LXxFHtsFr4jg1dNc49a1cdiV5sDlSAhR2CDMD/NVV6W0JRehhFpdapp2CJw/SZN1ImpEKVtft UQ4MPkluSNsqlcfR/Mj6VXrm6rFnUMevMuZDxB2NlQWoDD57U2JsYMTk9w9wljjUSxXKeMWzrY+ ZRlHc4sKsiSHXdrIdLl2uTRsgyRMBq1ZbVAVidNw7uHHX+w5eeigkW7aMNbWcgkAYE1NiFcjbUD Pwtd0yaAGsmV8FaWzgkIXt30m34DF0C+DXiVRRb+h+Uog== X-Received: by 2002:a05:600c:4754:b0:49d:1e09:694a with SMTP id 5b1f17b1804b1-49fe66d2ce2mr40593075e9.11.1790256141687; Thu, 24 Sep 2026 06:22:21 -0700 (PDT) Received: from zeus.localdomain (212.71.14.70.adsl.dyn.edpnet.net. [212.71.14.70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4886876c267sm14642949f8f.16.2026.09.24.06.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 06:22:21 -0700 (PDT) From: Sander Speetjens To: Alexandre Belloni Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Jonathan Bell , Stefan Wahren , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sander.speetjens@gmail.com, Dom Cobley Subject: [PATCH v5 2/2] rtc: Add Raspberry Pi 5 RTC driver Date: Thu, 24 Sep 2026 15:22:17 +0200 Message-ID: <20260924132217.1281752-3-sander.speetjens@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260924132217.1281752-1-sander.speetjens@gmail.com> References: <20260924132217.1281752-1-sander.speetjens@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260924_062224_286472_49E72AF8 X-CRM114-Status: GOOD ( 39.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Upstreaming the downstream Raspberry Pi 5 RTC driver. This driver supports the custom DA9091, which is accessed through the firmware mailbox. Signed-off-by: Jonathan Bell Signed-off-by: Dom Cobley Signed-off-by: Sander Speetjens --- V4 -> V5: No changes V3 -> V4: - Fix Kconfig depends that disallows having Raspberrypi firmware built as a module while the rtc driver is built in - Remove sysfs - Add limits from firmware properties and check in rpi_rtc_set_charge_voltage V2 -> V3: - Move platform check to firmware and abort before registering a platform device if on another platform - Add a dependency on the Raspberry Pi firmware to Kconfig - Check return value of devm_device_init_wakeup - Fix property name V1 -> V2: Instead of the original driver, which was directly bound to the device tree. This driver is bound to the Raspberry Pi firmware device by creating a child device in the firmware driver probe function. The child device is then bound to this driver, which uses the firmware mailbox to access the RTC. A couple of minor changes have been made to the driver since it was originally written, including: - Checking if the model is a Raspberry Pi 5, as the RTC is only present on that model. - Using the new devm_rpi_firmware_get() and devm_init_wakeup() helper to get the firmware device and avoid leaking memory. - Using millivolts instead of microvolts for the trickle charge voltage, to match the RTC standard. - Instead of setting the trickle charge voltage to 0 to disable trickle charging, the property is now optional. If the property is not present, trickle charging is disabled, per the RTC standard. - Renaming the driver dt match compatible to "raspberrypi,firmware-rtc" to match the other firmware bindings. - Renaming the driver name to "raspberrypi-rtc" to match the other firmware drivers. drivers/firmware/raspberrypi.c | 25 ++++ drivers/rtc/Kconfig | 12 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-raspberrypi.c | 244 +++++++++++++++++++++++++++++++++ 4 files changed, 282 insertions(+) create mode 100644 drivers/rtc/rtc-raspberrypi.c diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index 0aa322e9a2e7..a35f00c6fb2c 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -24,6 +24,7 @@ static struct platform_device *rpi_hwmon; static struct platform_device *rpi_clk; +static struct platform_device *rpi_rtc; struct rpi_firmware { struct mbox_client cl; @@ -231,6 +232,27 @@ static void rpi_register_clk_driver(struct device *dev) -1, NULL, 0); } +static void rpi_register_rtc_driver(struct device *dev) +{ + struct device_node *firmware; + + // Check if our model is a Raspberry Pi 5, as the RTC is only present on that model. + const char *model = of_get_property(of_root, "model", NULL); + + if (!model || strncmp(model, "Raspberry Pi 5", 14) != 0) + return; + + firmware = of_get_compatible_child(dev->of_node, + "raspberrypi,firmware-rtc"); + if (firmware) { + of_node_put(firmware); + return; + } + + rpi_rtc = platform_device_register_data(dev, "raspberrypi-rtc", + -1, NULL, 0); +} + unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, unsigned int id) { struct rpi_firmware_clk_rate_request msg = @@ -305,6 +327,7 @@ static int rpi_firmware_probe(struct platform_device *pdev) rpi_firmware_print_firmware_revision(fw); rpi_register_hwmon_driver(dev, fw); rpi_register_clk_driver(dev); + rpi_register_rtc_driver(dev); return 0; } @@ -327,6 +350,8 @@ static void rpi_firmware_remove(struct platform_device *pdev) rpi_hwmon = NULL; platform_device_unregister(rpi_clk); rpi_clk = NULL; + platform_device_unregister(rpi_rtc); + rpi_rtc = NULL; rpi_firmware_put(fw); } diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 05b9233b9418..4dbe20bcace8 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1999,6 +1999,18 @@ config RTC_DRV_R7301 This driver can also be built as a module. If so, the module will be called rtc-r7301. +config RTC_DRV_RPI + tristate "Raspberry Pi RTC" + depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) + depends on ARCH_BRCMSTB || COMPILE_TEST + default ARCH_BRCMSTB + help + If you say yes here you get support for the RTC found on + Raspberry Pi devices. + + This driver can also be built as a module. If so, the module + will be called rtc-raspberrypi. + config RTC_DRV_STM32 tristate "STM32 RTC" select REGMAP_MMIO diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index 0347645b021f..46f1a0fc2416 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile @@ -144,6 +144,7 @@ obj-$(CONFIG_RTC_DRV_PS3) += rtc-ps3.o obj-$(CONFIG_RTC_DRV_PXA) += rtc-pxa.o obj-$(CONFIG_RTC_DRV_R7301) += rtc-r7301.o obj-$(CONFIG_RTC_DRV_R9701) += rtc-r9701.o +obj-$(CONFIG_RTC_DRV_RPI) += rtc-raspberrypi.o obj-$(CONFIG_RTC_DRV_RC5T583) += rtc-rc5t583.o obj-$(CONFIG_RTC_DRV_RC5T619) += rtc-rc5t619.o obj-$(CONFIG_RTC_DRV_RK808) += rtc-rk808.o diff --git a/drivers/rtc/rtc-raspberrypi.c b/drivers/rtc/rtc-raspberrypi.c new file mode 100644 index 000000000000..494b94937406 --- /dev/null +++ b/drivers/rtc/rtc-raspberrypi.c @@ -0,0 +1,244 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause +/** + * rtc-raspberrypi.c + * + * RTC driver using firmware mailbox + * Supports battery backed RTC and wake alarms + * + * Based on rtc-meson-vrtc by Neil Armstrong + * + * Copyright (c) 2023, Raspberry Pi Ltd. + */ + +#include +#include +#include +#include +#include + +#define RPI_FIRMWARE_GET_RTC_REG 0x00030087 +#define RPI_FIRMWARE_SET_RTC_REG 0x00038087 + +enum { + RTC_TIME, + RTC_ALARM, + RTC_ALARM_PENDING, + RTC_ALARM_ENABLE, + RTC_BBAT_CHG_VOLTS, + RTC_BBAT_CHG_VOLTS_MIN, + RTC_BBAT_CHG_VOLTS_MAX, + RTC_BBAT_VOLTS +}; + +struct rpi_rtc_data { + struct rtc_device *rtc; + struct rpi_firmware *fw; + u32 bbat_vchg_millivolts; + u32 bbat_vchg_min_millivolts; + u32 bbat_vchg_max_millivolts; +}; + +static int rpi_rtc_read_time(struct device *dev, struct rtc_time *tm) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_TIME }; + int err; + + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_GET_RTC_REG, + &data, sizeof(data)); + rtc_time64_to_tm(data[1], tm); + return err; +} + +static int rpi_rtc_set_time(struct device *dev, struct rtc_time *tm) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_TIME, rtc_tm_to_time64(tm) }; + + return rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_SET_RTC_REG, + &data, sizeof(data)); +} + +static int rpi_rtc_alarm_irq_is_enabled(struct device *dev, unsigned char *enabled) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_ALARM_ENABLE }; + s32 err = 0; + + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_GET_RTC_REG, + &data, sizeof(data)); + *enabled = data[1] & 0x1; + return err; +} + +static int rpi_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_ALARM_ENABLE, enabled }; + + return rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_SET_RTC_REG, + &data, sizeof(data)); +} + +static int rpi_rtc_alarm_clear_pending(struct device *dev) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_ALARM_PENDING, 1 }; + + return rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_SET_RTC_REG, + &data, sizeof(data)); +} + +static int rpi_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_ALARM }; + s32 err = 0; + + err = rpi_rtc_alarm_irq_is_enabled(dev, &alarm->enabled); + if (!err) + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_GET_RTC_REG, + &data, sizeof(data)); + rtc_time64_to_tm(data[1], &alarm->time); + + return err; +} + +static int rpi_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_ALARM, rtc_tm_to_time64(&alarm->time) }; + int err; + + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_SET_RTC_REG, + &data, sizeof(data)); + + if (err == 0) + err = rpi_rtc_alarm_irq_enable(dev, alarm->enabled); + + return err; +} + +static const struct rtc_class_ops rpi_rtc_ops = { + .read_time = rpi_rtc_read_time, + .set_time = rpi_rtc_set_time, + .read_alarm = rpi_rtc_read_alarm, + .set_alarm = rpi_rtc_set_alarm, + .alarm_irq_enable = rpi_rtc_alarm_irq_enable, +}; + +static void rpi_rtc_set_limits(struct device *dev) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_BBAT_CHG_VOLTS_MIN }; + + int err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_GET_RTC_REG, + &data, sizeof(data)); + if (err == 0) + vrtc->bbat_vchg_min_millivolts = data[1] / 1000U; + + data[0] = RTC_BBAT_CHG_VOLTS_MAX; + data[1] = 0; + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_GET_RTC_REG, + &data, sizeof(data)); + if (err == 0) + vrtc->bbat_vchg_max_millivolts = data[1] / 1000U; +} + +static int rpi_rtc_set_charge_voltage(struct device *dev) +{ + struct rpi_rtc_data *vrtc = dev_get_drvdata(dev); + u32 data[2] = { RTC_BBAT_CHG_VOLTS, vrtc->bbat_vchg_millivolts * 1000U }; + int err; + + if (vrtc->bbat_vchg_millivolts != 0 && + (vrtc->bbat_vchg_millivolts < vrtc->bbat_vchg_min_millivolts || + vrtc->bbat_vchg_millivolts > vrtc->bbat_vchg_max_millivolts)) { + dev_warn(dev, "trickle charge voltage %umV is outside of the supported range (%umV - %umV)\n", + vrtc->bbat_vchg_millivolts, + vrtc->bbat_vchg_min_millivolts, + vrtc->bbat_vchg_max_millivolts); + return -EINVAL; + } + + err = rpi_firmware_property(vrtc->fw, RPI_FIRMWARE_SET_RTC_REG, + &data, sizeof(data)); + + if (err) + dev_err(dev, "failed to set trickle charge voltage to %umV: %d\n", + vrtc->bbat_vchg_millivolts, err); + else if (vrtc->bbat_vchg_millivolts) + dev_info(dev, "trickle charging enabled at %umV\n", + vrtc->bbat_vchg_millivolts); + + return err; +} + +static int rpi_rtc_probe(struct platform_device *pdev) +{ + struct rpi_rtc_data *vrtc; + struct device *dev = &pdev->dev; + struct rpi_firmware *firmware; + int ret; + + // Get the firmware device from the parent device + firmware = devm_rpi_firmware_get(dev, dev->parent->of_node); + + if (!firmware) + return -EPROBE_DEFER; + + vrtc = devm_kzalloc(dev, sizeof(*vrtc), GFP_KERNEL); + if (!vrtc) + return -ENOMEM; + + vrtc->fw = firmware; + + ret = devm_device_init_wakeup(dev); + if (ret) + return ret; + + platform_set_drvdata(pdev, vrtc); + + vrtc->rtc = devm_rtc_allocate_device(dev); + if (IS_ERR(vrtc->rtc)) + return PTR_ERR(vrtc->rtc); + + vrtc->rtc->range_max = U32_MAX; /* 2106-02-07 */ + + set_bit(RTC_FEATURE_ALARM_WAKEUP_ONLY, vrtc->rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, vrtc->rtc->features); + + vrtc->rtc->ops = &rpi_rtc_ops; + + rpi_rtc_alarm_clear_pending(dev); + + vrtc->bbat_vchg_millivolts = 0; + of_property_read_u32(dev->parent->of_node, "trickle-voltage-millivolt", + &vrtc->bbat_vchg_millivolts); + + rpi_rtc_set_limits(dev); + rpi_rtc_set_charge_voltage(dev); + + return devm_rtc_register_device(vrtc->rtc); +} + +static const struct of_device_id rpi_rtc_dt_match[] = { + { .compatible = "raspberrypi,firmware-rtc" }, + { } +}; +MODULE_DEVICE_TABLE(of, rpi_rtc_dt_match); + +static struct platform_driver rpi_rtc_driver = { + .driver = { + .name = "raspberrypi-rtc", + .of_match_table = of_match_ptr(rpi_rtc_dt_match), + }, + .probe = rpi_rtc_probe +}; + +module_platform_driver(rpi_rtc_driver); + +MODULE_AUTHOR("Jonathan Bell "); +MODULE_AUTHOR("Sander Speetjens "); +MODULE_DESCRIPTION("Raspberry Pi RTC driver"); +MODULE_LICENSE("GPL"); -- 2.55.0