From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 367FBC98318 for ; Thu, 24 Sep 2026 15:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pfYQAFaR1SRDLcvX3gMpDFts9hGw3BWSSK/5Z43artY=; b=IzBuIjXOTHLMEUL4V6DsoeEB7a pJm0m7qnmdlkQeorjjJAKRvmtUh/nWmBMl+tuxyAV1oI6TyKaY6nl5vsKMxb7GzGlfTUpm0/Vu3Wj 3Pkqqj6sSeo8PE25sT4lt2+QliKuQEf6nYkYdZMHg86f0eyiWzFxUzv5wdVqyrfmI3pMAAaLbAHUD rkuqFbzx/dqA/LM5yIEPvaVfR1S8Fo94MVMOYcdmsnhvNIHs2ULk221xITEGg29gkOqwm8Gbfsabu kAK4Xe4Ap8XaBpSHuZS3VScgOEDoCxNivWzxV8o9QFJS/VkBJmY3iKmXBByqXYYPaTwyMeMCKehd7 glJPsh5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9lKp-0000000BNp0-29Pw; Thu, 24 Sep 2026 15:26:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9lKW-0000000BNjl-25qS for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2026 15:25:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 810E41476; Thu, 24 Sep 2026 08:25:42 -0700 (PDT) Received: from localhost (unknown [10.2.196.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9218F3F86F; Thu, 24 Sep 2026 08:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790263546; bh=Hvp6b+Atb+Avq4qy65XbI5BgoGiA0NTrVIhHxTRDZy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EloduLO9QF/ahawLBjI2c5MW1xgxdY2f1q0LbzmcqYyWa9Mm8gcVYgoxsqUcT7BOc qfQ+b4pyIR4maHEsUYaJ/GTP9e5q+vZGUi1DJkByWh24RNUvuGvBaSeD0QBtUez+OZ IeOnVnbVHT7xmmU2V3qvHxI1TNKtRLAMam6qTlxw= Date: Thu, 24 Sep 2026 16:25:43 +0100 From: Leo Yan To: Yeoreum Yun Cc: Mike Leach , James Clark , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Subject: Re: [PATCH v11 0/9] fix several inconsistencies with sysfs configuration in etmX Message-ID: <20260924152543.GL200420@e132581.arm.com> References: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260924_082548_638963_05871EB6 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2026 at 12:34:35PM +0100, Yeoreum Yun wrote: > To resolve these inconsistencies, the configuration should be separated into: > > - active_config, which is applied configuration for the current session > - config, which stores the settings configured via sysfs. > > and apply configuration from configfs after taking a mode. I did the following tests on this series: 1) Perf test on Orion6 board: # ./perf test coresight 142: CoreSight synthesized callchain : Ok 143: CoreSight concurrent threads : Ok 144: CoreSight context switch thread attribution : Ok 145: CoreSight deterministic workload decode : Ok 146: CoreSight raw dump stress : Ok 147: Check Arm CoreSight trace data recording and synthesized samples : FAILED! 148: Check Arm CoreSight disassembly script completes without errors : Ok Test 147 has a known issue with per-thread mode. The failure was already observed before this series. 2) Strobe mode test: # echo 5000 > /sys/kernel/config/cs-syscfg/features/strobing/params/window/value # echo 0 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 36.301 MB perf.data ] # echo 1 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 18.361 MB perf.data ] # echo 2 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 12.246 MB perf.data ] # echo 3 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 9.197 MB perf.data ] The captured trace sizes maintain the expected proportional relationship with the period values. 3) I verified the series on Juno-r2 baord with insmod and rmmod, and CPU PM, and did not see any regression. Maybe it'd be good to send a new version addressing Mike's comments. Based on the test results, you can add my test tags: Tested-by: Leo Yan