From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9581DCA5FCB for ; Thu, 1 Oct 2026 13:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sf4zp/ltWC8DCbKJ7GdGmuPbkhgHn5ByD/RcE+htAVY=; b=FvVyRdGkMFnJ6hZVeA0haK7OrI 5DAFQcmKOF48h+RJXTpFMhkaBf0ypUX6BDjUw06s3vcFxkamxr3Y0hjQfOgnkeqGS/qAlzd7iGVad kh0Qd/dS/WMLhjl3w5breSNXTJSUTzzgJlYrW5wXiKqdOG+VdHgybCj35OyDscujXYEAidHW78bv/ 5V675JzG/aSi3c80RJzMcQ9paZjerJTWR4KYQmPg9+aObQqiZxLhd+r/9C8nJ+x0GuzkP0dtpvd2l ZNzFAVheL414tpWEiFaZLb0UTzwUslz8fjRdcAiU473s5FWOS0FPrBmQK8cZRSQqf9es70R1mVdTh fcWL7TVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCGb3-00000009Bv5-40UT; Thu, 01 Oct 2026 13:13:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCGb1-00000009Bro-2156; Thu, 01 Oct 2026 13:13:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=sf4zp/ltWC8DCbKJ7GdGmuPbkhgHn5ByD/RcE+htAVY=; b=q414RxdTJxzoZ2N6BqID50CWTc WT2QS0ZhD/JuUDtjo9dwsQxeZ92vsbQHlZNO73qEo/PA5ZBvWyLm04jxs/B+kdjEY15Yjkraw9joj R33p8QGOW4YdV7FxCMyUq5R9qxcW9R/tmGIofcIdXChq2z2OL9U47bCWkkqIrZpUuyeRUSeFAMgim Uk4L/Q+oUlFhO/IBqZwKKwi013KOR9Sj2XDsNEZ50B+n2TmB0nzv9fXZkcc/ZgB41jxqSvPh6NXBn SaJf9K+MmjePuOPWM0Nh4rz9WTX2R3ZjnnZ9RYkV8FjxLeVH5acMvDXtH/QqJ8mGff1spMFSf3nZH njeoN3nQ==; Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1xCGay-000000050P4-2XYj; Thu, 01 Oct 2026 13:13:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1790860382; bh=5XO4+Z/1+hdw3bMiXqY2f1DDo59APA0LsBUWvx837K8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EBfQWZjQkcKOGjBXy7PWvd0Ctnh1SQJK4hikBHeQpItKV/pUtRzVIWRJgLTCD3HIF MHOo9V13GdkTzLIRzc4QiZM5QSkMf1q+sKw3XKizIZ9Fv9ELYKH6utu53pHQdEK0/I 720nHqlg/r9weHPB1utNo6e/QhFk6LlcYCfqqQXaCX5HORCqEGQOrvMXR6maYxh7s7 C/Hcj/Qe3FRHziN1ifyGkoFqpdfF3uE3KQNuxsu+i8PNFc3iIeTh8MG7zYqsbC7Iug jRBT+6p+3mkolK9979E8Y7tLURIFqhtdKNMZhcE0OvLs8iX32GFvd0juFbDvLbPo+b 9qrIlK0WTL9Aw== Received: from jupiter.universe (unknown [100.64.1.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id 71B9317E04B7; Thu, 01 Oct 2026 15:13:02 +0200 (CEST) Received: by jupiter.universe (Postfix, from userid 1000) id 23FE1480029; Thu, 01 Oct 2026 15:13:02 +0200 (CEST) From: Sebastian Reichel Date: Thu, 01 Oct 2026 15:12:39 +0200 Subject: [PATCH v2 1/4] phy: rockchip: inno-usb2: simplify and unify PHY op debug messages MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-1-e01bf509359e@collabora.com> References: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> In-Reply-To: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Igor Paunovic , kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=5XO4+Z/1+hdw3bMiXqY2f1DDo59APA0LsBUWvx837K8=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGq+XF2cpqRApg/NxLB8f2UY1JKPXvsdMrsqJ 3hdqlBZM+SyeYkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJqvlxdAAoJENju1/PI O/qaxZ0P/izObD4JaPKuCw910B22PzL37LsNJtN97B2mNAw20e/0j4CXmCl3qZ6NybBg3t0AccL ekbR9rrzUKw4BDot/GDvnYUDEbE/dkcgBkLK8GJc1fJkq3fbeki9wG3kP7YzGqDm9cWgxNTqUcn ++oCj4v2TFKzqr7mjOgT7hJJm+AuGsJXsj62XpmdXGfbwy0GMrT8+93tzeT2mRgUdt8D3xL2NCp yEUYf6icJDcVVXFVU7zBNciIYBYIbc9PELZi23nPQFWCufHpxmu745Yp6SjGzRRPwf0lrUeHvvS 454TnQFpwBBGT+ivV6c6NW2TI0B65YNYz4hv8HXje2Q5W3ENz0MZ0lkCmreubAZJAnCcy6MF0Af eXdSGE1Y69kPjAbvRSanmL0/E1Wv/jMdNMMFogXtoSUOakvP4SkhWeA6LSBbMUk6GUXlo8o6F/Z 01Tg4NY0wExjzcml/fL5eOkJxE6dKDV8mc3xavL1PdQFPqHSDP+OrV9nFJwDMYsvnf0BhAraeGt dcFU1/3Il+CRTB+4v+Y2SGva9mjcOhitcU0GUCk6nLPBmDoE2o/qJCQp3ct+yBVIQzvjeyEvzk3 glbdkd8bQfPWzNLYe/JF2xUCo5Vxqgf0dJ/hlEqNDKPKCXMzM1ut7EdJaW4Ws2d0GxwrjTQ2IjM kcC1TFzJ8MSOyyVMIPz8qHg== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261001_141308_767977_6A3B951C X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add debug message for init/exit in addition to power_on/power_off and avoid the useless extra dereference in the existing power_on/power_off to make the prints consistent. Signed-off-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 7d8a533f24ae..0ab054ee84cb 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -508,6 +508,8 @@ static int rockchip_usb2phy_init(struct phy *phy) struct rockchip_usb2phy *rphy = dev_get_drvdata(phy->dev.parent); int ret = 0; + dev_dbg(&phy->dev, "phy port init\n"); + mutex_lock(&rport->mutex); if (rport->port_id == USB2PHY_PORT_OTG) { @@ -592,7 +594,7 @@ static int rockchip_usb2phy_power_on(struct phy *phy) struct rockchip_usb2phy *rphy = dev_get_drvdata(phy->dev.parent); int ret; - dev_dbg(&rport->phy->dev, "port power on\n"); + dev_dbg(&phy->dev, "port power on\n"); if (!rport->suspended) return 0; @@ -632,7 +634,7 @@ static int rockchip_usb2phy_power_off(struct phy *phy) struct rockchip_usb2phy *rphy = dev_get_drvdata(phy->dev.parent); int ret; - dev_dbg(&rport->phy->dev, "port power off\n"); + dev_dbg(&phy->dev, "port power off\n"); if (rport->suspended) return 0; @@ -651,6 +653,8 @@ static int rockchip_usb2phy_exit(struct phy *phy) { struct rockchip_usb2phy_port *rport = phy_get_drvdata(phy); + dev_dbg(&phy->dev, "phy port exit\n"); + if (rport->port_id == USB2PHY_PORT_OTG && rport->mode != USB_DR_MODE_HOST && rport->mode != USB_DR_MODE_UNKNOWN) { -- 2.53.0