From: Frank.Li@oss.nxp.com
To: Mark Brown <broonie@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Radu Pirea <radu_nicolae.pirea@upb.ro>,
Ryan Wanner <ryan.wanner@microchip.com>,
linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Microchip (AT91) SoC support),
linux-kernel@vger.kernel.org (open list)
Cc: vkoul@kernel.org, imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 1/1] spi: use dmaengine_submit() instead of ->tx_submit()
Date: Fri, 2 Oct 2026 15:26:14 -0400 [thread overview]
Message-ID: <20261002192616.161440-1-Frank.Li@oss.nxp.com> (raw)
From: Frank Li <Frank.Li@nxp.com>
Replace direct dma_async_tx_descriptor->tx_submit() calls with the
proper dmaengine_submit() API wrapper.
Assisted-by: LLM
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/spi/atmel-quadspi.c | 2 +-
drivers/spi/spi-at91-usart.c | 4 ++--
drivers/spi/spi-atmel.c | 4 ++--
drivers/spi/spi-cadence-quadspi.c | 2 +-
drivers/spi/spi-ti-qspi.c | 2 +-
drivers/spi/spi-topcliff-pch.c | 4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ec19fa0180f00..3acb139e4db13 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -792,7 +792,7 @@ static int atmel_qspi_dma_xfer(struct atmel_qspi *aq, struct dma_chan *chan,
reinit_completion(&aq->dma_completion);
tx->callback = atmel_qspi_dma_callback;
tx->callback_param = aq;
- cookie = tx->tx_submit(tx);
+ cookie = dmaengine_submit(tx);
ret = dma_submit_error(cookie);
if (ret) {
dev_err(&aq->pdev->dev, "dma_submit_error %d\n", cookie);
diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
index cdc771350db93..aadcdf734fb03 100644
--- a/drivers/spi/spi-at91-usart.c
+++ b/drivers/spi/spi-at91-usart.c
@@ -231,11 +231,11 @@ static int at91_usart_spi_dma_transfer(struct spi_controller *ctlr,
rxdesc->callback = dma_callback;
rxdesc->callback_param = ctlr;
- cookie = rxdesc->tx_submit(rxdesc);
+ cookie = dmaengine_submit(rxdesc);
if (dma_submit_error(cookie))
goto at91_usart_spi_err_dma;
- cookie = txdesc->tx_submit(txdesc);
+ cookie = dmaengine_submit(txdesc);
if (dma_submit_error(cookie))
goto at91_usart_spi_err_dma;
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index af1f0ad16be67..ffc896e4621ac 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -871,10 +871,10 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_controller *host,
rxdesc->callback_param = host;
/* Submit and fire RX and TX with TX last so we're ready to read! */
- cookie = rxdesc->tx_submit(rxdesc);
+ cookie = dmaengine_submit(rxdesc);
if (dma_submit_error(cookie))
goto err_dma;
- cookie = txdesc->tx_submit(txdesc);
+ cookie = dmaengine_submit(txdesc);
if (dma_submit_error(cookie))
goto err_dma;
dma_async_issue_pending(rxchan);
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index fe5b094f0b6b3..709aea0f237fc 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1398,7 +1398,7 @@ static int cqspi_direct_read_execute(struct cqspi_flash_pdata *f_pdata,
tx->callback = cqspi_rx_dma_callback;
tx->callback_param = cqspi;
- cookie = tx->tx_submit(tx);
+ cookie = dmaengine_submit(tx);
reinit_completion(&cqspi->rx_dma_complete);
ret = dma_submit_error(cookie);
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index fb0d940883fb9..091a8b8842f58 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -454,7 +454,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
tx->callback = ti_qspi_dma_callback;
tx->callback_param = qspi;
- cookie = tx->tx_submit(tx);
+ cookie = dmaengine_submit(tx);
reinit_completion(&qspi->transfer_complete);
ret = dma_submit_error(cookie);
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 0da1b986d3ee1..117eb83ce1990 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1092,8 +1092,8 @@ static void pch_spi_handle_dma(struct pch_spi_data *data, int *bpw)
spin_lock_irqsave(&data->lock, flags);
pch_spi_writereg(data->host, PCH_SSNXCR, SSN_LOW);
- desc_rx->tx_submit(desc_rx);
- desc_tx->tx_submit(desc_tx);
+ dmaengine_submit(desc_rx);
+ dmaengine_submit(desc_tx);
spin_unlock_irqrestore(&data->lock, flags);
/* reset transfer complete flag */
--
2.43.0
next reply other threads:[~2026-10-02 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 19:26 Frank.Li [this message]
2026-10-05 14:05 ` [PATCH 1/1] spi: use dmaengine_submit() instead of ->tx_submit() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002192616.161440-1-Frank.Li@oss.nxp.com \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=ryan.wanner@microchip.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox