From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4C47CA5FD4 for ; Fri, 2 Oct 2026 09:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SRoWf2wqbfBEbqSEq04DpriXW38jlq2Q9kbJqJbDTBc=; b=qkEeBX/E1ivWC9v4RcuFcz0qIo vONtavsnCPaNllyrRM7jqF8rQ1ux/srGhvNvLNmfFX/fY2btYJLVp5Wc+a91ykDa9+ZKh4zRYvC22 te+dLKAYrctDlEWsyAtBa2edCRY6JSfLX0TML4vJqvDrOGZHCTPpyM4hTJwyWFbPpm9sIQ+ENOvix gWwWl4PDqWQy8iHUh6FY+P4C8VHGhhGAmPAEPdSm4aB7gWd2bCpD/dFJFhJXSL/+SHpvVCBj8Pbq2 0XLTox3/SPqNWEn/bYMWj7+bkrHKrrf2k1Ae0UVDucSbT0XN9c52qdYEQvxOP+ORo6xrd5IbqTYXG P0YeiqXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCZZl-0000000B9It-2kFA; Fri, 02 Oct 2026 09:29:09 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCZZk-0000000B9Hv-0B0A; Fri, 02 Oct 2026 09:29:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 32DED60A79; Fri, 2 Oct 2026 09:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 687341F000FF; Fri, 2 Oct 2026 09:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790933346; bh=SRoWf2wqbfBEbqSEq04DpriXW38jlq2Q9kbJqJbDTBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=bpPbd0cMdYcoJq3bPxhGT7iCLiUS2nx4raPNJ3YwvA1/kIlvr1hGOgz8JNkG+uC6c 9LzQCfc6HA8X+FOsdJ0YPUAYssWOP9eprWDVQ2g5AMU0AxnyIrgBCDRVKmML9FX/a5 frPSwTp6S8qrPLSRI2/DKQgu3lKeFIsLCabbblFE= Date: Fri, 2 Oct 2026 11:29:00 +0200 From: "gregkh@linuxfoundation.org" To: Thinh Nguyen Cc: Guangshuo Li , "neil.armstrong@linaro.org" , "khilman@baylibre.com" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "jbrunet@baylibre.com" , "martin.blumenstingl@googlemail.com" , "felipe.balbi@linux.intel.com" Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable VBUS regulator on remove Message-ID: <2026100239-swarm-hacked-015e@gregkh> References: <20260924110429.1557653-1-lgs201920130244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2026 at 03:18:38AM +0000, Thinh Nguyen wrote: > On Thu, Sep 24, 2026, Guangshuo Li wrote: > > dwc3_meson_g12a_probe() enables priv->vbus when the optional regulator is > > present, but dwc3_meson_g12a_remove() does not perform the matching > > regulator_disable(). The probe error path already disables the regulator > > before rearming the reset control. > > > > Disable priv->vbus in the remove path before reset_control_rearm() to > > match the cleanup performed by the probe error path. > > > > Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue") > > We should also include Cc stable. Maybe if the sashiko results are fixed first, this is dropped from my review queue. thanks, greg k-h