From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CCAFCA5FE2 for ; Sat, 3 Oct 2026 02:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m4Bf2ZFROeohsX/7IoYLRoVtwsXCs1sBLFwVjm2jBVc=; b=NwpRI4+vADcJqrAu4kOoD9wdT8 /b1w1Mxvc56y2dw8gtqBEKG0QHvxLziKb4sHZ9o76Gl6sRt44NHemSe8wW2ftUJ4r5Mb8wJ7P9gdU ZEErkxh3pBCrJxWTW5yvm5TfLMMmGMrYeCEo4ZkJ39hNMUgTjq+rakrxvUOmFCBIAc0dxTQRdfrfY wYWhYsmVl0BUa1ZX48KyibuTXHMm+xT0rWiRWtHU2Bsl+me3OGMfrR8TY0/PqVGGKJGEJKQ+iuqA0 YS/OtAVgKLBU8c3T3j+i8DlDrmpCwdy4pwQS4xeiS1wcuSFypU5+9jE3S/0FHGgKERdqNDlynD6YC mTtXvCHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCprh-0000000CxBt-090R; Sat, 03 Oct 2026 02:52:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCprd-0000000Cx9H-10pd for linux-arm-kernel@lists.infradead.org; Sat, 03 Oct 2026 02:52:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16A282F; Fri, 2 Oct 2026 19:52:37 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 666C33F763; Fri, 2 Oct 2026 19:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790995960; bh=M/H8p54y9BAGRBok7Bq+l77HPKLtLrhketpnjFmnyH0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=curc2BE9ZhtdKVJjrN5TvMhlUxVY7AbWpyOsE9GmSAXohHoHjFKz+dFIJVbk2R7NX sc4NPnf0yXfGF6/SZkub5UkckHxBHy0qIUwrsvaOJPGkpgYV4Z0fv1t8t4v7IEffQz RX0NIkobmV/wBh4ZWDPugXDi5d3bIP4uJmLn7I30= From: Yeoreum Yun Date: Sat, 03 Oct 2026 03:52:15 +0100 Subject: [PATCH RESEND v13 03/14] coresight: etm3x: prohibit modifying cntr_val and reset while session is enabled MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261003-separate_etm_cfg_v2-v13-3-5d8a29aead95@arm.com> References: <20261003-separate_etm_cfg_v2-v13-0-5d8a29aead95@arm.com> In-Reply-To: <20261003-separate_etm_cfg_v2-v13-0-5d8a29aead95@arm.com> To: Mike Leach , James Clark , Leo Yan , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Yeoreum Yun X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1556; i=yeoreum.yun@arm.com; h=from:subject:message-id; bh=M/H8p54y9BAGRBok7Bq+l77HPKLtLrhketpnjFmnyH0=; b=owEB7QES/pANAwAKAW3Vw9FaxTEzAcsmYgBqwG3kO8Ia+RgIa6TGr8bMwB3ihA9t/0Dv9uHVt SGYLCIZSAeJAbMEAAEKAB0WIQQtg+CS3QUzuFh1pJ1t1cPRWsUxMwUCasBt5AAKCRBt1cPRWsUx M0gXDADV9P6WDGWyvhb/sriIF9ERz9gRNjL21avxFPFPtHsinDiNo7/BlcYVlcXpfsEwe27B8SO zYYwPby1l8A026uDUq+4VobhaQnzvrdXN6Z/LcniW3rgJcJxkUNVyX96RS4bHl6V49kDBPu/q5H 9xfti0cy2eHYn3bl3oY1JQ8r23BFv2y7tqF4L5KijxabfMurII1svpJ9D2byNgKp9YbFfa/QhpO VglirMJRO5MclRLqu4v+FgqhxbByeMNLbTr1vsytA7zOP5Cs2lrOdFAO25Lb6etyZepro7PNebD Z9UJrjgJqlR4v9ljSr+UMlFA3KzmpW9St3lC968Bjd4pIJ4ctrgxnOsYH2gW3AHFVOkjeAYxBGd By7w/dDEhcEhH6X+69eSyAkTCMne/bXk/LUCEH3N8jwL/E57JktLu+ZaSqnUZZZ2iWe99A2dkdw tUIQRrgaRvQJMRQ8MQioVvIkok6emsUMBNidY7MGVm6afDWt2mtgD7pU2Ef3ec3Yb8cSg= X-Developer-Key: i=yeoreum.yun@arm.com; a=openpgp; fpr=2D83E092DD0533B85875A49D6DD5C3D15AC53133 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261002_195241_354032_4E1CE8CA X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cntr_val are overwritten with the values read from the corresponding registers by etm_disable_hw() when the session is disabled. This means that any changes to this value made while the session is enabled would be lost when the session is disabled. Also, reset shouldn't be called while session is enabled. Therefore, prohibit modifying cntr_val and reset while the session is enabled. Reviewed-by: Mike Leach Tested-by: Leo Yan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c index b3c67e96a82a..cdb70a4382eb 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c @@ -75,6 +75,10 @@ static ssize_t reset_store(struct device *dev, if (ret) return ret; + if (IS_ERR_OR_NULL(drvdata->csdev) || + coresight_get_mode(drvdata->csdev)) + return -EBUSY; + if (val) { spin_lock(&drvdata->spinlock); memset(config, 0, sizeof(struct etm_config)); @@ -744,6 +748,9 @@ static ssize_t cntr_val_store(struct device *dev, ret = kstrtoul(buf, 16, &val); if (ret) return ret; + if (IS_ERR_OR_NULL(drvdata->csdev) || + coresight_get_mode(drvdata->csdev)) + return -EBUSY; spin_lock(&drvdata->spinlock); config->cntr_val[config->cntr_idx] = val; -- 2.43.0