From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40957CA5FE6 for ; Sat, 3 Oct 2026 20:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aD28cj3L4bP16bv1SX5AbEY1u/TeDOJmTI3lqvzpdB0=; b=HCBqYKzJzV8+fMKX+vZIlU8El5 6593SpFs2Xse6Hhk+u/RFRaiDw1uYgUF1F0qSXRgrw5uL0vOlzWFNuqLsVV80+N2bVvEvhjJz/Hbm N0G3wfgaw5Gi5zCViMuO8ehT2/XAU83ikLDFZ9Ex6ydy94VEFs1TQk2XNq49m3blz7V5IgIXEGZZR qj0Cf7qO3dhE1Jz99g20AzhqUzOwDNZGBYu0QJvU5OtZqTEAGVer2fvog2EuaHayXyavsgNE2tYC+ cBRTmeCejkDWmMsVtxEB18xdKW5bu0Pi4fmnf+xjSHQh1Vrd9+H+4O7VKs/acAqAtOdT0sm0obybu tDPrs4wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xD5vk-0000000Dz6h-0VLc; Sat, 03 Oct 2026 20:02:02 +0000 Received: from mail.nozomi.space ([139.162.184.125]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xD5vO-0000000DyyO-2i9j; Sat, 03 Oct 2026 20:01:43 +0000 From: =?UTF-8?q?Micha=C5=82=20Kope=C4=87?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nozomi.space; s=mail; t=1791057696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aD28cj3L4bP16bv1SX5AbEY1u/TeDOJmTI3lqvzpdB0=; b=zgkxqL8pm7Y0xGAGOr4pq7/MAekzWZvjKJUmlQTrCA1jtbY2tB6voTZaoLojnKt9Ort18a O+j0hNRpC4aSSkWvaovUfvdyjQg8Gj1Cxo91SUbRrTcms7/h+MuHqHY0WxHHvYc35TnzSz UtQi2Rd7SQZb0zfyKh3PKvP2cvgkHFMLr0djytusbHpm5VKIj0zmpzZAAforcHSaVx39mW b52PsRR8ChhHgJESto11dTWQCqZ86tI2Sw4PRlh1Eniz7WY6jVU22ChrflwrSr6qSmPDqQ ZTZwcHS1pi0ibRXLxgl/gXC6Y7/TVPfPmFwI4YUpG3cy6FANGFnYuLRFdSz69g== To: Boris Brezillon , Steven Price , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Micha=C5=82=20Kope=C4=87?= Subject: [PATCH 2/3] drm/panfrost: Enable the GPU timestamp counter on MT8188 Date: Sat, 3 Oct 2026 22:01:31 +0200 Message-ID: <20261003200132.866240-3-michal@nozomi.space> In-Reply-To: <20261003200132.866240-1-michal@nozomi.space> References: <20261003200132.866240-1-michal@nozomi.space> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261003_130139_750202_FBA018DD X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On MediaTek SoCs the GPU timestamp counter is fed by the SoC system timer only once the TOP_TSVALUEB enable bits are set in the MFGCFG block. The setting is lost whenever the GPU power domain is turned off. Without it, GPU_TIMESTAMP reads zero, so the SYSTEM_TIMESTAMP query and timestamps written by jobs are always zero, which breaks timestamp queries in userspace drivers. Look up the MFGCFG block from the mediatek,mfgcfg phandle and set the bits from the vendor quirk hook, which runs on every power-up, as the downstream kbase driver does. Without the phandle nothing changes. Signed-off-by: Michał Kopeć --- drivers/gpu/drm/panfrost/panfrost_device.h | 1 + drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + drivers/gpu/drm/panfrost/panfrost_gpu.c | 39 ++++++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_gpu.h | 1 + 4 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index 1fe1554f2652b..0a73939a023c3 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -134,6 +134,7 @@ struct panfrost_device { int mmu_irq; void __iomem *iomem; + struct regmap *mtk_mfgcfg; struct clk *clock; struct clk *bus_clock; struct clk *bus_ace_clock; diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 70c05210ea846..e811652e2384d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -1133,6 +1133,7 @@ static const struct panfrost_compatible mediatek_mt8188_data = { .pm_domain_names = mediatek_pm_domains, .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), .gpu_quirks = BIT(GPU_QUIRK_FORCE_AARCH64_PGTABLE), + .vendor_quirk = panfrost_gpu_mt8188_quirk, }; static const struct panfrost_compatible mediatek_mt8192_data = { diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 29ac0dce5ff89..971abc9cc222c 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -9,8 +9,11 @@ #include #include #include +#include +#include #include #include +#include #include @@ -114,6 +117,40 @@ void panfrost_gpu_amlogic_quirk(struct panfrost_device *pfdev) gpu_write(pfdev, GPU_PWR_OVERRIDE1, 0xfff | (0x20 << 16)); } +#define MTK_MFG_TIMESTAMP 0x130 +#define MTK_MFG_TIMESTAMP_TOP_TSVALUEB_EN 0x3 + +void panfrost_gpu_mt8188_quirk(struct panfrost_device *pfdev) +{ + /* + * The GPU timestamp counter only counts once MFGCFG routes the SoC + * system timer to it. The setting is lost whenever the GPU power + * domain is turned off, so it has to be restored on every power-up. + */ + if (pfdev->mtk_mfgcfg) + regmap_write(pfdev->mtk_mfgcfg, MTK_MFG_TIMESTAMP, + MTK_MFG_TIMESTAMP_TOP_TSVALUEB_EN); +} + +static void panfrost_gpu_get_mtk_mfgcfg(struct panfrost_device *pfdev) +{ + struct device_node *np; + struct regmap *regmap; + + np = of_parse_phandle(pfdev->base.dev->of_node, "mediatek,mfgcfg", 0); + if (!np) + return; + + regmap = device_node_to_regmap(np); + of_node_put(np); + if (IS_ERR(regmap)) { + dev_warn(pfdev->base.dev, "failed to get MFGCFG: %pe\n", regmap); + return; + } + + pfdev->mtk_mfgcfg = regmap; +} + static void panfrost_gpu_init_quirks(struct panfrost_device *pfdev) { u32 quirks = 0; @@ -519,6 +556,8 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) { int err; + panfrost_gpu_get_mtk_mfgcfg(pfdev); + err = panfrost_gpu_soft_reset(pfdev); if (err) return err; diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.h b/drivers/gpu/drm/panfrost/panfrost_gpu.h index b4fef11211d5f..2b974576b96e9 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.h +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.h @@ -23,5 +23,6 @@ unsigned long long panfrost_cycle_counter_read(struct panfrost_device *pfdev); unsigned long long panfrost_timestamp_read(struct panfrost_device *pfdev); void panfrost_gpu_amlogic_quirk(struct panfrost_device *pfdev); +void panfrost_gpu_mt8188_quirk(struct panfrost_device *pfdev); #endif -- 2.55.0