From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2160ACA5FCE for ; Mon, 5 Oct 2026 11:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wrzhrSiREEi518WgYUmB9rjEq8Ct4ueH+v9/vpcq6jQ=; b=kxhd+Z6bpxO0BHR4djf+Ogqvd+ QkK+vfFCbwz8ZjwCTWxS+kmY3XTd7jEvWB3W4gxZnWMuMEdvcBPGfo5p3F10mOZ+IZOGGeJY1TveU LxuuZlwMEvLeIjuYnwRyNuXSUYDYPOM6lHaS1eV6gjhxwgrgbrdB3AmlLmKrCVgS+b6F954neVntD VZZ1nUSXcbreSvfsJXrGR6zFrr8YOOw/tt7s2H3aCfjKMW91r2PsO8iI1tJ0joDqVnuzZkk1AsIYJ Ky6Dra7EUoD3QVnZymQlvEap8PuCVVnzBtbw2ChvE4A1qPYUNmFJ0WN7JtK4noka2ILHcPiT+Bt1I WM8cFq8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xDgTz-0000000GHD5-3fbK; Mon, 05 Oct 2026 11:03:47 +0000 Received: from mail-pz2-x29.google.com ([2607:f8b0:4864:3b::29]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xDgTw-0000000GH8L-0LL0 for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2026 11:03:46 +0000 Received: by mail-pz2-x29.google.com with SMTP id d2e1a72fcca58-887d4b0e846so267567b3a.0 for ; Mon, 05 Oct 2026 04:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791198223; x=1791803023; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wrzhrSiREEi518WgYUmB9rjEq8Ct4ueH+v9/vpcq6jQ=; b=nMYt4kS8zPzWy38IeVPCNViGrqR+KmP/NavZuHH/DXenvg1WvGdRvfObWuIn0Mo1sO p/xHkwjQH6xY1fZ2iyU5x/kxHRU2cfnOAbwVnwtR8XWYORAwKDCoSYGbKVjS0zZyzN9/ O+oCJD1MibOHN//AgL/X/ofMFN86MByTxQ7rVYoQWzb1RO9MTt+luTWk6FXQ9KGHcZWh QewEvYur71yU5YZx32qwFFBvX5I4/ax4zEsNzVD/OQixLTO2WVYAAEKUrIZ+1e4A8nQt IAdlLgSlhTCtODGArAzBSqb1MR5uReM6EchbSf+p7tnA8V36UKZePLC2XP5xMvJP6gGa vJhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791198223; x=1791803023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wrzhrSiREEi518WgYUmB9rjEq8Ct4ueH+v9/vpcq6jQ=; b=mVr+FGQNvJWc05vJ2j7yedNi3ChTaGuJzCDvZfi7cNM7BH6GfegNr8mfPk9KmZdDwv 2GvI+i5G068bGP5mBrywc+/UTieJ8JH8wczVYsQtlPFszwkjfHjPexHLHgnrdnXZfHcm bvjcknIns8m5mjlpuimNuPJIIHgxA2q/Zrs+BIYAqqIfIJE/U0vtysIpbA21bwb8I/9r gQRMHgdDckarYAL78+Nt+eAdVq5nHj/3s7eq2HnFo5FOiq57Rkjl0w572gr/niT/fSRF SbX+PDZppGiI7XMSgI/CRg0n5lEsrHnfUkkQvfiqoi3uYHyv0wdXIGyDVbtCn9tOS/Wu 8ThQ== X-Forwarded-Encrypted: i=1; AKwUvBxgZrG8nOs9lcx57K/UTgTwkkh4jtda+DUUeaROhTDZF/mZ0S1lB6ytslc78lxIv0qI3ThbA1kMrBLh39nqFp82@lists.infradead.org X-Gm-Message-State: AFuF++mop2X7C+zwJouOlX9Q1ARQy4PblsQ5hD3sznq2B/EnbpNDR7q0 DA6zFPBpXgNAMASC0BlorHOFqdBbHnG2UgpdsSrCnxsbzekomm4u0Mum X-Gm-Gg: AYBFou0OaiGPEFmT9f3M0s+GA3Lrz+zWT/2OhAHf34h40bFytmGgEF8knhznAuzs15i 5bjxDFr9TTuN3Fci0zd96Aue2bYjiS8XKxL8RJSerXfSl1VCh/mt2J2BBysub1XeBDoClMRpnvP zcmJeJU1uGiPJkvzUBjVdvFL4aDsTHYZtVymZkHsxqKrfNFvxe6qwWs2TZvaU9hep631quz/XcJ 3aWgw3uVIMuXZ9+OATQY8oEr0huzCSWlUXPG/YjpWs5aSEC0xC8pRD+fnfKOvlAsrp3Z1sGafsk O74CKh4C8SEg35qbgIV33ZVD2SEEwc24hmDcchpXovZuGni1ZO/znrv2fog2DJC+LW8TIL0R4o2 vRRu2vtlVJh1DDmcLKFhXDPjof+56n32GPuRCXr5LOcOOfoB1NoVBqKurUBpjzKOqn+FNWUvSW/ RsxTac0TIc/4BMTl+3sKTPsY93bkpnXgM9kOtoOK5nzsjpQB/RZhnsFwvAtyvINGJmLazgMt+Fk cCYaZXr/dX0yXKpxIXBDU3dB5+h2zhfYULA2jJdNujS2Q/qnIB5/PjjVc7TfFZ0xNaiO+uFX6A6 lT+pj8gNRgXJqg== X-Received: by 2002:a05:6a21:4ea9:b0:3de:60e0:5ca5 with SMTP id adf61e73a8af0-3e0bcfe8b19mr7326452637.9.1791198223408; Mon, 05 Oct 2026 04:03:43 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cce6d334de5sm626498a12.11.2026.10.05.04.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 04:03:42 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno , Trevor Wu Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , cassiogabrielcontato@gmail.com, Mukesh Ojha , Liviu Dudau , Haotian Zhang , HariKrishna Sagala , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 06/14] ASoC: mediatek: mt8195: Fix FE startup error handling Date: Mon, 5 Oct 2026 18:02:49 +0700 Message-ID: <20261005110257.50145-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261005110257.50145-1-phucduc.bui@gmail.com> References: <20261005110257.50145-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261005_040345_359582_065951B5 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc Check and propagate errors from paired memif clock preparation and PCM hardware constraints during FE startup. Unprepare the paired memif clocks and shut down the FE when a later startup step fails to avoid leaving resources enabled on error. Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver") Signed-off-by: bui duc phuc --- Changes in v2: - Check for negative return from mtk_afe_fe_startup(). sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 44 ++++++++++++++-------- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c index 1d3e01e2c3e7..02736949ae6a 100644 --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c @@ -364,24 +364,38 @@ static int mt8195_afe_fe_startup(struct snd_pcm_substream *substream, int id = snd_soc_rtd_to_cpu(rtd, 0)->id; int ret = 0; - mt8195_afe_paired_memif_clk_prepare(substream, dai, 1); + ret = mt8195_afe_paired_memif_clk_prepare(substream, dai, 1); + if (ret) + return ret; ret = mtk_afe_fe_startup(substream, dai); - - snd_pcm_hw_constraint_step(runtime, 0, - SNDRV_PCM_HW_PARAM_BUFFER_BYTES, - MT8195_MEMIF_BUFFER_BYTES_ALIGN); - - if (id != MT8195_AFE_MEMIF_DL7) - goto out; - - ret = snd_pcm_hw_constraint_minmax(runtime, - SNDRV_PCM_HW_PARAM_PERIOD_SIZE, - 1, - MT8195_MEMIF_DL7_MAX_PERIOD_SIZE); if (ret < 0) - dev_dbg(afe->dev, "hw_constraint_minmax failed\n"); -out: + goto err_clk_unprepare; + + ret = snd_pcm_hw_constraint_step(runtime, 0, + SNDRV_PCM_HW_PARAM_BUFFER_BYTES, + MT8195_MEMIF_BUFFER_BYTES_ALIGN); + if (ret) + goto err_fe_shutdow; + + if (id == MT8195_AFE_MEMIF_DL7) { + ret = snd_pcm_hw_constraint_minmax(runtime, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, + 1, + MT8195_MEMIF_DL7_MAX_PERIOD_SIZE); + if (ret < 0) { + dev_dbg(afe->dev, "hw_constraint_minmax failed\n"); + goto err_fe_shutdow; + } + } + + return 0; + +err_fe_shutdow: + mtk_afe_fe_shutdown(substream, dai); +err_clk_unprepare: + mt8195_afe_paired_memif_clk_prepare(substream, dai, 0); + return ret; } -- 2.43.0