From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 443AECA600A for ; Thu, 8 Oct 2026 09:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5LTUQDkb378YPmw68zWXSz4SJmRldwpuVhfPkRL4Fis=; b=VJXldYrjc4VFhYn+gdpPVVfRI6 8WB4oMYrARN6KakZIVD5PabpjjbZy6e3sW4QDHtogywxPdtsk5v+ovniGyQKXrJA7upmQWyhbBDWH IHJwnAWoqxewe4+fxM/3p3y1Ocf8DP2rPe+daGCN715iKhIhWY4H2nOpjT+Lhinc1f8c79/t09P/Z 1YgGAAivCBg1qEfaXF0AHUk3jnkEEi0Z/ylr7TGwa1H62fVtoX06XvRvIGTJxNdTTArJucMjq8CVv Rqts3rITDwGAzo0Py3W/xHgsJ8EPA4rcglvxPrhDSTVizMP6CLgPttaZH4BVeL2Uydii57ac6QuWc xmaDAeSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEk2U-00000003xAz-0w9d; Thu, 08 Oct 2026 09:03:46 +0000 Received: from mail-francecentralazon11013049.outbound.protection.outlook.com ([40.107.162.49] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEk2S-00000003x8v-0o9M for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2026 09:03:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xRirvvmOkT7Hxgh/4U32xBlXkZ/hQ01pJtIKWRUPxbZCGVPEDmgkd3RZCqDnAkUzUkzv7FLQf+PtWYRdz64oW8KYgj7Kf0Oxe/ZrPqdLXtoqFjMvHoYwWsPhyTV/jCMzKqxxq9+PO0LDvrE8PQJIjpQadi8hl6Mwc3Dwxp8L1SpMeJ6EwKnUZQaPWg8b1aimua+aHOmIOjXbVuKCKeWSgoajlb+esXKCLkxdJrW1qZf8+bbXaR6NxpTGeMhPU5yhq6tobpjIZqlmpgYHMlTzyOJCF/jkErucE3t9tDX/khNq1+vXjfpxz3GkCawePwIUF8Y6LGsDMInRYrLSTeUzcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LTUQDkb378YPmw68zWXSz4SJmRldwpuVhfPkRL4Fis=; b=DzZm+U73L5mKW9IIwafwM5E3IxnI6tzPCbL/Mi+LuC0dNN6Zh7fh+ER0VQuHfvynsUKA3FmTUy1RcnVpXW5YRueoY4PhwvfaIuyz0+iMaTRyYwSrmdruOJ9Ac4m/OA+hSEO5zXFNDS9qpn7aDST9miG1GwrNX+sgly10MwaPJT7ynBcUBmJkeX7tw0KHjRNPP7iB9WFIW8zA5XrRBANB0H8/jjjZjO3/obuYeyitmwY0atm2uk3D4N3asmt3DLmDL3q1ISqegrWnZCVEloyXoSfLTdr5DglwAfDwKAeHOv4OwUWRP4C2RYgvVz/33raNuCvb7LOUlYkKADeS0ACnyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LTUQDkb378YPmw68zWXSz4SJmRldwpuVhfPkRL4Fis=; b=XwgxxAKg2qf4tPBB6jefzVLIauzn+PQZ6vxJXoTDMM2+A3CUOihM2J6zTiMBtSccJczDZEwlDG51tSLBTBjs8QOSKh1w6t/CJ67+DKIv5q3HUthGSWmlUCq9/II8WwXlyVKh23KyFNyZEIxP/+TmCOH54ATjbdpqHMw+QGRTgr8TR09X5kVZAAMLLYMxpMuMTgnE+96tcdS0HV67HOShh4VEFnAlIXQ4MnMyQqUtkz2/57XEjbXhHeWLQp+CgsLOvic/dQhCDPa25frAdE32Qn9mFrSnzPaHtqcNVqzTwNWKibIyMGrrTINDqNLj44FeO4Njd5qEN1qlOMqn8jHKcw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB8PR04MB6858.eurprd04.prod.outlook.com (2603:10a6:10:113::9) by PA1PR04MB10099.eurprd04.prod.outlook.com (2603:10a6:102:45d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.15; Thu, 8 Oct 2026 09:03:39 +0000 Received: from DB8PR04MB6858.eurprd04.prod.outlook.com ([fe80::bc6f:5fd7:462:d0b5]) by DB8PR04MB6858.eurprd04.prod.outlook.com ([fe80::bc6f:5fd7:462:d0b5%6]) with mapi id 15.21.0496.015; Thu, 8 Oct 2026 09:03:39 +0000 From: Zhipeng.wang_1@oss.nxp.com To: Thomas Gleixner , Marc Zyngier , Frank Li Cc: Radu Rendec , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jindong Yue , xuegang.liu@nxp.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 4/9] irqchip/imx-irqsteer: Convert to devm_pm_runtime_set_active_enabled() Date: Thu, 8 Oct 2026 18:02:26 +0900 Message-Id: <20261008090231.796511-5-Zhipeng.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261008090231.796511-1-Zhipeng.wang_1@oss.nxp.com> References: <20261008090231.796511-1-Zhipeng.wang_1@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MA5PR01CA0288.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:21b::16) To DB8PR04MB6858.eurprd04.prod.outlook.com (2603:10a6:10:113::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR04MB6858:EE_|PA1PR04MB10099:EE_ X-MS-Office365-Filtering-Correlation-Id: 69238aff-bfad-4108-6572-08df251b0b4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|19092799006|1800799024|366016|11063799006|6133799003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: howM3hJaMerHRuPCbN68zf0yOGNZhbzgQbzcoaqyewKvj4d5pUistlPaIzDTB5sbHp9uZo5gDAmVKcuzFKLa+WDhpAqTWPBUkbjJWXJuhr5LuWZz83H2ud2z4kzJEmiqHEyRNHAefL8qvfSpkgVnJOp4BxwGY8m3Xn4MkNl7vqgQ6lmdiMXncpmglCyUd+bBc+m6LmJIgxz5m37tKHp8pyrIfsQxhiLGe154WPN9/Vi9MhY1oL+HGET2oAgftmh3POd0ISSlBNvxzWBioGC4l30/74mC6Pn8yZLxq4yLXad/Na1mHtQStIM+z7JUG1NuDglb5CwWMX/PH+5OsBP84CfQoow1I2lAnGv+afmfcc2aZX1FdkQ9Mv7QU8HRaOmNnW+EhjixY8s7id2hf6viju0nxBkSu2Qwv52Xwwu1bC6aiL2vQEJ2Q2VoZis436SYPjNKWOD5b3io63YiozxSlJ2pd959qJTfPBdGagq1PNDVVOH8xf01CHKp372uPyZzMsaLqPU8THQ9EBrMSAVAGimz+5eexkOC4NhbQamc/vdxt8Szpv0kOvkElAkskHTdIIdzIUdwk7WIbZzYPEjz1geHzjSNfTrYFdddakJ1x8lmoDXhNREbnRY64gBUTEYjqKQdjfXuirfBQ6G+txu6EVojSKClcQMJhLGAzounSEQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR04MB6858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(19092799006)(1800799024)(366016)(11063799006)(6133799003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5l4+DfbXy32L/w5nd1jwa7/bRYJGJ8IOllKSRnInZHY34e9xiK5vUeb+dtjS?= =?us-ascii?Q?lfyCLst78myMSCYZXn+nz7nXCwKFXnUfCZwwQLSlRqJuTIGh2O1ekbm1Kblp?= =?us-ascii?Q?1h//mZ1DVSy21CgydeGErShGOuH4aLyftpR998bVC+WmcPj4SCqZikTKGRcb?= =?us-ascii?Q?GP4dWaJkUuT9Xq9iCvUCdVQAFjEbFTk2B1RWeoPsMTWkmfiCNqg6trMFk4Yw?= =?us-ascii?Q?QjvfJyKSDUWZ8owrdbfj7yZ8PhLevbW1PYmZlzSW6tOYMdKQGYkaWjaGRtbg?= =?us-ascii?Q?yP4S3Bf/3h8CeEVl5VhgvEeXP7d5w/kp0urauRwQOWDqTk6KSfsfv4HfpFhB?= =?us-ascii?Q?tQeOKMXQAWwS9ElzXaeEYvEnf95Gh17855+IUPM4DgYrCCe1kUjj1/VGia8M?= =?us-ascii?Q?zP+LDfw3U6aP4g/LZ8shbcVejjSq+cyXMlDz51KPK7QSokg4WhGVyOX4t+pR?= =?us-ascii?Q?Yvy37FK+iboUURVnaC/+jHDqA+uRfaK5zNBrk9XJo/M1BAhdouuLDXNKgby3?= =?us-ascii?Q?HqAb+c2rarfHGW2XmDl3hXBSBkEPuCKfqyFBBrxeKeuWLf2sH2Kt7l24EnCW?= =?us-ascii?Q?kHMFbZ6TYhliD/QxRvaOB0/ZmF+jnkfyEo7zpw9SdsXj0q/gjZGWXxi9c5Wa?= =?us-ascii?Q?/nT4EcWB99Qi0i0cqskf7JqX/ovcicYjOqIsmbtWndR3nhkANY5InnJZI1Ay?= =?us-ascii?Q?b0/7ExuSkS4/0v3qzHisb7pXJxXhgb6+ZbzqbKR3v9f1E88NfOzvYQKbOHFL?= =?us-ascii?Q?qmaFKnLNvlU/85df7LIOuzFuWzKf8XtVmFerixibmNS5CiK2J8Ez0aZE2im3?= =?us-ascii?Q?Zj55DHys2OdO4wFkzwxOS6xvoqKIwaTzUjI3bBzMBIftiiTRC2nFVmDVBXUq?= =?us-ascii?Q?fk2mYX4G7HfVrLyvTR7pdoqPPTuaY4j61V1fJUA6DHYUNTQAAisBdvdaTaWH?= =?us-ascii?Q?R/i+CbAcjq2TWl8eU1nwci36C67RqeRk4rdAytw0h9rOWijPrpAXI2AbOXFB?= =?us-ascii?Q?c5Co7mqrMNJSBqxWPsrEVfsgR3N+tDRKToZFeqD3DtrSsquOFWZ9MzGHLbC0?= =?us-ascii?Q?VY5w9nrkRs8MtvdOTj79rj8iPaLG3/6dgfeWEYphTOvc578hlK0Pwo2NqPw5?= =?us-ascii?Q?DCtuGbXzMfKoYsD910PYHWhzk1DkUDphuGcfW3EfZw9DFoZqZvFVw7WCXYQ6?= =?us-ascii?Q?erRjTsQJI4mF+tE8T/xKqHu4mdByMd/ejuE3o6NqbfeK5wQHseb0wCAVwqYq?= =?us-ascii?Q?bX8qIDcT8HPl9EXgV12ufSDHHDMPugk/Inx55fRssxFS9ZNPVqRQx7ah3ydl?= =?us-ascii?Q?BIgKV91AdiGMh9LMN8D9bM9WEVLBcem3drcjKdfHuOEgOsVChTtjSyzabzfr?= =?us-ascii?Q?XybUGwl3868bR5xgsXSr19r7OBhfF9BPKLpfHjOB9xc/3DUSQ1JLK+W40Hyd?= =?us-ascii?Q?8BGs1S+KvkBU/F2O/uGG32fRorqEIzEwaNi9x7MlRP3XqIkgAo2q9XEx+MYc?= =?us-ascii?Q?85tpSUYgZxuoYZHaqwFlFNFNzyT6MiSEkd1kcmTBVoCz46xPPcunq0Ll4SUS?= =?us-ascii?Q?SwxTkxSOg8z85HdRkqwy6zt0tkLI2D742XkJBIm6Dh696Ve8xSFcQQoMelLv?= =?us-ascii?Q?JXzx5UJOSslTfMTZTCELE6qXt6HmLkdtFma4hcFK7nsg4E//cgOSHXu+/UD4?= =?us-ascii?Q?DBrUqDVsR/xxMFgaRXw51uqt+xugi3LSlByqivMRYrhiYEoKjCvu+128/POR?= =?us-ascii?Q?pUUtQN9gykBfyIRbbzNIvU5J6e1phQYM9mzvSA/zvsI0tV8ebCXM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69238aff-bfad-4108-6572-08df251b0b4a X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB6858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2026 09:03:39.4793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9DFHd42k4fOfJFYgkP08Aia5JrrBFZSpplKosAbHo0uyPMiAgThDkaxmCti9WocxN2hIY8mWOcD6wnlv0YGgXSrSEqB19ItLitgTYxxljj1GWuvQWoo+pKwHEX+qwnbY X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10099 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_020344_245164_3F41983D X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zhipeng Wang imx_irqsteer_probe() enables runtime PM with pm_runtime_enable(), but imx_irqsteer_remove() never disables it. Runtime PM therefore stays enabled after the device is unbound, and rebinding it triggers: Unbalanced pm_runtime_enable! Use devm_pm_runtime_set_active_enabled() so the driver core marks the device active (matching the enabled clock) and disables runtime PM again on unbind, keeping the enable balanced across unbind/rebind. This becomes reachable once the driver can be unbound and reloaded, but the imbalance already exists today on unbind, so fix it separately with a Fixes tag for stable. Fixes: 4730d2233311 ("irqchip/imx-irqsteer: Add runtime PM support") Suggested-by: Fabio Estevam Signed-off-by: Zhipeng Wang --- drivers/irqchip/irq-imx-irqsteer.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index d05de3d26fb2..5acc04504e52 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -239,6 +239,10 @@ static int imx_irqsteer_probe(struct platform_device *pdev) if (irqsteer_has_chanctrl(data->devtype_data)) writel_relaxed(BIT(data->channel), data->regs + CHANCTRL); + ret = devm_pm_runtime_set_active_enabled(&pdev->dev); + if (ret) + goto out; + data->domain = irq_domain_create_linear(dev_fwnode(&pdev->dev), data->reg_num * 32, &imx_irqsteer_domain_ops, data); if (!data->domain) { @@ -260,9 +264,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data); - pm_runtime_set_active(&pdev->dev); - pm_runtime_enable(&pdev->dev); - return 0; out: clk_disable_unprepare(data->ipg_clk); @@ -285,7 +286,8 @@ static void imx_irqsteer_remove(struct platform_device *pdev) irq_domain_remove(irqsteer_data->domain); - clk_disable_unprepare(irqsteer_data->ipg_clk); + if (!pm_runtime_status_suspended(&pdev->dev)) + clk_disable_unprepare(irqsteer_data->ipg_clk); } #ifdef CONFIG_PM -- 2.34.1